Commit 93eaba46 authored by Vadym Doroshenko's avatar Vadym Doroshenko Committed by Commit Bot

Expose FieldInfoManager in PasswordManagerClient.

Bug: 959776
Change-Id: I1398b271633dd731a363b32b2c69a67764f0aa6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911204
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714472}
parent 28743bd4
......@@ -21,6 +21,7 @@
#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
#include "chrome/browser/password_manager/account_storage/account_password_store_factory.h"
#include "chrome/browser/password_manager/field_info_manager_factory.h"
#include "chrome/browser/password_manager/password_store_factory.h"
#include "chrome/browser/prerender/prerender_contents.h"
#include "chrome/browser/profiles/profile.h"
......@@ -46,6 +47,7 @@
#include "components/password_manager/content/browser/password_manager_log_router_factory.h"
#include "components/password_manager/content/browser/password_requirements_service_factory.h"
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
#include "components/password_manager/core/browser/field_info_manager.h"
#include "components/password_manager/core/browser/hsts_query.h"
#include "components/password_manager/core/browser/http_auth_manager.h"
#include "components/password_manager/core/browser/http_auth_manager_impl.h"
......@@ -129,6 +131,7 @@ using autofill::PasswordForm;
using autofill::mojom::FocusedFieldType;
using password_manager::BadMessageReason;
using password_manager::ContentPasswordManagerDriverFactory;
using password_manager::FieldInfoManager;
using password_manager::PasswordManagerClientHelper;
using password_manager::PasswordManagerDriver;
using password_manager::PasswordManagerMetricsRecorder;
......@@ -1104,6 +1107,10 @@ bool ChromePasswordManagerClient::IsNewTabPage() const {
return GetMainFrameURL() == chrome::kChromeSearchLocalNtpUrl;
}
FieldInfoManager* ChromePasswordManagerClient::GetFieldInfoManager() const {
return FieldInfoManagerFactory::GetForBrowserContext(profile_);
}
// static
void ChromePasswordManagerClient::BindCredentialManager(
mojo::PendingReceiver<blink::mojom::CredentialManager> receiver,
......
......@@ -153,6 +153,7 @@ class ChromePasswordManagerClient
void NavigateToManagePasswordsPage(
password_manager::ManagePasswordsReferrer referrer) override;
bool IsNewTabPage() const override;
password_manager::FieldInfoManager* GetFieldInfoManager() const override;
// autofill::mojom::PasswordGenerationDriver overrides.
void AutomaticGenerationAvailable(
......
......@@ -54,6 +54,7 @@ class PasswordProtectionService;
namespace password_manager {
class FieldInfoManager;
class PasswordFeatureManager;
class PasswordFormManagerForUI;
class PasswordManager;
......@@ -355,6 +356,9 @@ class PasswordManagerClient {
// Returns true if the current page is to the new tab page.
virtual bool IsNewTabPage() const = 0;
// Returns a FieldInfoManager associated with the current profile.
virtual FieldInfoManager* GetFieldInfoManager() const = 0;
private:
DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
};
......
......@@ -151,4 +151,8 @@ bool StubPasswordManagerClient::IsNewTabPage() const {
return false;
}
FieldInfoManager* StubPasswordManagerClient::GetFieldInfoManager() const {
return nullptr;
}
} // namespace password_manager
......@@ -91,6 +91,7 @@ class StubPasswordManagerClient : public PasswordManagerClient {
scoped_refptr<network::SharedURLLoaderFactory> GetURLLoaderFactory() override;
bool IsIsolationForPasswordSitesEnabled() const override;
bool IsNewTabPage() const override;
FieldInfoManager* GetFieldInfoManager() const override;
private:
const StubCredentialsFilter credentials_filter_;
......
......@@ -135,6 +135,7 @@ class IOSChromePasswordManagerClient
GetPasswordRequirementsService() override;
bool IsIsolationForPasswordSitesEnabled() const override;
bool IsNewTabPage() const override;
password_manager::FieldInfoManager* GetFieldInfoManager() const override;
private:
__weak id<PasswordManagerClientDelegate> delegate_;
......
......@@ -266,3 +266,8 @@ bool IOSChromePasswordManagerClient::IsIsolationForPasswordSitesEnabled()
bool IOSChromePasswordManagerClient::IsNewTabPage() const {
return false;
}
password_manager::FieldInfoManager*
IOSChromePasswordManagerClient::GetFieldInfoManager() const {
return nullptr;
}
......@@ -115,6 +115,7 @@ class WebViewPasswordManagerClient
scoped_refptr<network::SharedURLLoaderFactory> GetURLLoaderFactory() override;
bool IsIsolationForPasswordSitesEnabled() const override;
bool IsNewTabPage() const override;
password_manager::FieldInfoManager* GetFieldInfoManager() const override;
private:
__weak id<CWVPasswordManagerClientDelegate> delegate_;
......
......@@ -233,4 +233,9 @@ bool WebViewPasswordManagerClient::IsNewTabPage() const {
return false;
}
password_manager::FieldInfoManager*
WebViewPasswordManagerClient::GetFieldInfoManager() const {
return nullptr;
}
} // namespace ios_web_view
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment