Commit 93fb3b55 authored by Alice Wang's avatar Alice Wang Committed by Chromium LUCI CQ

[Signin][Modularization] Move confirm sync dialog tests to signin.ui module

This CL moves two confirm sync dialog tests to the junit target of
c.b.signin.ui module.

Bug: 1156585, 1156588
Change-Id: I3f54d90707a20ab22671d3f20e8ef1146c784cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584977Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836556}
parent f6b0dad1
...@@ -203,8 +203,6 @@ chrome_junit_test_java_sources = [ ...@@ -203,8 +203,6 @@ chrome_junit_test_java_sources = [
"junit/src/org/chromium/chrome/browser/search_engines/settings/SearchEngineAdapterTest.java", "junit/src/org/chromium/chrome/browser/search_engines/settings/SearchEngineAdapterTest.java",
"junit/src/org/chromium/chrome/browser/send_tab_to_self/SendTabToSelfShareActivityTest.java", "junit/src/org/chromium/chrome/browser/send_tab_to_self/SendTabToSelfShareActivityTest.java",
"junit/src/org/chromium/chrome/browser/sharing/click_to_call/ClickToCallMessageHandlerTest.java", "junit/src/org/chromium/chrome/browser/sharing/click_to_call/ClickToCallMessageHandlerTest.java",
"junit/src/org/chromium/chrome/browser/signin/ConfirmImportSyncDataDialogTest.java",
"junit/src/org/chromium/chrome/browser/signin/ConfirmManagedSyncDataDialogTest.java",
"junit/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachineTest.java", "junit/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachineTest.java",
"junit/src/org/chromium/chrome/browser/signin/SignOutDialogFragmentTest.java", "junit/src/org/chromium/chrome/browser/signin/SignOutDialogFragmentTest.java",
"junit/src/org/chromium/chrome/browser/signin/SigninManagerTest.java", "junit/src/org/chromium/chrome/browser/signin/SigninManagerTest.java",
......
...@@ -60,10 +60,16 @@ android_resources("java_resources") { ...@@ -60,10 +60,16 @@ android_resources("java_resources") {
android_library("junit") { android_library("junit") {
bypass_platform_checks = true bypass_platform_checks = true
testonly = true testonly = true
sources = [ "junit/src/org/chromium/chrome/browser/signin/ui/ConfirmSyncDataStateMachineDelegateTest.java" ] sources = [
"junit/src/org/chromium/chrome/browser/signin/ui/ConfirmImportSyncDataDialogTest.java",
"junit/src/org/chromium/chrome/browser/signin/ui/ConfirmManagedSyncDataDialogTest.java",
"junit/src/org/chromium/chrome/browser/signin/ui/ConfirmSyncDataStateMachineDelegateTest.java",
]
deps = [ deps = [
":java", ":java",
"//base:base_junit_test_support", "//base:base_junit_test_support",
"//chrome/browser/profiles/android:java",
"//chrome/browser/signin/services/android:java",
"//third_party/android_deps:androidx_appcompat_appcompat_java", "//third_party/android_deps:androidx_appcompat_appcompat_java",
"//third_party/android_deps:androidx_fragment_fragment_java", "//third_party/android_deps:androidx_fragment_fragment_java",
"//third_party/android_deps:robolectric_all_java", "//third_party/android_deps:robolectric_all_java",
......
// Copyright 2019 The Chromium Authors. All rights reserved. // Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.signin;
package org.chromium.chrome.browser.signin.ui;
import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
...@@ -24,17 +25,12 @@ import org.robolectric.shadows.ShadowAlertDialog; ...@@ -24,17 +25,12 @@ import org.robolectric.shadows.ShadowAlertDialog;
import org.robolectric.shadows.ShadowToast; import org.robolectric.shadows.ShadowToast;
import org.chromium.base.test.BaseRobolectricTestRunner; import org.chromium.base.test.BaseRobolectricTestRunner;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.profiles.Profile; import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.signin.services.IdentityServicesProvider; import org.chromium.chrome.browser.signin.services.IdentityServicesProvider;
import org.chromium.chrome.browser.signin.services.SigninManager; import org.chromium.chrome.browser.signin.services.SigninManager;
import org.chromium.chrome.browser.signin.ui.ConfirmImportSyncDataDialog;
import org.chromium.chrome.browser.signin.ui.ConfirmSyncDataStateMachineDelegate;
/** /**
* Tests for {@link ConfirmImportSyncDataDialog}. * Tests for {@link ConfirmImportSyncDataDialog}.
* TODO(https://crbug.com/1156585): Modularize this class after moving the
* {@link ConfirmSyncDataStateMachineDelegate}.
*/ */
@RunWith(BaseRobolectricTestRunner.class) @RunWith(BaseRobolectricTestRunner.class)
public class ConfirmImportSyncDataDialogTest { public class ConfirmImportSyncDataDialogTest {
......
// Copyright 2019 The Chromium Authors. All rights reserved. // Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.signin;
package org.chromium.chrome.browser.signin.ui;
import static org.mockito.Mockito.never; import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
...@@ -22,14 +23,9 @@ import org.robolectric.Robolectric; ...@@ -22,14 +23,9 @@ import org.robolectric.Robolectric;
import org.robolectric.shadows.ShadowAlertDialog; import org.robolectric.shadows.ShadowAlertDialog;
import org.chromium.base.test.BaseRobolectricTestRunner; import org.chromium.base.test.BaseRobolectricTestRunner;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.signin.ui.ConfirmManagedSyncDataDialog;
import org.chromium.chrome.browser.signin.ui.ConfirmSyncDataStateMachineDelegate;
/** /**
* Tests for {@link ConfirmManagedSyncDataDialog}. * Tests for {@link ConfirmManagedSyncDataDialog}.
* TODO(https://crbug.com/1156588): Modularize this class after moving the
* {@link ConfirmSyncDataStateMachineDelegate}.
*/ */
@RunWith(BaseRobolectricTestRunner.class) @RunWith(BaseRobolectricTestRunner.class)
public class ConfirmManagedSyncDataDialogTest { public class ConfirmManagedSyncDataDialogTest {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment