Commit 943791f2 authored by Jinsuk Kim's avatar Jinsuk Kim Committed by Chromium LUCI CQ

BottomSheet: Fix bottom sheet being hidden due to suppression

A bug causing FullscreenManager to call #onEnterFullscreen
more often than #onExitFullscreen makes BottomSheet suppressed.
This CL makes sure BottomSheetManager handle suppress token
in such a way that the number of the same event calls doesn't
matter.

Bug: 1157368
Change-Id: I70b951dffc242d8da75fa74bc451a5d0864536d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589143
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836938}
parent b1cd0af7
...@@ -241,7 +241,9 @@ class BottomSheetManager extends EmptyBottomSheetObserver implements Destroyable ...@@ -241,7 +241,9 @@ class BottomSheetManager extends EmptyBottomSheetObserver implements Destroyable
} }
if (mTabProvider.get() != tab) return; if (mTabProvider.get() != tab) return;
int previousToken = mToken;
mToken = controller.suppressSheet(StateChangeReason.COMPOSITED_UI); mToken = controller.suppressSheet(StateChangeReason.COMPOSITED_UI);
controller.unsuppressSheet(previousToken);
} }
@Override @Override
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment