CrOS GMC: Allow focus to media dialog and quick setting controls.

This CL fix the issue where user cannot use keyboard to access
global media controls dialog and detailed controls in quick settings.

Change-Id: I909e00e4e55ad0460886eb3ea3e231eaf0d79195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503399Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821678}

ash/system/media/media_tray.cc

@@ -4,6 +4,7 @@
 
 #include "ash/system/media/media_tray.h"
 
+#include "ash/focus_cycler.h"
 #include "ash/public/cpp/ash_pref_names.h"
 #include "ash/public/cpp/media_notification_provider.h"
 #include "ash/resources/vector_icons/vector_icons.h"
@@ -289,6 +290,13 @@ void MediaTray::ShowBubble(bool show_by_click) {
                                                 false /*is_persistent*/);
   SetIsActive(true);
 
+  // Only focus the widget if it's opened by the keyboard.
+  if (!show_by_click) {
+    views::Widget* widget = bubble_->GetBubbleWidget();
+    widget->widget_delegate()->SetCanActivate(true);
+    Shell::Get()->focus_cycler()->FocusWidget(widget);
+  }
+
   base::UmaHistogramBoolean("Media.CrosGlobalMediaControls.RepeatUsageOnShelf",
                             bubble_has_shown_);
   bubble_has_shown_ = true;

ash/system/media/media_tray_unittest.cc

@@ -283,6 +283,11 @@ TEST_F(MediaTrayTest, PinToShelfDefaultBehavior) {
   EXPECT_TRUE(MediaTray::IsPinnedToShelf());
 }
 
+TEST_F(MediaTrayTest, BubbleGetsFocusWhenOpenWithKeyboard) {
+  media_tray()->ShowBubble(false /* show_by_click */);
+  EXPECT_TRUE(GetBubbleWrapper()->GetBubbleWidget()->IsActive());
+}
+
 TEST_F(MediaTrayTest, DialogAnchor) {
   InsertMockTray();
 

ash/system/media/unified_media_controls_view.cc

@@ -105,6 +105,9 @@ UnifiedMediaControlsView::MediaActionButton::MediaActionButton(
 
   TrayPopupUtils::ConfigureTrayPopupButton(this);
   views::InstallCircleHighlightPathGenerator(this);
+
+  focus_ring()->SetColor(AshColorProvider::Get()->GetControlsLayerColor(
+      AshColorProvider::ControlsLayerType::kFocusRingColor));
 }
 
 void UnifiedMediaControlsView::MediaActionButton::SetAction(
@@ -147,7 +150,9 @@ UnifiedMediaControlsView::MediaActionButton::CreateInkDropRipple() const {
 UnifiedMediaControlsView::UnifiedMediaControlsView(
     UnifiedMediaControlsController* controller)
     : views::Button(this), controller_(controller) {
-  SetFocusBehavior(views::View::FocusBehavior::ACCESSIBLE_ONLY);
+  SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
+  focus_ring()->SetColor(AshColorProvider::Get()->GetControlsLayerColor(
+      AshColorProvider::ControlsLayerType::kFocusRingColor));
 
   SetBackground(views::CreateRoundedRectBackground(
       AshColorProvider::Get()->GetControlsLayerColor(