Clean up callback interface code and template

The callback interface code was the first code and template we wrote.
Since then we've improved style and template usage; this simplifies
the code and brings it up-to-date.

TBR=haraken
BUG=345503

Review URL: https://codereview.chromium.org/215993002

git-svn-id: svn://svn.chromium.org/blink/trunk@170254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py

@@ -53,16 +53,6 @@ CALLBACK_INTERFACE_CPP_INCLUDES = frozenset([
 ])
 
 
-def cpp_to_v8_conversion(idl_type, name):
-    # FIXME: setting creation_context=v8::Handle<v8::Object>() is wrong,
-    # as toV8 then implicitly uses the current context, which causes leaks
-    # between isolate worlds if a different context should be used.
-    cpp_value_to_v8_value = idl_type.cpp_value_to_v8_value(name,
-        isolate='m_isolate', creation_context='v8::Handle<v8::Object>()')
-    return 'v8::Handle<v8::Value> {name}Handle = {cpp_to_v8};'.format(
-        name=name, cpp_to_v8=cpp_value_to_v8_value)
-
-
 def cpp_type(idl_type):
     # FIXME: remove this function by making callback types consistent
     # (always use usual v8_types.cpp_type)
@@ -83,18 +73,14 @@ IdlType.callback_cpp_type = property(cpp_type)
 def generate_callback_interface(callback_interface):
     includes.clear()
     includes.update(CALLBACK_INTERFACE_CPP_INCLUDES)
-    name = callback_interface.name
-
-    methods = [generate_method(operation)
-               for operation in callback_interface.operations]
-    template_contents = {
+    return {
         'conditional_string': v8_utilities.conditional_string(callback_interface),
-        'cpp_class': name,
+        'cpp_class': callback_interface.name,
         'v8_class': v8_utilities.v8_class_name(callback_interface),
         'header_includes': set(CALLBACK_INTERFACE_H_INCLUDES),
-        'methods': methods,
+        'methods': [generate_method(operation)
+                    for operation in callback_interface.operations],
     }
-    return template_contents
 
 
 def add_includes_for_operation(operation):
@@ -128,17 +114,21 @@ def generate_method(operation):
 def generate_arguments_contents(arguments, call_with_this_handle):
     def generate_argument(argument):
         return {
-            'name': argument.name,
-            'cpp_to_v8_conversion': cpp_to_v8_conversion(argument.idl_type, argument.name),
+            'handle': '%sHandle' % argument.name,
+            # FIXME: setting creation_context=v8::Handle<v8::Object>() is
+            # wrong, as toV8 then implicitly uses the current context, which
+            # causes leaks between isolated worlds if a different context is
+            # used.
+            'cpp_value_to_v8_value': argument.idl_type.cpp_value_to_v8_value(
+                argument.name, isolate='m_isolate',
+                creation_context='v8::Handle<v8::Object>()'),
         }
 
-    argument_declarations = [
-            '%s %s' % (argument.idl_type.callback_cpp_type, argument.name)
-            for argument in arguments]
-    if call_with_this_handle:
-        argument_declarations.insert(0, 'ScriptValue thisValue')
+    argument_declarations = ['ScriptValue thisValue'] if call_with_this_handle else []
+    argument_declarations.extend(
+        '%s %s' % (argument.idl_type.callback_cpp_type, argument.name)
+        for argument in arguments)
     return  {
         'argument_declarations': argument_declarations,
         'arguments': [generate_argument(argument) for argument in arguments],
-        'handles': ['%sHandle' % argument.name for argument in arguments],
     }

third_party/WebKit/Source/bindings/templates/callback_interface.cpp

@@ -51,15 +51,15 @@ namespace WebCore {
     ASSERT(thisHandle->IsObject());
     {% endif %}
     {% for argument in method.arguments %}
-    {{argument.cpp_to_v8_conversion | indent}}
-    if ({{argument.name}}Handle.IsEmpty()) {
+    v8::Handle<v8::Value> {{argument.handle}} = {{argument.cpp_value_to_v8_value}};
+    if ({{argument.handle}}.IsEmpty()) {
         if (!isScriptControllerTerminating())
             CRASH();
         {{return_default}};
     }
     {% endfor %}
     {% if method.arguments %}
-    v8::Handle<v8::Value> argv[] = { {{method.handles | join(', ')}} };
+    v8::Handle<v8::Value> argv[] = { {{method.arguments | join(', ', attribute='handle')}} };
     {% else %}
     v8::Handle<v8::Value> *argv = 0;
     {% endif %}