Commit 945356c4 authored by Domenic Denicola's avatar Domenic Denicola Committed by Chromium LUCI CQ

Revert "Reland "Origin isolation: enable by default""

This reverts commit 7e5912e8.

Reason for revert: we're planning to launch this to M88+ using Finch instead. See https://docs.google.com/document/d/1bXwJwJAGP-2msI9IU6kbrZH9zBvQkTVNpjiKIxKZFhg/edit?ts=5fd309ef# for more details.

Original change's description:
> Reland "Origin isolation: enable by default"
>
> This reverts commit 0ea7d517.
>
> Reason for revert: A fix for the problem that lead to this revert has been landed in r831153 and we need to re-enable this change to test it.
>
> Original change's description:
> > Revert "Origin isolation: enable by default"
> >
> > This reverts commit 824b062d.
> >
> > Reason for revert: Causing crashes with hosted apps in https://crbug.com/1141721.
> >
> > Original change's description:
> > > Origin isolation: enable by default
> > >
> > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI
> > >
> > > Further work on removing origin trial code and the flags is tracked in
> > > https://crbug.com/1148056 and https://crbug.com/1148057.
> > >
> > > Bug: 1042415
> > > Change-Id: Icbeecd0b592c76d36e2111b8e4d8fe30dbb63343
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533145
> > > Commit-Queue: Domenic Denicola <domenic@chromium.org>
> > > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#826910}
> >
> > TBR=creis@chromium.org,alexmos@chromium.org,jochen@chromium.org,domenic@chromium.org,yoavweiss@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1042415, 1141721
> > Change-Id: I428b190fc4c6bdf39de5ffb43226ba91851e7544
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553209
> > Reviewed-by: Domenic Denicola <domenic@chromium.org>
> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > Reviewed-by: Charlie Reis <creis@chromium.org>
> > Commit-Queue: Charlie Reis <creis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#829937}
>
> TBR=creis@chromium.org,alexmos@chromium.org,domenic@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1042415
> Bug: 1141721
> Change-Id: I6cf3211dc675bd2351c8dc6831e8d3e2495d8c2e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560907
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Commit-Queue: James MacLean <wjmaclean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#831175}

TBR=creis@chromium.org,alexmos@chromium.org,domenic@chromium.org,wjmaclean@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1042415
Bug: 1141721
Change-Id: I14fc536d9389f6706b15f241182e4a65b09f1a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587453Reviewed-by: default avatarDomenic Denicola <domenic@chromium.org>
Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836327}
parent 0b36320a
......@@ -445,7 +445,7 @@ const base::Feature kNotificationTriggers{"NotificationTriggers",
// Note that the origin policy-based variant of origin isolation is controlled
// by kOriginPolicy, instead.
const base::Feature kOriginIsolationHeader{"OriginIsolationHeader",
base::FEATURE_ENABLED_BY_DEFAULT};
base::FEATURE_DISABLED_BY_DEFAULT};
// Origin Policy. See https://crbug.com/751996
const base::Feature kOriginPolicy{"OriginPolicy",
......
......@@ -1399,7 +1399,7 @@
{
name: "OriginIsolationHeader",
origin_trial_feature_name: "OriginIsolationHeader",
status: "stable",
status: "experimental",
},
{
name: "OriginPolicy",
......
......@@ -172,7 +172,6 @@ PASS oldChildWindow.onwebkittransitionend is newChildWindow.onwebkittransitionen
PASS oldChildWindow.onwheel is newChildWindow.onwheel
PASS oldChildWindow.opener is newChildWindow.opener
PASS oldChildWindow.origin is newChildWindow.origin
PASS oldChildWindow.originIsolated is newChildWindow.originIsolated
PASS oldChildWindow.outerHeight is newChildWindow.outerHeight
PASS oldChildWindow.outerWidth is newChildWindow.outerWidth
PASS oldChildWindow.pageXOffset is newChildWindow.pageXOffset
......
......@@ -147,7 +147,6 @@ PASS childWindow.onwebkittransitionend is null
PASS childWindow.onwheel is null
PASS childWindow.opener is null
PASS childWindow.origin is 'file://'
PASS childWindow.originIsolated is false
PASS childWindow.outerHeight is 0
PASS childWindow.outerWidth is 0
PASS childWindow.pageXOffset is 0
......
......@@ -147,7 +147,6 @@ PASS childWindow.onwebkittransitionend is null
PASS childWindow.onwheel is null
PASS childWindow.opener is null
PASS childWindow.origin is 'file://'
PASS childWindow.originIsolated is false
PASS childWindow.outerHeight is 0
PASS childWindow.outerWidth is 0
PASS childWindow.pageXOffset is 0
......
......@@ -9709,7 +9709,6 @@ namespace CSS
getter onwheel
getter opener
getter origin
getter originIsolated
getter outerHeight
getter outerWidth
getter pageXOffset
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment