Commit 946e35ba authored by David Munro's avatar David Munro Committed by Commit Bot

crostini: More descriptive aria label for the disk resizing button.

Test: Manual with ChromeVox
Bug: chromium:1061778
Change-Id: Iec82ac9c785dafea14e4a4484178b2b5c0fca007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135104
Commit-Queue: David Munro <davidmunro@google.com>
Reviewed-by: default avatarJulian Watson <juwa@google.com>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756954}
parent b666ef16
...@@ -964,6 +964,9 @@ ...@@ -964,6 +964,9 @@
<message name="IDS_SETTINGS_CROSTINI_DISK_RESIZE_SHOW_BUTTON" desc="The label of the button/link the user clicks to open the disk resizing dialogue." meaning="The label of the button/link the user clicks to open the disk resizing dialogue."> <message name="IDS_SETTINGS_CROSTINI_DISK_RESIZE_SHOW_BUTTON" desc="The label of the button/link the user clicks to open the disk resizing dialogue." meaning="The label of the button/link the user clicks to open the disk resizing dialogue.">
Change Change
</message> </message>
<message name="IDS_SETTINGS_CROSTINI_DISK_RESIZE_SHOW_BUTTON_ARIA_LABEL" desc="The aria label for the button to show the disk resize dialog i.e. the text that screen readers will read out for the button.">
Change disk size
</message>
<message name="IDS_SETTINGS_CROSTINI_DISK_RESIZE_LABEL" desc="The label on the row in settings for managing Crostini's disk size."> <message name="IDS_SETTINGS_CROSTINI_DISK_RESIZE_LABEL" desc="The label on the row in settings for managing Crostini's disk size.">
Disk size Disk size
</message> </message>
......
...@@ -80,12 +80,13 @@ ...@@ -80,12 +80,13 @@
</template> </template>
<template is="dom-if" if="[[showCrostiniDiskResize_]]"> <template is="dom-if" if="[[showCrostiniDiskResize_]]">
<div class="settings-box hr" id="crostini-disk-resize"> <div class="settings-box hr" id="crostini-disk-resize">
<div class="start"> <div class="start" aria-hidden="true">
$i18n{crostiniDiskResizeLabel} $i18n{crostiniDiskResizeLabel}
</div> </div>
<cr-button on-click="onDiskResizeClick_" <cr-button on-click="onDiskResizeClick_"
aria-labelledby="diskResizeLabel" id="showDiskResizeButton"> aria-label="$i18n{crostiniDiskResizeShowButtonAriaLabel}"
$i18n{crostiniDiskResizeShowButton} id="showDiskResizeButton">
$i18n{crostiniDiskResizeShowButton}
</cr-button> </cr-button>
</div> </div>
<template is="dom-if" if="[[showDiskResizeDialog_]]" restamp> <template is="dom-if" if="[[showDiskResizeDialog_]]" restamp>
......
...@@ -702,6 +702,8 @@ void AddCrostiniStrings(content::WebUIDataSource* html_source, ...@@ -702,6 +702,8 @@ void AddCrostiniStrings(content::WebUIDataSource* html_source,
{"crostiniDiskResizeTitle", IDS_SETTINGS_CROSTINI_DISK_RESIZE_TITLE}, {"crostiniDiskResizeTitle", IDS_SETTINGS_CROSTINI_DISK_RESIZE_TITLE},
{"crostiniDiskResizeShowButton", {"crostiniDiskResizeShowButton",
IDS_SETTINGS_CROSTINI_DISK_RESIZE_SHOW_BUTTON}, IDS_SETTINGS_CROSTINI_DISK_RESIZE_SHOW_BUTTON},
{"crostiniDiskResizeShowButtonAriaLabel",
IDS_SETTINGS_CROSTINI_DISK_RESIZE_SHOW_BUTTON_ARIA_LABEL},
{"crostiniDiskResizeLabel", IDS_SETTINGS_CROSTINI_DISK_RESIZE_LABEL}, {"crostiniDiskResizeLabel", IDS_SETTINGS_CROSTINI_DISK_RESIZE_LABEL},
{"crostiniDiskResizeUnsupported", {"crostiniDiskResizeUnsupported",
IDS_SETTINGS_CROSTINI_DISK_RESIZE_UNSUPPORTED}, IDS_SETTINGS_CROSTINI_DISK_RESIZE_UNSUPPORTED},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment