Commit 9495994e authored by Thomas Tangl's avatar Thomas Tangl Committed by Commit Bot

[Dice] Show sync-paused action button on main settings page

When sync is paused, a button to signin again is shown
in the sync account control on the main settings page.

Bug: 902949
Change-Id: I818034d4d6980ff3d26c4eb8429a13fe20a6fbf2
Reviewed-on: https://chromium-review.googlesource.com/c/1324399Reviewed-by: default avatarScott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606641}
parent ee72ef69
......@@ -260,7 +260,7 @@ Polymer({
*/
shouldShowSigninAgainButton_: function() {
return !this.hideButtons && !!this.syncStatus.signedIn &&
this.embeddedInSubpage && !!this.syncStatus.hasError &&
!!this.syncStatus.hasError &&
this.syncStatus.statusAction == settings.StatusAction.REAUTHENTICATE;
},
......
......@@ -273,8 +273,8 @@ cr.define('settings_sync_account_control', function() {
assertFalse(displayedText.includes('barName'));
assertFalse(displayedText.includes('fooName'));
assertTrue(displayedText.includes('Sync is paused'));
// Not embedded in a subpage, so there is no sync-paused button.
assertVisible(testElement.$$('#sync-paused-button'), false);
// The sync-paused button is shown to resolve the error.
assertVisible(testElement.$$('#sync-paused-button'), true);
testElement.syncStatus = {
signedIn: true,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment