Commit 94b8a70a authored by DongJun Kim's avatar DongJun Kim Committed by Commit Bot

Add return functions for preventing crash

Previous codes do not return directly even if
plugin_instance and load_manager are null.
It can occur crash whenever accessing each variables.
This patch add return codes for avoiding crash
if variable is null.

BUG=NONE

Change-Id: Ia5c59a9473124d6ad1ff76ee909d9396af35e96c
Reviewed-on: https://chromium-review.googlesource.com/586488Reviewed-by: default avatarRaymes Khoury <raymes@chromium.org>
Reviewed-by: default avatarBill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491067}
parent c248388e
...@@ -1024,6 +1024,7 @@ void DownloadManifestToBuffer(PP_Instance instance, ...@@ -1024,6 +1024,7 @@ void DownloadManifestToBuffer(PP_Instance instance,
FROM_HERE, FROM_HERE,
base::Bind(callback.func, callback.user_data, base::Bind(callback.func, callback.user_data,
static_cast<int32_t>(PP_ERROR_FAILED))); static_cast<int32_t>(PP_ERROR_FAILED)));
return;
} }
const blink::WebDocument& document = const blink::WebDocument& document =
plugin_instance->GetContainer()->GetDocument(); plugin_instance->GetContainer()->GetDocument();
...@@ -1379,6 +1380,7 @@ void PPBNaClPrivate::DownloadNexe(PP_Instance instance, ...@@ -1379,6 +1380,7 @@ void PPBNaClPrivate::DownloadNexe(PP_Instance instance,
FROM_HERE, FROM_HERE,
base::Bind(callback.func, callback.user_data, base::Bind(callback.func, callback.user_data,
static_cast<int32_t>(PP_ERROR_FAILED))); static_cast<int32_t>(PP_ERROR_FAILED)));
return;
} }
const blink::WebDocument& document = const blink::WebDocument& document =
plugin_instance->GetContainer()->GetDocument(); plugin_instance->GetContainer()->GetDocument();
...@@ -1531,6 +1533,7 @@ void DownloadFile(PP_Instance instance, ...@@ -1531,6 +1533,7 @@ void DownloadFile(PP_Instance instance,
base::ThreadTaskRunnerHandle::Get()->PostTask( base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(callback, static_cast<int32_t>(PP_ERROR_FAILED), FROM_HERE, base::Bind(callback, static_cast<int32_t>(PP_ERROR_FAILED),
kInvalidNaClFileInfo)); kInvalidNaClFileInfo));
return;
} }
const blink::WebDocument& document = const blink::WebDocument& document =
plugin_instance->GetContainer()->GetDocument(); plugin_instance->GetContainer()->GetDocument();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment