Commit 94c8f1ad authored by mikecase's avatar mikecase Committed by Commit bot

Made ChromeShellSyncTests run alongside the other instrumentation tests.

The ChromeShellSyncTest tests have been running on some of the
chromium-fyi android bots. The tests have passed consistently for
several days and I am now moving them to run with the rest of the
instrumentation tests.

BUG=406538

Review URL: https://codereview.chromium.org/680573004

Cr-Commit-Position: refs/heads/master@{#301471}
parent b904b15f
...@@ -73,9 +73,14 @@ INSTRUMENTATION_TESTS = dict((suite.name, suite) for suite in [ ...@@ -73,9 +73,14 @@ INSTRUMENTATION_TESTS = dict((suite.name, suite) for suite in [
'org.chromium.android_webview.shell', 'org.chromium.android_webview.shell',
'AndroidWebViewTest', 'AndroidWebViewTest',
'webview:android_webview/test/data/device_files'), 'webview:android_webview/test/data/device_files'),
I('ChromeSyncShell',
'ChromeSyncShell.apk',
'org.chromium.chrome.browser.sync',
'ChromeSyncShellTest',
None),
]) ])
VALID_TESTS = set(['chromedriver', 'chrome_proxy', 'gpu', 'sync', VALID_TESTS = set(['chromedriver', 'chrome_proxy', 'gpu',
'telemetry_perf_unittests', 'ui', 'unit', 'webkit', 'telemetry_perf_unittests', 'ui', 'unit', 'webkit',
'webkit_layout', 'python_unittests']) 'webkit_layout', 'python_unittests'])
...@@ -184,14 +189,6 @@ def RunChromeProxyTests(options): ...@@ -184,14 +189,6 @@ def RunChromeProxyTests(options):
bb_annotations.PrintNamedStep('chrome_proxy') bb_annotations.PrintNamedStep('chrome_proxy')
RunCmd(['tools/chrome_proxy/run_tests'] + args) RunCmd(['tools/chrome_proxy/run_tests'] + args)
def RunChromeSyncShellTests(options):
"""Run the chrome sync shell tests"""
test = I('ChromeSyncShell',
'ChromeSyncShell.apk',
'org.chromium.chrome.browser.sync',
'ChromeSyncShellTest',
'chrome:chrome/test/data/android/device_files')
RunInstrumentationSuite(options, test)
def RunTelemetryPerfUnitTests(options): def RunTelemetryPerfUnitTests(options):
"""Runs the telemetry perf unit tests. """Runs the telemetry perf unit tests.
...@@ -532,7 +529,6 @@ def GetTestStepCmds(): ...@@ -532,7 +529,6 @@ def GetTestStepCmds():
('chrome_proxy', RunChromeProxyTests), ('chrome_proxy', RunChromeProxyTests),
('gpu', RunGPUTests), ('gpu', RunGPUTests),
('python_unittests', RunPythonUnitTests), ('python_unittests', RunPythonUnitTests),
('sync', RunChromeSyncShellTests),
('telemetry_perf_unittests', RunTelemetryPerfUnitTests), ('telemetry_perf_unittests', RunTelemetryPerfUnitTests),
('ui', RunInstrumentationTests), ('ui', RunInstrumentationTests),
('unit', RunUnitTests), ('unit', RunUnitTests),
......
...@@ -116,7 +116,6 @@ def GetCommands(options, bot_config): ...@@ -116,7 +116,6 @@ def GetCommands(options, bot_config):
def GetBotStepMap(): def GetBotStepMap():
compile_step = ['compile'] compile_step = ['compile']
chrome_proxy_tests = ['chrome_proxy'] chrome_proxy_tests = ['chrome_proxy']
chrome_sync_shell_tests = ['sync']
python_unittests = ['python_unittests'] python_unittests = ['python_unittests']
std_host_tests = ['check_webview_licenses', 'findbugs'] std_host_tests = ['check_webview_licenses', 'findbugs']
emma_coverage_tests = [x for x in std_host_tests if x is not 'findbugs'] emma_coverage_tests = [x for x in std_host_tests if x is not 'findbugs']
...@@ -168,7 +167,7 @@ def GetBotStepMap(): ...@@ -168,7 +167,7 @@ def GetBotStepMap():
H(compile_step + std_host_tests, target_arch='ia32')), H(compile_step + std_host_tests, target_arch='ia32')),
B('fyi-builder-rel', H(std_build_steps, experimental)), B('fyi-builder-rel', H(std_build_steps, experimental)),
B('fyi-tests', H(std_test_steps), B('fyi-tests', H(std_test_steps),
T(std_tests + chrome_sync_shell_tests + python_unittests, T(std_tests + python_unittests,
['--experimental', flakiness_server, ['--experimental', flakiness_server,
'--coverage-bucket', CHROMIUM_COVERAGE_BUCKET, '--coverage-bucket', CHROMIUM_COVERAGE_BUCKET,
'--cleanup'])), '--cleanup'])),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment