Commit 94d060c0 authored by Friedrich Horschig's avatar Friedrich Horschig Committed by Commit Bot

[Mfill Android] Move autofill accessory bridge to keyboard_accessory

Moving the AutofillKeyboardAccessoryBridge to keyboard_accessory/ should
simplify making the keyboard accessory a separate feature.

It also means to add fhorschig@ to the OWNERS of this class.

Bug: 945314
Change-Id: Ib9f623ce32666f4e18e7010407dbc4bb542e367b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538288Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644713}
parent 69c5e63d
...@@ -2231,7 +2231,6 @@ generate_jni("chrome_jni_headers") { ...@@ -2231,7 +2231,6 @@ generate_jni("chrome_jni_headers") {
"java/src/org/chromium/chrome/browser/WebContentsFactory.java", "java/src/org/chromium/chrome/browser/WebContentsFactory.java",
"java/src/org/chromium/chrome/browser/accessibility/FontSizePrefs.java", "java/src/org/chromium/chrome/browser/accessibility/FontSizePrefs.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillExpirationDateFixFlowBridge.java", "java/src/org/chromium/chrome/browser/autofill/AutofillExpirationDateFixFlowBridge.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java", "java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowBridge.java", "java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowBridge.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java", "java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java",
...@@ -2240,6 +2239,7 @@ generate_jni("chrome_jni_headers") { ...@@ -2240,6 +2239,7 @@ generate_jni("chrome_jni_headers") {
"java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java", "java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java",
"java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java", "java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java",
"java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java", "java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java",
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AutofillKeyboardAccessoryBridge.java",
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingBridge.java", "java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingBridge.java",
"java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTask.java", "java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTask.java",
"java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTaskScheduler.java", "java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTaskScheduler.java",
......
...@@ -83,7 +83,6 @@ chrome_java_sources = [ ...@@ -83,7 +83,6 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java", "java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillExpirationDateFixFlowBridge.java", "java/src/org/chromium/chrome/browser/autofill/AutofillExpirationDateFixFlowBridge.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillExpirationDateFixFlowPrompt.java", "java/src/org/chromium/chrome/browser/autofill/AutofillExpirationDateFixFlowPrompt.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java", "java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowBridge.java", "java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowBridge.java",
"java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowPrompt.java", "java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowPrompt.java",
...@@ -106,6 +105,7 @@ chrome_java_sources = [ ...@@ -106,6 +105,7 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewBinder.java", "java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewBinder.java",
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetView.java", "java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetView.java",
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewBinder.java", "java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewBinder.java",
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AutofillKeyboardAccessoryBridge.java",
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/CachedProviderAdapter.java", "java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/CachedProviderAdapter.java",
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/CreditCardAccessorySheetCoordinator.java", "java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/CreditCardAccessorySheetCoordinator.java",
"java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java", "java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java",
......
...@@ -143,7 +143,7 @@ def _CheckAlertDialogBuilder(input_api, output_api): ...@@ -143,7 +143,7 @@ def _CheckAlertDialogBuilder(input_api, output_api):
'chrome/android/java/src/org/chromium/chrome/browser/preferences/website/' 'chrome/android/java/src/org/chromium/chrome/browser/preferences/website/'
'SingleCategoryPreferences.java', 'SingleCategoryPreferences.java',
'chrome/android/java/src/org/chromium/chrome/browser/autofill/' 'chrome/android/java/src/org/chromium/chrome/browser/autofill/'
'AutofillKeyboardAccessoryBridge.java', 'keyboard_accessory/AutofillKeyboardAccessoryBridge.java',
'chrome/android/java/src/org/chromium/chrome/browser/preferences/website/' 'chrome/android/java/src/org/chromium/chrome/browser/preferences/website/'
'AddExceptionPreference.java', 'AddExceptionPreference.java',
'chrome/android/java/src/org/chromium/chrome/browser/preferences/website/' 'chrome/android/java/src/org/chromium/chrome/browser/preferences/website/'
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.autofill; package org.chromium.chrome.browser.autofill.keyboard_accessory;
import android.content.Context; import android.content.Context;
import android.content.DialogInterface; import android.content.DialogInterface;
...@@ -13,19 +13,16 @@ import org.chromium.base.annotations.JNINamespace; ...@@ -13,19 +13,16 @@ import org.chromium.base.annotations.JNINamespace;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ResourceId; import org.chromium.chrome.browser.ResourceId;
import org.chromium.chrome.browser.autofill.keyboard_accessory.AccessoryAction;
import org.chromium.chrome.browser.autofill.keyboard_accessory.ManualFillingCoordinator;
import org.chromium.chrome.browser.autofill.keyboard_accessory.PropertyProvider;
import org.chromium.components.autofill.AutofillDelegate; import org.chromium.components.autofill.AutofillDelegate;
import org.chromium.components.autofill.AutofillSuggestion; import org.chromium.components.autofill.AutofillSuggestion;
import org.chromium.ui.DropdownItem; import org.chromium.ui.DropdownItem;
import org.chromium.ui.base.WindowAndroid; import org.chromium.ui.base.WindowAndroid;
/** /**
* JNI call glue for AutofillExternalDelagate C++ and Java objects. * JNI call glue for AutofillExternalDelagate C++ and Java objects.
* This provides an alternative UI for Autofill suggestions, and replaces AutofillPopupBridge when * This provides an alternative UI for Autofill suggestions, and replaces AutofillPopupBridge when
* --enable-autofill-keyboard-accessory-view is passed on the command line. * --enable-autofill-keyboard-accessory-view is passed on the command line.
*/ */
@JNINamespace("autofill") @JNINamespace("autofill")
public class AutofillKeyboardAccessoryBridge public class AutofillKeyboardAccessoryBridge
implements AutofillDelegate, DialogInterface.OnClickListener { implements AutofillDelegate, DialogInterface.OnClickListener {
...@@ -35,8 +32,7 @@ public class AutofillKeyboardAccessoryBridge ...@@ -35,8 +32,7 @@ public class AutofillKeyboardAccessoryBridge
private PropertyProvider<AutofillSuggestion[]> mChipProvider = private PropertyProvider<AutofillSuggestion[]> mChipProvider =
new PropertyProvider<>(AccessoryAction.AUTOFILL_SUGGESTION); new PropertyProvider<>(AccessoryAction.AUTOFILL_SUGGESTION);
private AutofillKeyboardAccessoryBridge() { private AutofillKeyboardAccessoryBridge() {}
}
@CalledByNative @CalledByNative
private static AutofillKeyboardAccessoryBridge create() { private static AutofillKeyboardAccessoryBridge create() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment