Commit 94e8b628 authored by cbiesinger's avatar cbiesinger Committed by Commit bot

[layoutng] Remove TODO comment about DeviceWidth/DeviceHeight

I have verified that vh/vw are resolved by the style system before these
units reach layout, so we don't need to worry about DeviceWidth/DeviceHeight
here.

R=mstensho@opera.com,eae@chromium.org,ikilpatrick@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2344193003
Cr-Commit-Position: refs/heads/master@{#419366}
parent e30a8fab
...@@ -99,12 +99,8 @@ LayoutUnit resolveInlineLength(const NGConstraintSpace& constraintSpace, ...@@ -99,12 +99,8 @@ LayoutUnit resolveInlineLength(const NGConstraintSpace& constraintSpace,
return LayoutUnit(); return LayoutUnit();
case DeviceWidth: case DeviceWidth:
case DeviceHeight: case DeviceHeight:
// TODO(layout-ng): Do we need to handle this here or does the style
// system already compute these?
return LayoutUnit();
case ExtendToZoom: case ExtendToZoom:
NOTREACHED() NOTREACHED() << "These should only be used for viewport definitions";
<< "ExtendToZoom should only be used for viewport definitions";
case MaxSizeNone: case MaxSizeNone:
default: default:
NOTREACHED(); NOTREACHED();
...@@ -158,12 +154,8 @@ LayoutUnit resolveBlockLength(const NGConstraintSpace& constraintSpace, ...@@ -158,12 +154,8 @@ LayoutUnit resolveBlockLength(const NGConstraintSpace& constraintSpace,
return contentSize; return contentSize;
case DeviceWidth: case DeviceWidth:
case DeviceHeight: case DeviceHeight:
// TODO(layout-ng): Do we need to handle this here or does the style
// system already compute these?
return LayoutUnit();
case ExtendToZoom: case ExtendToZoom:
NOTREACHED() NOTREACHED() << "These should only be used for viewport definitions";
<< "ExtendToZoom should only be used for viewport definitions";
case MaxSizeNone: case MaxSizeNone:
default: default:
NOTREACHED(); NOTREACHED();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment