Commit 95008f85 authored by Eric Stevenson's avatar Eric Stevenson Committed by Commit Bot

Android: Fix failing to list tests on > K.

In https://chromium-review.googlesource.com/c/chromium/src/+/1332607, I
added support for listing tests when multidex is enabled on KitKat
and introduced a bug where we always use our custom TestRequestBuilder.

Bug: 905230
Change-Id: Id0eb9f9b094fc9243a2baf68fe3647bcebf2075d
Reviewed-on: https://chromium-review.googlesource.com/c/1338326Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608578}
parent b496436e
...@@ -200,7 +200,7 @@ public class BaseChromiumAndroidJUnitRunner extends AndroidJUnitRunner { ...@@ -200,7 +200,7 @@ public class BaseChromiumAndroidJUnitRunner extends AndroidJUnitRunner {
RunnerArgs runnerArgs = RunnerArgs runnerArgs =
new RunnerArgs.Builder().fromManifest(this).fromBundle(arguments).build(); new RunnerArgs.Builder().fromManifest(this).fromBundle(arguments).build();
TestRequestBuilder builder; TestRequestBuilder builder;
if (dexFiles != null) { if (!dexFiles.isEmpty()) {
builder = new DexFileTestRequestBuilder(this, arguments, dexFiles); builder = new DexFileTestRequestBuilder(this, arguments, dexFiles);
} else { } else {
builder = new TestRequestBuilder(this, arguments); builder = new TestRequestBuilder(this, arguments);
...@@ -274,7 +274,7 @@ public class BaseChromiumAndroidJUnitRunner extends AndroidJUnitRunner { ...@@ -274,7 +274,7 @@ public class BaseChromiumAndroidJUnitRunner extends AndroidJUnitRunner {
// builder.addApkToScan uses new DexFile(path) under the hood, which on Dalvik OS's // builder.addApkToScan uses new DexFile(path) under the hood, which on Dalvik OS's
// assumes that the optimized dex is in the default location (crashes). // assumes that the optimized dex is in the default location (crashes).
// Perform our own dex file scanning instead as a workaround. // Perform our own dex file scanning instead as a workaround.
scanIncrementalJarsForTestClasses(); scanDexFilesForTestClasses();
} }
return super.build(); return super.build();
} }
...@@ -288,8 +288,8 @@ public class BaseChromiumAndroidJUnitRunner extends AndroidJUnitRunner { ...@@ -288,8 +288,8 @@ public class BaseChromiumAndroidJUnitRunner extends AndroidJUnitRunner {
return false; return false;
} }
private void scanIncrementalJarsForTestClasses() { private void scanDexFilesForTestClasses() {
Log.i(TAG, "Scanning incremental classpath."); Log.i(TAG, "Scanning loaded dex files for test classes.");
// Mirror TestRequestBuilder.getClassNamesFromClassPath(). // Mirror TestRequestBuilder.getClassNamesFromClassPath().
TestLoader loader = new TestLoader(); TestLoader loader = new TestLoader();
for (DexFile dexFile : mDexFiles) { for (DexFile dexFile : mDexFiles) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment