Skip to content

GitLab

T
tangled
Commit 950265f8 authored by Harry Cutts's avatar Harry Cutts Committed by Commit Bot
Browse files
Options

chromeos: Use UMA functions when applying preferences 

Bug: none
Test: change a preference and check chrome://histograms shows the sample
Change-Id: I7746b17bbe84864be03954c664b3263204a040b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491985
Auto-Submit: Harry Cutts <hcutts@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819902}
parent cf960773
Hide whitespace changes
Inline Side-by-side
Showing with 32 additions and 29 deletions
chrome/browser/chromeos/preferences.cc
View file @ 950265f8
......@@ -657,9 +657,9 @@ void Preferences::ApplyPreferences(ApplyReason reason,
if (user_is_active)
touchpad_settings.SetTapToClick(enabled);
if (reason == REASON_PREF_CHANGED)
UMA_HISTOGRAM_BOOLEAN("Touchpad.TapToClick.Changed", enabled);
base::UmaHistogramBoolean("Touchpad.TapToClick.Changed", enabled);
else if (reason == REASON_INITIALIZATION)
UMA_HISTOGRAM_BOOLEAN("Touchpad.TapToClick.Started", enabled);
base::UmaHistogramBoolean("Touchpad.TapToClick.Started", enabled);
// Save owner preference in local state to use on login screen.
if (user_is_owner) {
......@@ -674,9 +674,9 @@ void Preferences::ApplyPreferences(ApplyReason reason,
if (user_is_active)
touchpad_settings.SetThreeFingerClick(enabled);
if (reason == REASON_PREF_CHANGED)
UMA_HISTOGRAM_BOOLEAN("Touchpad.ThreeFingerClick.Changed", enabled);
base::UmaHistogramBoolean("Touchpad.ThreeFingerClick.Changed", enabled);
else if (reason == REASON_INITIALIZATION)
UMA_HISTOGRAM_BOOLEAN("Touchpad.ThreeFingerClick.Started", enabled);
base::UmaHistogramBoolean("Touchpad.ThreeFingerClick.Started", enabled);
}
if (reason != REASON_PREF_CHANGED ||
pref_name == ::prefs::kUnifiedDesktopEnabledByDefault) {
......@@ -699,9 +699,9 @@ void Preferences::ApplyPreferences(ApplyReason reason,
if (user_is_active)
touchpad_settings.SetNaturalScroll(enabled);
if (reason == REASON_PREF_CHANGED)
UMA_HISTOGRAM_BOOLEAN("Touchpad.NaturalScroll.Changed", enabled);
base::UmaHistogramBoolean("Touchpad.NaturalScroll.Changed", enabled);
else if (reason == REASON_INITIALIZATION)
UMA_HISTOGRAM_BOOLEAN("Touchpad.NaturalScroll.Started", enabled);
base::UmaHistogramBoolean("Touchpad.NaturalScroll.Started", enabled);
}
if (reason != REASON_PREF_CHANGED ||
pref_name == ash::prefs::kMouseReverseScroll) {
......@@ -709,9 +709,9 @@ void Preferences::ApplyPreferences(ApplyReason reason,
if (user_is_active)
mouse_settings.SetReverseScroll(enabled);
if (reason == REASON_PREF_CHANGED)
UMA_HISTOGRAM_BOOLEAN("Mouse.ReverseScroll.Changed", enabled);
base::UmaHistogramBoolean("Mouse.ReverseScroll.Changed", enabled);
else if (reason == REASON_INITIALIZATION)
UMA_HISTOGRAM_BOOLEAN("Mouse.ReverseScroll.Started", enabled);
base::UmaHistogramBoolean("Mouse.ReverseScroll.Started", enabled);
}
if (reason != REASON_PREF_CHANGED ||
......@@ -728,11 +728,11 @@ void Preferences::ApplyPreferences(ApplyReason reason,
system::PointerSensitivity sensitivity =
static_cast<system::PointerSensitivity>(sensitivity_int);
if (reason == REASON_PREF_CHANGED) {
UMA_HISTOGRAM_ENUMERATION("Mouse.PointerSensitivity.Changed",
sensitivity);
base::UmaHistogramEnumeration("Mouse.PointerSensitivity.Changed",
sensitivity);
} else if (reason == REASON_INITIALIZATION) {
UMA_HISTOGRAM_ENUMERATION("Mouse.PointerSensitivity.Started",
sensitivity);
base::UmaHistogramEnumeration("Mouse.PointerSensitivity.Started",
sensitivity);
}
}
if (reason != REASON_PREF_CHANGED ||
......@@ -746,10 +746,13 @@ void Preferences::ApplyPreferences(ApplyReason reason,
mouse_settings.SetScrollSensitivity(sensitivity_int);
system::PointerSensitivity sensitivity =
static_cast<system::PointerSensitivity>(sensitivity_int);
if (reason == REASON_PREF_CHANGED)
UMA_HISTOGRAM_ENUMERATION("Mouse.ScrollSensitivity.Changed", sensitivity);
else if (reason == REASON_INITIALIZATION)
UMA_HISTOGRAM_ENUMERATION("Mouse.ScrollSensitivity.Started", sensitivity);
if (reason == REASON_PREF_CHANGED) {
base::UmaHistogramEnumeration("Mouse.ScrollSensitivity.Changed",
sensitivity);
} else if (reason == REASON_INITIALIZATION) {
base::UmaHistogramEnumeration("Mouse.ScrollSensitivity.Started",
sensitivity);
}
}
if (reason != REASON_PREF_CHANGED ||
pref_name == ::prefs::kTouchpadSensitivity) {
......@@ -765,11 +768,11 @@ void Preferences::ApplyPreferences(ApplyReason reason,
system::PointerSensitivity sensitivity =
static_cast<system::PointerSensitivity>(sensitivity_int);
if (reason == REASON_PREF_CHANGED) {
UMA_HISTOGRAM_ENUMERATION("Touchpad.PointerSensitivity.Changed",
sensitivity);
base::UmaHistogramEnumeration("Touchpad.PointerSensitivity.Changed",
sensitivity);
} else if (reason == REASON_INITIALIZATION) {
UMA_HISTOGRAM_ENUMERATION("Touchpad.PointerSensitivity.Started",
sensitivity);
base::UmaHistogramEnumeration("Touchpad.PointerSensitivity.Started",
sensitivity);
}
}
if (reason != REASON_PREF_CHANGED ||
......@@ -784,11 +787,11 @@ void Preferences::ApplyPreferences(ApplyReason reason,
system::PointerSensitivity sensitivity =
static_cast<system::PointerSensitivity>(sensitivity_int);
if (reason == REASON_PREF_CHANGED) {
UMA_HISTOGRAM_ENUMERATION("Touchpad.ScrollSensitivity.Changed",
sensitivity);
base::UmaHistogramEnumeration("Touchpad.ScrollSensitivity.Changed",
sensitivity);
} else if (reason == REASON_INITIALIZATION) {
UMA_HISTOGRAM_ENUMERATION("Touchpad.ScrollSensitivity.Started",
sensitivity);
base::UmaHistogramEnumeration("Touchpad.ScrollSensitivity.Started",
sensitivity);
}
}
if (reason != REASON_PREF_CHANGED ||
......@@ -797,9 +800,9 @@ void Preferences::ApplyPreferences(ApplyReason reason,
if (user_is_active)
mouse_settings.SetPrimaryButtonRight(right);
if (reason == REASON_PREF_CHANGED)
UMA_HISTOGRAM_BOOLEAN("Mouse.PrimaryButtonRight.Changed", right);
base::UmaHistogramBoolean("Mouse.PrimaryButtonRight.Changed", right);
else if (reason == REASON_INITIALIZATION)
UMA_HISTOGRAM_BOOLEAN("Mouse.PrimaryButtonRight.Started", right);
base::UmaHistogramBoolean("Mouse.PrimaryButtonRight.Started", right);
// Save owner preference in local state to use on login screen.
if (user_is_owner) {
PrefService* prefs = g_browser_process->local_state();
......@@ -852,11 +855,11 @@ void Preferences::ApplyPreferences(ApplyReason reason,
const bool default_download_to_drive = drive::util::IsUnderDriveMountPoint(
download_default_directory_.GetValue());
if (reason == REASON_PREF_CHANGED)
UMA_HISTOGRAM_BOOLEAN(
base::UmaHistogramBoolean(
"FileBrowser.DownloadDestination.IsGoogleDrive.Changed",
default_download_to_drive);
else if (reason == REASON_INITIALIZATION)
UMA_HISTOGRAM_BOOLEAN(
base::UmaHistogramBoolean(
"FileBrowser.DownloadDestination.IsGoogleDrive.Started",
default_download_to_drive);
}
......@@ -1037,7 +1040,7 @@ void Preferences::ForceNaturalScrollDefault() {
is_syncing && !prefs_->GetUserPrefValue(ash::prefs::kNaturalScroll)) {
DVLOG(1) << "Natural scroll forced to true";
natural_scroll_.SetValue(true);
UMA_HISTOGRAM_BOOLEAN("Touchpad.NaturalScroll.Forced", true);
base::UmaHistogramBoolean("Touchpad.NaturalScroll.Forced", true);
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment