Commit 950c4e2b authored by Javier Ernesto Flores Robles's avatar Javier Ernesto Flores Robles Committed by Commit Bot

[iOS][Credential-Provider] ObjC++

Change files from cpp to objc++.
CredentialProviderService will use Objective-C classes, and needs to be
converted to Objective-C++ instead of C++.

Bug: 1066803
Change-Id: Ibd74a815177cb05b84bf05ee423ad3342c02a53d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139652
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757036}
parent e0431952
...@@ -11,10 +11,10 @@ source_set("credential_provider") { ...@@ -11,10 +11,10 @@ source_set("credential_provider") {
sources = [ sources = [
"archivable_credential+password_form.h", "archivable_credential+password_form.h",
"archivable_credential+password_form.mm", "archivable_credential+password_form.mm",
"credential_provider_service.cc",
"credential_provider_service.h", "credential_provider_service.h",
"credential_provider_service_factory.cc", "credential_provider_service.mm",
"credential_provider_service_factory.h", "credential_provider_service_factory.h",
"credential_provider_service_factory.mm",
"credential_provider_support.cc", "credential_provider_support.cc",
"credential_provider_support.h", "credential_provider_support.h",
] ]
...@@ -46,7 +46,7 @@ source_set("unit_tests") { ...@@ -46,7 +46,7 @@ source_set("unit_tests") {
testonly = true testonly = true
sources = [ sources = [
"archivable_credential+password_form_unittest.mm", "archivable_credential+password_form_unittest.mm",
"credential_provider_service_unittest.cc", "credential_provider_service_unittest.mm",
] ]
deps = [ deps = [
":credential_provider", ":credential_provider",
......
...@@ -9,6 +9,10 @@ ...@@ -9,6 +9,10 @@
#include "base/threading/sequenced_task_runner_handle.h" #include "base/threading/sequenced_task_runner_handle.h"
#include "build/build_config.h" #include "build/build_config.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support."
#endif
CredentialProviderService::CredentialProviderService( CredentialProviderService::CredentialProviderService(
scoped_refptr<password_manager::PasswordStore> password_store) scoped_refptr<password_manager::PasswordStore> password_store)
: password_store_(password_store) {} : password_store_(password_store) {}
......
...@@ -10,6 +10,10 @@ ...@@ -10,6 +10,10 @@
#include "ios/chrome/browser/credential_provider/credential_provider_service.h" #include "ios/chrome/browser/credential_provider/credential_provider_service.h"
#include "ios/chrome/browser/passwords/ios_chrome_password_store_factory.h" #include "ios/chrome/browser/passwords/ios_chrome_password_store_factory.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support."
#endif
// static // static
CredentialProviderService* CredentialProviderServiceFactory::GetForBrowserState( CredentialProviderService* CredentialProviderServiceFactory::GetForBrowserState(
ChromeBrowserState* browser_state) { ChromeBrowserState* browser_state) {
......
...@@ -5,13 +5,17 @@ ...@@ -5,13 +5,17 @@
#include "ios/chrome/browser/credential_provider/credential_provider_service.h" #include "ios/chrome/browser/credential_provider/credential_provider_service.h"
#include "components/password_manager/core/browser/test_password_store.h" #include "components/password_manager/core/browser/test_password_store.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/platform_test.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support."
#endif
namespace { namespace {
using password_manager::TestPasswordStore; using password_manager::TestPasswordStore;
class CredentialProviderServiceTest : public testing::Test { class CredentialProviderServiceTest : public PlatformTest {
public: public:
CredentialProviderServiceTest() {} CredentialProviderServiceTest() {}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment