Commit 95175149 authored by Vladislav Kuzkokov's avatar Vladislav Kuzkokov Committed by Commit Bot

Fix crash in ServiceResolverImplMac.

This was a latent bug until Callback was changed to OnceCallback
because callback could be called more than once.

Bug: 778149
Change-Id: I8268de7e61c31406aa20f9005f37c08055bab03d
Reviewed-on: https://chromium-review.googlesource.com/744023Reviewed-by: default avatarGene Gutnik <gene@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512621}
parent 276d7cc1
......@@ -357,6 +357,9 @@ ServiceResolverImplMac::NetServiceContainer::StartResolvingOnDiscoveryThread() {
void ServiceResolverImplMac::NetServiceContainer::OnResolveUpdate(
RequestStatus status) {
if (callback_.is_null())
return;
if (status != STATUS_SUCCESS) {
callback_runner_->PostTask(
FROM_HERE,
......@@ -435,7 +438,8 @@ void ServiceResolverImplMac::OnResolveComplete(
has_resolved_ = true;
std::move(callback_).Run(status, description);
if (!callback_.is_null())
std::move(callback_).Run(status, description);
}
ServiceResolverImplMac::NetServiceContainer*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment