Commit 9520019b authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Extensions Cleanup] Remove unused ModuleSystem::RunString variant

One of the variants of ModuleSystem::RunString() was unused. Remove it.

Bug: None

Change-Id: I551b5b2baec597d20d8923578b52ea6f02a169ce
Reviewed-on: https://chromium-review.googlesource.com/822730Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523536}
parent 5dbaa985
......@@ -355,18 +355,6 @@ void ModuleSystem::OverrideNativeHandlerForTest(const std::string& name) {
overridden_native_handlers_.insert(name);
}
void ModuleSystem::RunString(const std::string& code, const std::string& name) {
v8::HandleScope handle_scope(GetIsolate());
v8::Local<v8::String> v8_code;
v8::Local<v8::String> v8_name;
if (!ToV8String(GetIsolate(), code.c_str(), &v8_code) ||
!ToV8String(GetIsolate(), name.c_str(), &v8_name)) {
Warn(GetIsolate(), "Too long code or name.");
return;
}
RunString(v8_code, v8_name);
}
// static
void ModuleSystem::NativeLazyFieldGetter(
v8::Local<v8::Name> property,
......
......@@ -113,9 +113,6 @@ class ModuleSystem : public ObjectBackedNativeHandler {
// tests to mock out native modules.
void OverrideNativeHandlerForTest(const std::string& name);
// Executes |code| in the current context with |name| as the filename.
void RunString(const std::string& code, const std::string& name);
// Make |object|.|field| lazily evaluate to the result of
// require(|module_name|)[|module_field|].
//
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment