Commit 9564b9e2 authored by benm@chromium.org's avatar benm@chromium.org

[Android WebView] Fix some findbugs warnings.

M D DLS: Dead store to imageUrl in
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest.testCalledForImage()
At AwContentsClientShouldInterceptRequestTest.java
M D DLS: Dead store to onPageFinishedCallCount in
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest.testOnLoadResourceCalledWithCorrectUrl()
At AwContentsClientShouldInterceptRequestTest.java
M D SF: Switch statement found in
org.chromium.android_webview.AwContents$IoThreadClientHandler.handleMessage(Message)
where default case is missing  At AwContents.java
M P SIC: Should
org.chromium.android_webview.test.AwContentsClientShouldIgnoreNavigationTest$TestAwContentsClient$ShouldIgnoreNavigationHelper
be a _static_ inner class?  At
AwContentsClientShouldIgnoreNavigationTest.java

Java only change and android bots are happy.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11196016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162360 0039d316-1c4b-4281-b951-d872f2087c98
parent 4e947706
......@@ -81,6 +81,9 @@ public class AwContents {
final String url = (String)msg.obj;
AwContents.this.mContentsClient.onLoadResource(url);
break;
default:
throw new IllegalStateException(
"IoThreadClientHandler: unhandled message " + msg.what);
}
}
}
......
......@@ -45,7 +45,7 @@ public class AwContentsClientShouldIgnoreNavigationTest extends AndroidWebViewTe
private static class TestAwContentsClient
extends org.chromium.android_webview.test.TestAwContentsClient {
public class ShouldIgnoreNavigationHelper extends CallbackHelper {
public static class ShouldIgnoreNavigationHelper extends CallbackHelper {
private String mShouldIgnoreNavigationUrl;
private String mPreviousShouldIgnoreNavigationUrl;
private boolean mShouldIgnoreNavigationReturnValue = false;
......
......@@ -168,7 +168,6 @@ public class AwContentsClientShouldInterceptRequestTest extends AndroidWebViewTe
final String aboutPageUrl = addAboutPageToTestServer(mWebServer);
int callCount = onLoadResourceHelper.getCallCount();
int onPageFinishedCallCount = contentsClient.getOnPageFinishedHelper().getCallCount();
loadUrlAsync(awContents, aboutPageUrl);
......@@ -269,7 +268,7 @@ public class AwContentsClientShouldInterceptRequestTest extends AndroidWebViewTe
contentsClient.getShouldInterceptRequestHelper();
final String imagePath = "/" + CommonResources.FAVICON_FILENAME;
final String imageUrl = mWebServer.setResponseBase64(imagePath,
mWebServer.setResponseBase64(imagePath,
CommonResources.FAVICON_DATA_BASE64, CommonResources.getImagePngHeaders(true));
final String pageWithImage =
addPageToTestServer(mWebServer, "/page_with_image.html",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment