Revert of Redirect all mouse input to Alt+Tab window when it's visible,...

Revert of Redirect all mouse input to Alt+Tab window when it's visible, (patchset #3 id:40001 of https://codereview.chromium.org/2284763002/ )

Reason for revert:
WindowCycleControllerTest.MouseCaptureLost fails on Chrome os and Asan.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(dbg)(1)

Original issue's description:
> Redirect all mouse input to Alt+Tab window when it's visible,
> effectively disabling the mouse. Capture is reset when the widget is
> destroyed.
>
> BUG=641171
>
> Committed: https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa
> Cr-Commit-Position: refs/heads/master@{#415096}

TBR=sky@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641171

Review-Url: https://codereview.chromium.org/2294723002
Cr-Commit-Position: refs/heads/master@{#415267}

ash/common/wm/window_cycle_list.cc

@@ -390,10 +390,6 @@ class WindowCycleView : public views::WidgetDelegateView {
     }
   }
 
-  void OnMouseCaptureLost() override {
-    WmShell::Get()->window_cycle_controller()->StopCycling();
-  }
-
   View* GetContentsView() override { return this; }
 
   View* GetInitiallyFocusedView() override {
@@ -620,8 +616,6 @@ void WindowCycleList::InitWindowCycleView() {
   widget_rect.set_height(widget_height);
   widget->SetBounds(widget_rect);
   widget->Show();
-  widget->SetCapture(cycle_view_);
-  widget->set_auto_release_capture(false);
   cycle_ui_widget_.reset(widget);
 }
 

ash/wm/window_cycle_controller_unittest.cc

@@ -40,32 +40,24 @@ namespace ash {
 
 namespace {
 
-class EventCounter : public ui::EventHandler {
+class KeyEventCounter : public ui::EventHandler {
  public:
-  EventCounter() : key_events_(0), mouse_events_(0) {}
-  ~EventCounter() override {}
+  KeyEventCounter() : key_events_(0) {}
+  ~KeyEventCounter() override {}
 
-  int GetKeyEventCountAndReset() {
-    int count = key_events_;
+  size_t GetCountAndReset() {
+    size_t count = key_events_;
     key_events_ = 0;
     return count;
   }
 
-  int GetMouseEventCountAndReset() {
-    int count = mouse_events_;
-    mouse_events_ = 0;
-    return count;
-  }
-
   // ui::EventHandler:
   void OnKeyEvent(ui::KeyEvent* event) override { key_events_++; }
-  void OnMouseEvent(ui::MouseEvent* event) override { mouse_events_++; }
 
  private:
-  int key_events_;
-  int mouse_events_;
+  size_t key_events_;
 
-  DISALLOW_COPY_AND_ASSIGN(EventCounter);
+  DISALLOW_COPY_AND_ASSIGN(KeyEventCounter);
 };
 
 bool IsWindowMinimized(aura::Window* window) {
@@ -566,71 +558,20 @@ TEST_F(WindowCycleControllerTest, CycleMruPanelDestroyed) {
 TEST_F(WindowCycleControllerTest, TabKeyNotLeaked) {
   std::unique_ptr<Window> w0(CreateTestWindowInShellWithId(0));
   std::unique_ptr<Window> w1(CreateTestWindowInShellWithId(1));
-  EventCounter event_count;
-  w0->AddPreTargetHandler(&event_count);
-  w1->AddPreTargetHandler(&event_count);
+  KeyEventCounter key_count;
+  w0->AddPreTargetHandler(&key_count);
+  w1->AddPreTargetHandler(&key_count);
   ui::test::EventGenerator& generator = GetEventGenerator();
   wm::GetWindowState(w0.get())->Activate();
   generator.PressKey(ui::VKEY_MENU, ui::EF_NONE);
-  EXPECT_EQ(1, event_count.GetKeyEventCountAndReset());
+  EXPECT_EQ(1u, key_count.GetCountAndReset());
   generator.PressKey(ui::VKEY_TAB, ui::EF_ALT_DOWN);
-  EXPECT_EQ(0, event_count.GetKeyEventCountAndReset());
+  EXPECT_EQ(0u, key_count.GetCountAndReset());
   generator.ReleaseKey(ui::VKEY_TAB, ui::EF_ALT_DOWN);
-  EXPECT_EQ(0, event_count.GetKeyEventCountAndReset());
+  EXPECT_EQ(0u, key_count.GetCountAndReset());
   generator.ReleaseKey(ui::VKEY_MENU, ui::EF_NONE);
   EXPECT_TRUE(wm::GetWindowState(w1.get())->IsActive());
-  EXPECT_EQ(0, event_count.GetKeyEventCountAndReset());
-}
-
-// While the UI is active, mouse events are captured.
-TEST_F(WindowCycleControllerTest, MouseEventsCaptured) {
-  // This delegate allows the window to receive mouse events.
-  aura::test::TestWindowDelegate delegate;
-  std::unique_ptr<Window> w0(CreateTestWindowInShellWithDelegate(
-      &delegate, 0, gfx::Rect(0, 0, 100, 100)));
-  std::unique_ptr<Window> w1(CreateTestWindowInShellWithId(1));
-  EventCounter event_count;
-  w0->AddPreTargetHandler(&event_count);
-  w1->SetTargetHandler(&event_count);
-  ui::test::EventGenerator& generator = GetEventGenerator();
-  wm::ActivateWindow(w0.get());
-
-  // Events get through.
-  generator.MoveMouseToCenterOf(w0.get());
-  generator.ClickLeftButton();
-  EXPECT_LT(0, event_count.GetMouseEventCountAndReset());
-
-  // Start cycling.
-  WindowCycleController* controller = WmShell::Get()->window_cycle_controller();
-  controller->HandleCycleWindow(WindowCycleController::FORWARD);
-
-  // Events don't get through.
-  generator.ClickLeftButton();
-  EXPECT_EQ(0, event_count.GetMouseEventCountAndReset());
-
-  // Stop cycling: once again, events get through.
-  controller->StopCycling();
-  generator.ClickLeftButton();
-  EXPECT_LT(0, event_count.GetMouseEventCountAndReset());
-}
-
-// If mouse capture is lost, the UI closes.
-TEST_F(WindowCycleControllerTest, MouseCaptureLost) {
-  // This delegate allows the window to receive mouse events.
-  aura::test::TestWindowDelegate delegate;
-  std::unique_ptr<Window> w0(CreateTestWindowInShellWithDelegate(
-      &delegate, 0, gfx::Rect(0, 0, 100, 100)));
-  std::unique_ptr<Window> w1(CreateTestWindowInShellWithId(1));
-
-  // Start cycling.
-  WindowCycleController* controller = WmShell::Get()->window_cycle_controller();
-  controller->HandleCycleWindow(WindowCycleController::FORWARD);
-
-  // Some other widget grabs capture and this causes Alt+Tab to cease.
-  std::unique_ptr<views::Widget> widget = CreateTestWidget(
-      nullptr, kShellWindowId_DefaultContainer, gfx::Rect(1, 2, 3, 4));
-  widget.get()->SetCapture(nullptr);
-  EXPECT_FALSE(controller->IsCycling());
+  EXPECT_EQ(0u, key_count.GetCountAndReset());
 }
 
 // Tests that we can cycle past fullscreen windows: https://crbug.com/622396.
@@ -663,11 +604,11 @@ TEST_F(WindowCycleControllerTest, TabPastFullscreenWindow) {
   // pass on the alt+tab to continue cycling). To make this test work with or
   // without the new alt+tab selector we check for the event on either
   // fullscreen window.
-  EventCounter event_count;
-  w0->AddPreTargetHandler(&event_count);
-  w1->AddPreTargetHandler(&event_count);
+  KeyEventCounter key_count;
+  w0->AddPreTargetHandler(&key_count);
+  w1->AddPreTargetHandler(&key_count);
   generator.PressKey(ui::VKEY_TAB, ui::EF_ALT_DOWN);
-  EXPECT_EQ(1, event_count.GetKeyEventCountAndReset());
+  EXPECT_EQ(1u, key_count.GetCountAndReset());
 }
 
 }  // namespace ash