Commit 957d2de6 authored by Alice Wang's avatar Alice Wang Committed by Chromium LUCI CQ

[Android][Test] Clean up SigninPromoUtilTest

This CL cleans up SigninPromoUtilTest by removing the unused method and
annotation.

Bug: 1166173
Change-Id: Idb9bceb7dac0c371af3c2e9b2b15eefddbf2722a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640034Reviewed-by: default avatarTanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845627}
parent 51cfb434
...@@ -9,8 +9,6 @@ import static org.mockito.Mockito.verify; ...@@ -9,8 +9,6 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import androidx.collection.ArraySet;
import com.google.common.collect.ImmutableSet; import com.google.common.collect.ImmutableSet;
import org.junit.After; import org.junit.After;
...@@ -19,19 +17,14 @@ import org.junit.Before; ...@@ -19,19 +17,14 @@ import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mockito; import org.mockito.Mockito;
import org.robolectric.annotation.Config;
import org.chromium.base.supplier.Supplier;
import org.chromium.base.test.BaseRobolectricTestRunner; import org.chromium.base.test.BaseRobolectricTestRunner;
import org.chromium.chrome.browser.signin.services.SigninPreferencesManager; import org.chromium.chrome.browser.signin.services.SigninPreferencesManager;
import java.util.Arrays;
import java.util.Collections; import java.util.Collections;
import java.util.Set;
/** Tests for {@link SigninPromoUtil}. */ /** Tests for {@link SigninPromoUtil}. */
@RunWith(BaseRobolectricTestRunner.class) @RunWith(BaseRobolectricTestRunner.class)
@Config(manifest = Config.NONE)
public class SigninPromoUtilTest { public class SigninPromoUtilTest {
private SigninPreferencesManager mPreferencesManager; private SigninPreferencesManager mPreferencesManager;
...@@ -47,14 +40,6 @@ public class SigninPromoUtilTest { ...@@ -47,14 +40,6 @@ public class SigninPromoUtilTest {
verifyNoMoreInteractions(ignoreStubs(mPreferencesManager)); verifyNoMoreInteractions(ignoreStubs(mPreferencesManager));
} }
/**
* Creates a {@link Supplier} that returns a list of accounts provided to this method.
* @param accountNames The account names to return from {@link Supplier}
*/
private Supplier<Set<String>> accountsSupplier(String... accountNames) {
return () -> new ArraySet<>(Arrays.asList(accountNames));
}
@Test @Test
public void whenNoLastShownVersionShouldReturnFalseAndSaveVersion() { public void whenNoLastShownVersionShouldReturnFalseAndSaveVersion() {
when(mPreferencesManager.getSigninPromoLastShownVersion()).thenReturn(0); when(mPreferencesManager.getSigninPromoLastShownVersion()).thenReturn(0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment