heap: HeapVector: Use standard GC types
In addition, avoid using base::Optional<> within fields of GarbageCollected objects. This does not work well in general, as emplacing a new value constructs an object in place which does not trigger a write barrier. Eventually, this will lead to heap corruptions. The check is implemented in the GC plugin but compilation now also fails because of missing trace traits. base::Optional<> used from stack or parameters is supported and stay unaffected of this change. Bug: 1056170 Change-Id: I197c0bf0975823a77c873a7dbfd2fdd9f2668ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621892 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842180}
Showing
Please register or sign in to comment