Commit 95832a3e authored by Evan Stade's avatar Evan Stade Committed by Commit Bot

Fix and enable OmniboxPopupContentsViewTest.ClickOmnibox

Bug: 814675
Change-Id: I522890e1252535832aed187e7add7034f46fb30c
Reviewed-on: https://chromium-review.googlesource.com/c/1311800
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604726}
parent 175660a3
...@@ -25,6 +25,7 @@ ...@@ -25,6 +25,7 @@
#include "components/omnibox/browser/omnibox_field_trial.h" #include "components/omnibox/browser/omnibox_field_trial.h"
#include "components/omnibox/browser/omnibox_popup_model.h" #include "components/omnibox/browser/omnibox_popup_model.h"
#include "content/public/test/test_utils.h" #include "content/public/test/test_utils.h"
#include "ui/base/ui_base_features.h"
#include "ui/compositor/layer_animator.h" #include "ui/compositor/layer_animator.h"
#include "ui/events/test/event_generator.h" #include "ui/events/test/event_generator.h"
#include "ui/views/widget/widget.h" #include "ui/views/widget/widget.h"
...@@ -251,7 +252,13 @@ IN_PROC_BROWSER_TEST_F(OmniboxPopupContentsViewTest, MAYBE_ThemeIntegration) { ...@@ -251,7 +252,13 @@ IN_PROC_BROWSER_TEST_F(OmniboxPopupContentsViewTest, MAYBE_ThemeIntegration) {
// Test that clicks over the omnibox do not hit the popup. // Test that clicks over the omnibox do not hit the popup.
IN_PROC_BROWSER_TEST_F(OmniboxPopupContentsViewTest, MAYBE_ClickOmnibox) { IN_PROC_BROWSER_TEST_F(OmniboxPopupContentsViewTest, MAYBE_ClickOmnibox) {
CreatePopupForTestQuery(); CreatePopupForTestQuery();
ui::test::EventGenerator generator(browser()->window()->GetNativeWindow());
gfx::NativeWindow event_window = browser()->window()->GetNativeWindow();
#if defined(OS_CHROMEOS)
if (features::IsUsingWindowService())
event_window = nullptr;
#endif
ui::test::EventGenerator generator(event_window);
OmniboxResultView* result = GetResultViewAt(0); OmniboxResultView* result = GetResultViewAt(0);
ASSERT_TRUE(result); ASSERT_TRUE(result);
......
...@@ -227,9 +227,6 @@ ...@@ -227,9 +227,6 @@
-PowerPolicyLoginScreenBrowserTest.SetDevicePolicy -PowerPolicyLoginScreenBrowserTest.SetDevicePolicy
-EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_Success -EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_Success
# Needs EventGenerator to work across window tree hosts. crbug.com/814675
-OmniboxPopupContentsViewTest.ClickOmnibox
# HostedAppMenu needs porting to BrowserNonClientFrameViewMash crbug.com/813666 # HostedAppMenu needs porting to BrowserNonClientFrameViewMash crbug.com/813666
-HostedAppPWAOnlyTest.AppInfoOpensPageInfo* -HostedAppPWAOnlyTest.AppInfoOpensPageInfo*
......
...@@ -37,9 +37,6 @@ ...@@ -37,9 +37,6 @@
# JS failure: hasAccessToCurrentWindow: FAIL (no message) # JS failure: hasAccessToCurrentWindow: FAIL (no message)
-LockScreenNoteTakingTest.* -LockScreenNoteTakingTest.*
# Needs EventGenerator to work across window tree hosts. crbug.com/814675
-OmniboxPopupContentsViewTest.ClickOmnibox
# -------------------------------------------------- # --------------------------------------------------
# Tests failing only for SingleProcessMash. # Tests failing only for SingleProcessMash.
# -------------------------------------------------- # --------------------------------------------------
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment