Remove WebRemoteFrameClient::WasEvicted

This CL removes WebRemoteFrameClient::WasEvicted method, then
WebFrameWidgetImpl starts calling RemoteFrame::ResendVisualProperties
directly for the evicted frame.

Bug: 1166726
Change-Id: Ibd24bf2009631deac9018ff7ee0e848f7a84a9f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636823
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846209}

content/renderer/render_frame_proxy.cc

@@ -524,12 +524,6 @@ RenderFrameProxy::GetRemoteAssociatedInterfaces() {
   return remote_associated_interfaces_.get();
 }
 
-void RenderFrameProxy::WasEvicted() {
-  // On eviction, the last SurfaceId is invalidated. We need to allocate a new
-  // id.
-  web_frame_->ResendVisualProperties();
-}
-
 void RenderFrameProxy::FrameSinkIdChanged(
     const viz::FrameSinkId& frame_sink_id) {
   remote_process_gone_ = false;

content/renderer/render_frame_proxy.h

@@ -161,7 +161,6 @@ class CONTENT_EXPORT RenderFrameProxy : public IPC::Listener,
   bool RemoteProcessGone() const override;
   base::UnguessableToken GetDevToolsFrameToken() override;
   viz::FrameSinkId GetFrameSinkId() const override;
-  void WasEvicted() override;
 
   void DidStartLoading();
 

third_party/blink/public/web/web_remote_frame_client.h

@@ -70,9 +70,6 @@ class WebRemoteFrameClient {
     return viz::FrameSinkId();
   }
 
-  // Inform the widget that it was evicted.
-  virtual void WasEvicted() {}
-
  protected:
   virtual ~WebRemoteFrameClient() = default;
 };

third_party/blink/renderer/core/frame/remote_frame_client.h

@@ -51,8 +51,6 @@ class RemoteFrameClient : public FrameClient {
   virtual AssociatedInterfaceProvider* GetRemoteAssociatedInterfaces() = 0;
 
   virtual viz::FrameSinkId GetFrameSinkId() = 0;
-
-  virtual void WasEvicted() = 0;
 };
 
 }  // namespace blink

third_party/blink/renderer/core/frame/remote_frame_client_impl.cc

@@ -126,8 +126,4 @@ viz::FrameSinkId RemoteFrameClientImpl::GetFrameSinkId() {
   return web_frame_->Client()->GetFrameSinkId();
 }
 
-void RemoteFrameClientImpl::WasEvicted() {
-  return web_frame_->Client()->WasEvicted();
-}
-
 }  // namespace blink

third_party/blink/renderer/core/frame/remote_frame_client_impl.h

@@ -40,7 +40,6 @@ class RemoteFrameClientImpl final : public RemoteFrameClient {
   bool RemoteProcessGone() const override;
   AssociatedInterfaceProvider* GetRemoteAssociatedInterfaces() override;
   viz::FrameSinkId GetFrameSinkId() override;
-  void WasEvicted() override;
 
   WebRemoteFrameImpl* GetWebFrame() const { return web_frame_; }
 

third_party/blink/renderer/core/frame/web_frame_widget_impl.cc

@@ -3807,7 +3807,9 @@ void WebFrameWidgetImpl::WasShown(bool was_evicted) {
   if (was_evicted) {
     ForEachRemoteFrameControlledByWidget(
         WTF::BindRepeating([](RemoteFrame* remote_frame) {
-          remote_frame->Client()->WasEvicted();
+          // On eviction, the last SurfaceId is invalidated. We need to
+          // allocate a new id.
+          remote_frame->ResendVisualProperties();
         }));
   }
 }