Commit 95aecf9b authored by Fabrice de Gans-Riberi's avatar Fabrice de Gans-Riberi Committed by Commit Bot

Roll Open Screen from 44b62e8d9182 to 6d0991e9c086 (1 revision)

https://chromium.googlesource.com/openscreen.git/+log/44b62e8d9182..6d0991e9c086

2020-08-18 miu@chromium.org Cast Streaming: Provide a reason code when destroying Receivers.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1116185
Change-Id: Ie482080f31bc844493e3de335e4e3ad944d1eb71
Tbr: jophba@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363770Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799979}
parent 98897dd3
......@@ -1231,7 +1231,7 @@ deps = {
Var('chromium_git') + '/external/github.com/cisco/openh264' + '@' + '3dd5b80bc4f172dd82925bb259cb7c82348409c5',
'src/third_party/openscreen/src':
Var('chromium_git') + '/openscreen' + '@' + '44b62e8d91822892241510de92783d38b7288ef1',
Var('chromium_git') + '/openscreen' + '@' + '6d0991e9c086d35630fa744a7ec4e0e35e2d82f9',
'src/third_party/openxr/src': {
'url': Var('chromium_git') + '/external/github.com/KhronosGroup/OpenXR-SDK' + '@' + '9e97b73e7dd2bfc07745489d728f6a36665c648f',
......
......@@ -64,9 +64,7 @@ class CastStreamingSession::Internal
DCHECK(client_);
}
// TODO(b/156129407): Change to final when the base interface defines a
// virtual destructor.
virtual ~Internal() = default;
~Internal() final = default;
Internal(const Internal&) = delete;
Internal& operator=(const Internal&) = delete;
......@@ -199,8 +197,10 @@ class CastStreamingSession::Internal
initialized_called_ = true;
}
void OnConfiguredReceiversDestroyed(
const openscreen::cast::ReceiverSession* session) final {
// TODO(https://crbug.com/1116185): Handle |reason| and reset streams on a
// new offer message.
void OnReceiversDestroying(const openscreen::cast::ReceiverSession* session,
ReceiversDestroyingReason reason) final {
DCHECK_EQ(session, &receiver_session_);
DVLOG(1) << __func__;
audio_consumer_.reset();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment