Skip to content

GitLab

T
tangled
Commit 95dbab5c authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot
Browse files
Options

Remove devtools_{lint,type}_check from Chromium buildbots 

We run these checks in the devtools-frontend repository and roll the
code in. There is no need for running these checks in Chromium as well.

Moreover, there appears to be a configuration difference in the Chromium
buildbots compared to our own waterfall. Since these checks already run
in our repository, we should remove them rather than fix them.

Bug: 1041811
Change-Id: Icc879116b8593310b15276bf413647d34ffced3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000707Reviewed-by: default avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732337}
parent bf83ece9
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 262 deletions
testing/buildbot/chromium.fyi.json
View file @ 95dbab5c
...@@ -20348,40 +20348,6 @@ ...@@ -20348,40 +20348,6 @@
}, },
"test_target": "//content/shell:content_shell_crash_test" "test_target": "//content/shell:content_shell_crash_test"
}, },
{
"isolate_name": "devtools_lint_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_lint_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_lint_check"
},
{
"isolate_name": "devtools_type_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_type_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_type_check"
},
{ {
"isolate_name": "flatbuffers_unittests", "isolate_name": "flatbuffers_unittests",
"merge": { "merge": {
...@@ -22228,42 +22194,6 @@ ...@@ -22228,42 +22194,6 @@
}, },
"test_target": "//content/shell:content_shell_crash_test" "test_target": "//content/shell:content_shell_crash_test"
}, },
{
"isolate_coverage_data": true,
"isolate_name": "devtools_lint_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_lint_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_lint_check"
},
{
"isolate_coverage_data": true,
"isolate_name": "devtools_type_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_type_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_type_check"
},
{ {
"isolate_coverage_data": true, "isolate_coverage_data": true,
"isolate_name": "flatbuffers_unittests", "isolate_name": "flatbuffers_unittests",
......
testing/buildbot/chromium.linux.json
View file @ 95dbab5c
...@@ -4020,42 +4020,6 @@ ...@@ -4020,42 +4020,6 @@
}, },
"test_target": "//content/shell:content_shell_crash_test" "test_target": "//content/shell:content_shell_crash_test"
}, },
{
"isolate_coverage_data": true,
"isolate_name": "devtools_lint_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_lint_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_lint_check"
},
{
"isolate_coverage_data": true,
"isolate_name": "devtools_type_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_type_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_type_check"
},
{ {
"isolate_coverage_data": true, "isolate_coverage_data": true,
"isolate_name": "flatbuffers_unittests", "isolate_name": "flatbuffers_unittests",
...@@ -5815,40 +5779,6 @@ ...@@ -5815,40 +5779,6 @@
}, },
"test_target": "//content/shell:content_shell_crash_test" "test_target": "//content/shell:content_shell_crash_test"
}, },
{
"isolate_name": "devtools_lint_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_lint_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_lint_check"
},
{
"isolate_name": "devtools_type_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_type_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_type_check"
},
{ {
"isolate_name": "flatbuffers_unittests", "isolate_name": "flatbuffers_unittests",
"merge": { "merge": {
...@@ -7685,40 +7615,6 @@ ...@@ -7685,40 +7615,6 @@
}, },
"test_target": "//content/shell:content_shell_crash_test" "test_target": "//content/shell:content_shell_crash_test"
}, },
{
"isolate_name": "devtools_lint_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_lint_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-14.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_lint_check"
},
{
"isolate_name": "devtools_type_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_type_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-14.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_type_check"
},
{ {
"isolate_name": "flatbuffers_unittests", "isolate_name": "flatbuffers_unittests",
"merge": { "merge": {
......
testing/buildbot/client.v8.chromium.json
View file @ 95dbab5c
...@@ -487,40 +487,6 @@ ...@@ -487,40 +487,6 @@
}, },
"test_target": "//content/shell:content_shell_crash_test" "test_target": "//content/shell:content_shell_crash_test"
}, },
{
"isolate_name": "devtools_lint_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_lint_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_lint_check"
},
{
"isolate_name": "devtools_type_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_type_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_type_check"
},
{ {
"isolate_name": "telemetry_gpu_unittests", "isolate_name": "telemetry_gpu_unittests",
"merge": { "merge": {
...@@ -1073,40 +1039,6 @@ ...@@ -1073,40 +1039,6 @@
}, },
"test_target": "//content/shell:content_shell_crash_test" "test_target": "//content/shell:content_shell_crash_test"
}, },
{
"isolate_name": "devtools_lint_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_lint_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_lint_check"
},
{
"isolate_name": "devtools_type_check",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "devtools_type_check",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Ubuntu-16.04"
}
]
},
"test_target": "//third_party/devtools-frontend/src:devtools_type_check"
},
{ {
"isolate_name": "telemetry_gpu_unittests", "isolate_name": "telemetry_gpu_unittests",
"merge": { "merge": {
......
testing/buildbot/gn_isolate_map.pyl
View file @ 95dbab5c
...@@ -754,22 +754,6 @@ ...@@ -754,22 +754,6 @@
"label": "//device:device_unittests", "label": "//device:device_unittests",
"type": "console_test_launcher", "type": "console_test_launcher",
}, },
"devtools_type_check": {
"args": [
"../../third_party/devtools-frontend/src/scripts/test/run_type_check.py",
],
"label": "//third_party/devtools-frontend/src:devtools_type_check",
"script": "//testing/scripts/run_devtools_check.py",
"type": "script",
},
"devtools_lint_check": {
"args": [
"../../third_party/devtools-frontend/src/scripts/test/run_lint_check.py",
],
"label": "//third_party/devtools-frontend/src:devtools_lint_check",
"script": "//testing/scripts/run_devtools_check.py",
"type": "script",
},
"display_unittests": { "display_unittests": {
"label": "//ui/display:display_unittests", "label": "//ui/display:display_unittests",
"type": "console_test_launcher", "type": "console_test_launcher",
......
testing/buildbot/test_suites.pyl
View file @ 95dbab5c
...@@ -1010,8 +1010,6 @@ ...@@ -1010,8 +1010,6 @@
'client_v8_chromium_isolated_scripts': { 'client_v8_chromium_isolated_scripts': {
'content_shell_crash_test': {}, 'content_shell_crash_test': {},
'devtools_lint_check': {},
'devtools_type_check': {},
'telemetry_gpu_unittests': { 'telemetry_gpu_unittests': {
'swarming': { 'swarming': {
'idempotent': False, # https://crbug.com/549140 'idempotent': False, # https://crbug.com/549140
...@@ -2664,8 +2662,6 @@ ...@@ -2664,8 +2662,6 @@
}, },
'linux_specific_chromium_isolated_scripts': { 'linux_specific_chromium_isolated_scripts': {
'devtools_lint_check': {},
'devtools_type_check': {},
'not_site_per_process_webkit_layout_tests': { 'not_site_per_process_webkit_layout_tests': {
# not_site_per_process_webkit_layout_tests provides coverage for # not_site_per_process_webkit_layout_tests provides coverage for
# running Layout Tests without site-per-process. This is the mode used # running Layout Tests without site-per-process. This is the mode used
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment