Skip to content

GitLab

T
tangled
Commit 95f84e2e authored by Henrique Nakashima's avatar Henrique Nakashima Committed by Commit Bot
Browse files
Options

Remove incorrect @VisibleForTesting from FeatureList methods 

This fixes some lint warnings, so we can remove the suppressions.

Bug: 1107950
Change-Id: Idbe53038d4595fb571d374f04665671dd68e4d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310789
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: default avatarMohamed Heikal <mheikal@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791931}
parent e6192cfb
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 101 deletions
base/android/java/src/org/chromium/base/FeatureList.java
View file @ 95f84e2e
......@@ -83,7 +83,6 @@ public class FeatureList {
/**
* @return Whether test feature values have been configured.
*/
@VisibleForTesting
public static boolean hasTestFeatures() {
return sTestFeatures != null;
}
......@@ -95,7 +94,6 @@ public class FeatureList {
* @return The test value set for the feature, or null if no test value has been set.
* @throws IllegalArgumentException if no test value was set and default values aren't allowed.
*/
@VisibleForTesting
public static Boolean getTestValueForFeature(String featureName) {
if (hasTestFeatures()) {
if (sTestFeatures.containsKey(featureName)) {
......
build/android/lint/baseline.xml
View file @ 95f84e2e
......@@ -3327,61 +3327,6 @@
column="60"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" Boolean testValue = FeatureList.getTestValueForFeature(featureName);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java"
line="108"
column="41"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" if (FeatureList.hasTestFeatures()) return &quot;&quot;;"
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java"
line="125"
column="25"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" if (FeatureList.hasTestFeatures()) return defaultValue;"
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java"
line="144"
column="25"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" if (FeatureList.hasTestFeatures()) return defaultValue;"
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java"
line="164"
column="25"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" if (FeatureList.hasTestFeatures()) return defaultValue;"
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java"
line="184"
column="25"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
......@@ -3569,17 +3514,6 @@
column="25"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" Boolean testValue = FeatureList.getTestValueForFeature(featureName);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="components/content_settings/android/java/src/org/chromium/components/content_settings/ContentSettingsFeatureList.java"
line="47"
column="41"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
......@@ -3701,17 +3635,6 @@
column="28"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" Boolean testValue = FeatureList.getTestValueForFeature(featureName);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="services/device/public/java/src/org/chromium/device/DeviceFeatureList.java"
line="33"
column="41"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
......@@ -4845,17 +4768,6 @@
column="22"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" Boolean testValue = FeatureList.getTestValueForFeature(featureName);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="components/page_info/android/java/src/org/chromium/components/page_info/PageInfoFeatureList.java"
line="34"
column="41"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
......@@ -5648,17 +5560,6 @@
column="42"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" Boolean testValue = FeatureList.getTestValueForFeature(featureName);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/SiteSettingsFeatureList.java"
line="34"
column="41"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment