tricium: Add Metrics analyzer to chromium project config

This analyzer is specific to chromium/src, so
it can be added to the chromium project config,
where it is a little more convenient to edit.

This CL is related to
https://chrome-internal-review.googlesource.com/c/infradata/config/+/2255124,
which removes the definition from

In addition to moving the definition, this also:
 - Changes the input type from FILES to GIT_FILE_DETAILS,
   since I believe the recipe doesn't use the FILES input.
   This means that the analyzer can start earlier.
 - Changes the component to one under Internals>Metrics
   to help the metrics team triage bug reports.
 - Organizes the file into sections, each ordered
   by analyzer name.

Change-Id: I3084e347d7f03dc1b6dbd9386bee82c79bbdf20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947164Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720709}

infra/config/generated/tricium-prod.cfg

@@ -6,6 +6,68 @@ acls {
   group: "tricium-chromium-requesters"
 }
 
+# Analyzer definitions
+# These are analyzers that are only applicable to this repository.
+
+functions {
+  type: ANALYZER
+  name: "ClangTidy"
+  needs: GIT_FILE_DETAILS
+  provides: RESULTS
+  path_filters: "*.c"
+  path_filters: "*.cc"
+  path_filters: "*.cpp"
+  path_filters: "*.h"
+  owner: "gbiv@google.com"
+  monorail_component: "Infra>Platform>Tricium>Analyzer"
+
+  impls {
+    runtime_platform: LINUX
+    provides_for_platform: LINUX
+
+    recipe {
+      project: "chromium"
+      bucket: "try"
+      builder: "linux-clang-tidy-rel"
+    }
+
+    # 5400sec == 90min. It takes 40mins to build tidy, which we want to stop
+    # doing before we launch this for real. 45ish minutes seems like a
+    # reasonable overall timeout, since the bot itself times out tidy after
+    # 30mins. It's generally expected to take around 5-10mins to get results
+    # back for reasonably-sized CLs.
+    deadline: 5400
+  }
+}
+
+functions {
+  type: ANALYZER
+  name: "Metrics"
+  needs: GIT_FILE_DETAILS
+  provides: RESULTS
+  path_filters: "*.xml"
+  path_filters: "*.json"
+  owner: "ltina@google.com"
+  monorail_component: "Internals>Metrics"
+  impls {
+    runtime_platform: UBUNTU
+    provides_for_platform: UBUNTU
+    recipe {
+      project: "chromium"
+      bucket: "try"
+      builder: "tricium-metrics-analysis"
+    }
+    deadline: 900
+  }
+}
+
+# Selections (enabled functions)
+
+selections {
+  function: "ClangTidy"
+  platform: LINUX
+}
+
 selections {
   function: "Cpplint"
   platform: UBUNTU
@@ -34,11 +96,6 @@ selections {
   platform: UBUNTU
 }
 
-selections {
-  function: "SpellChecker"
-  platform: UBUNTU
-}
-
 selections {
   function: "Pylint"
   platform: UBUNTU
@@ -52,40 +109,9 @@ selections {
   }
 }
 
-functions {
-  type: ANALYZER
-  name: "ClangTidy"
-  needs: GIT_FILE_DETAILS
-  provides: RESULTS
-  path_filters: "*.c"
-  path_filters: "*.cc"
-  path_filters: "*.cpp"
-  path_filters: "*.h"
-  owner: "gbiv@google.com"
-  monorail_component: "Infra>Platform>Tricium>Analyzer"
-
-  impls {
-    runtime_platform: LINUX
-    provides_for_platform: LINUX
-
-    recipe {
-      project: "chromium"
-      bucket: "try"
-      builder: "linux-clang-tidy-rel"
-    }
-
-    # 5400sec == 90min. It takes 40mins to build tidy, which we want to stop
-    # doing before we launch this for real. 45ish minutes seems like a
-    # reasonable overall timeout, since the bot itself times out tidy after
-    # 30mins. It's generally expected to take around 5-10mins to get results
-    # back for reasonably-sized CLs.
-    deadline: 5400
-  }
-}
-
 selections {
-  function: "ClangTidy"
-  platform: LINUX
+  function: "SpellChecker"
+  platform: UBUNTU
 }
 
 repos {

infra/config/tricium-prod.cfg

@@ -6,6 +6,68 @@ acls {
   group: "tricium-chromium-requesters"
 }
 
+# Analyzer definitions
+# These are analyzers that are only applicable to this repository.
+
+functions {
+  type: ANALYZER
+  name: "ClangTidy"
+  needs: GIT_FILE_DETAILS
+  provides: RESULTS
+  path_filters: "*.c"
+  path_filters: "*.cc"
+  path_filters: "*.cpp"
+  path_filters: "*.h"
+  owner: "gbiv@google.com"
+  monorail_component: "Infra>Platform>Tricium>Analyzer"
+
+  impls {
+    runtime_platform: LINUX
+    provides_for_platform: LINUX
+
+    recipe {
+      project: "chromium"
+      bucket: "try"
+      builder: "linux-clang-tidy-rel"
+    }
+
+    # 5400sec == 90min. It takes 40mins to build tidy, which we want to stop
+    # doing before we launch this for real. 45ish minutes seems like a
+    # reasonable overall timeout, since the bot itself times out tidy after
+    # 30mins. It's generally expected to take around 5-10mins to get results
+    # back for reasonably-sized CLs.
+    deadline: 5400
+  }
+}
+
+functions {
+  type: ANALYZER
+  name: "Metrics"
+  needs: GIT_FILE_DETAILS
+  provides: RESULTS
+  path_filters: "*.xml"
+  path_filters: "*.json"
+  owner: "ltina@google.com"
+  monorail_component: "Internals>Metrics"
+  impls {
+    runtime_platform: UBUNTU
+    provides_for_platform: UBUNTU
+    recipe {
+      project: "chromium"
+      bucket: "try"
+      builder: "tricium-metrics-analysis"
+    }
+    deadline: 900
+  }
+}
+
+# Selections (enabled functions)
+
+selections {
+  function: "ClangTidy"
+  platform: LINUX
+}
+
 selections {
   function: "Cpplint"
   platform: UBUNTU
@@ -34,11 +96,6 @@ selections {
   platform: UBUNTU
 }
 
-selections {
-  function: "SpellChecker"
-  platform: UBUNTU
-}
-
 selections {
   function: "Pylint"
   platform: UBUNTU
@@ -52,40 +109,9 @@ selections {
   }
 }
 
-functions {
-  type: ANALYZER
-  name: "ClangTidy"
-  needs: GIT_FILE_DETAILS
-  provides: RESULTS
-  path_filters: "*.c"
-  path_filters: "*.cc"
-  path_filters: "*.cpp"
-  path_filters: "*.h"
-  owner: "gbiv@google.com"
-  monorail_component: "Infra>Platform>Tricium>Analyzer"
-
-  impls {
-    runtime_platform: LINUX
-    provides_for_platform: LINUX
-
-    recipe {
-      project: "chromium"
-      bucket: "try"
-      builder: "linux-clang-tidy-rel"
-    }
-
-    # 5400sec == 90min. It takes 40mins to build tidy, which we want to stop
-    # doing before we launch this for real. 45ish minutes seems like a
-    # reasonable overall timeout, since the bot itself times out tidy after
-    # 30mins. It's generally expected to take around 5-10mins to get results
-    # back for reasonably-sized CLs.
-    deadline: 5400
-  }
-}
-
 selections {
-  function: "ClangTidy"
-  platform: LINUX
+  function: "SpellChecker"
+  platform: UBUNTU
 }
 
 repos {