Make tests navigate to about:blank instead of the NTP.

These tests open a new tab and immediately navigate to a different URL.
The problem is that chrome::AddTabAt by default opens the new tab to the
NTP, which takes a considerable amount of time to load. By specifying
that the new tab should open to the about:blank page instead of the NTP
I observed a decrease in execution time of up to 4 seconds for some of
these tests.

Change-Id: Ife413d2d102610012ff509a712fbfb39314d0f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019805Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Austin Orion <auorion@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#735512}

chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc

@@ -232,7 +232,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetMediaDevicesBrowserTest,
   std::vector<MediaDeviceInfo> devices;
   EnumerateDevices(tab1, &devices);
 
-  chrome::AddTabAt(browser(), GURL(), -1, true);
+  chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), -1, true);
   ui_test_utils::NavigateToURL(browser(), url);
   content::WebContents* tab2 =
       browser()->tab_strip_model()->GetActiveWebContents();
@@ -301,7 +301,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetMediaDevicesBrowserTest,
   std::vector<MediaDeviceInfo> devices;
   EnumerateDevices(tab1, &devices);
 
-  chrome::AddTabAt(browser(), GURL(), -1, true);
+  chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), -1, true);
   ui_test_utils::NavigateToURL(browser(), url);
   content::WebContents* tab2 =
       browser()->tab_strip_model()->GetActiveWebContents();

chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc

@@ -101,7 +101,7 @@ class WebRtcInternalsPerfBrowserTest : public WebRtcTestBase {
 
   std::unique_ptr<base::DictionaryValue> MeasureWebRtcInternalsData(
       int duration_msec) {
-    chrome::AddTabAt(browser(), GURL(), -1, true);
+    chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), -1, true);
     ui_test_utils::NavigateToURL(browser(), GURL("chrome://webrtc-internals"));
     content::WebContents* webrtc_internals_tab =
         browser()->tab_strip_model()->GetActiveWebContents();

chrome/browser/media/webrtc/webrtc_video_display_perf_browsertest.cc

@@ -113,7 +113,7 @@ void AssociateEvents(trace_analyzer::TraceAnalyzer* analyzer,
 }
 
 content::WebContents* OpenWebrtcInternalsTab(Browser* browser) {
-  chrome::AddTabAt(browser, GURL(), -1, true);
+  chrome::AddTabAt(browser, GURL(url::kAboutBlankURL), -1, true);
   ui_test_utils::NavigateToURL(browser, GURL("chrome://webrtc-internals"));
   return browser->tab_strip_model()->GetActiveWebContents();
 }

chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

@@ -1120,7 +1120,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_PreferPreviousSearch) {
   // For some reason we can't use AddSelectedTabWithURL here on ChromeOS. It
   // could be some delicate assumption about the tab starting off unselected or
   // something relating to user gesture.
-  chrome::AddTabAt(browser(), GURL(), -1, true);
+  chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), -1, true);
   ui_test_utils::NavigateToURL(browser(), url);
   WebContents* web_contents_2 =
       browser()->tab_strip_model()->GetActiveWebContents();
@@ -1242,7 +1242,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, PrepopulatePreserveLast) {
       find_in_page::SelectionAction::kKeep, find_in_page::ResultAction::kKeep);
 
   // Now create a second tab and load the same page.
-  chrome::AddTabAt(browser(), GURL(), -1, true);
+  chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), -1, true);
   ui_test_utils::NavigateToURL(browser(), url);
   WebContents* web_contents_2 =
       browser()->tab_strip_model()->GetActiveWebContents();
@@ -1464,7 +1464,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
   EXPECT_EQ(ASCIIToUTF16("1/1"), GetMatchCountText());
 
   // Next, do a search in a second tab.
-  chrome::AddTabAt(browser(), GURL(), -1, true);
+  chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), -1, true);
   ui_test_utils::NavigateToURL(browser(), url);
   WebContents* web_contents_2 =
       browser()->tab_strip_model()->GetActiveWebContents();

chrome/browser/ui/find_bar/find_bar_platform_helper_mac_interactive_uitest.mm

@@ -151,7 +151,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest,
                                            ->GetFindBarTesting()
                                            ->GetMatchCountText());
 
-  chrome::AddTabAt(browser(), GURL(), -1, true);
+  chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), -1, true);
   ui_test_utils::NavigateToURL(browser(), url);
   chrome::Find(browser());
 
@@ -236,7 +236,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest,
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_T, false,
                                               false, false, false));
 
-  chrome::AddTabAt(browser(), GURL(), -1, true);
+  chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), -1, true);
   ui_test_utils::NavigateToURL(browser(), url);
   ASSERT_NE(first_active_web_contents,
             browser()->tab_strip_model()->GetActiveWebContents());