Commit 960b2849 authored by Sarah Hu's avatar Sarah Hu Committed by Commit Bot

cros: Add aria label for fingerprint delete icon

Bug: 881430
Change-Id: Ib8488e23e388d15c006b66d38e9084cfc93c6c70
Reviewed-on: https://chromium-review.googlesource.com/1222198Reviewed-by: default avatarMichael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591168}
parent 84513669
......@@ -3329,6 +3329,9 @@
<message name="IDS_SETTINGS_PEOPLE_LOCK_SCREEN_FINGERPRINT_LESS_SECURE" desc="Text telling users that fingerprints might be less secure than strong PINs or passwords.">
Note: Your fingerprint may be less secure than a strong password or PIN.
</message>
<message name="IDS_SETTINGS_PEOPLE_LOCK_SCREEN_DELETE_FINGERPRINT_ARIA_LABEL" desc="Aria label for the button in the fingerprint subpage that deletes a registered fingerprint. Only visible by screen reader software.">
delete [<ph name="FINGERPRINT_NAME">$1<ex>Fingerprint 1</ex></ph>], button
</message>
<message name="IDS_SETTINGS_PEOPLE_LOCK_SCREEN_NEW_FINGERPRINT_DEFAULT_NAME" desc="The default name (plus a number for a newly added fingerprint).">
Finger <ph name="NEW_FINGER_NUMBER">$1<ex>1</ex></ph>
</message>
......
......@@ -55,7 +55,9 @@
<cr-input value="{{item}}" on-change="onFingerprintLabelChanged_">
</cr-input>
<paper-icon-button-light class="icon-delete-gray">
<button on-click="onFingerprintDeleteTapped_"></button>
<button on-click="onFingerprintDeleteTapped_"
aria-label$="[[getButtonAriaLabel_(item)]]">
</button>
</paper-icon-button-light>
</div>
</template>
......
......@@ -181,5 +181,14 @@ Polymer({
this.onSetupFingerprintDialogClose_();
}
},
/**
* @param {string} item
* @return {string}
* @private
*/
getButtonAriaLabel_: function(item) {
return this.i18n('lockScreenDeleteFingerprintLabel', item);
},
});
})();
......@@ -1572,6 +1572,8 @@ void AddPeopleStrings(content::WebUIDataSource* html_source, Profile* profile) {
IDS_SETTINGS_PEOPLE_LOCK_SCREEN_FINGERPRINT_SUBPAGE_TITLE},
{"lockScreenFingerprintWarning",
IDS_SETTINGS_PEOPLE_LOCK_SCREEN_FINGERPRINT_LESS_SECURE},
{"lockScreenDeleteFingerprintLabel",
IDS_SETTINGS_PEOPLE_LOCK_SCREEN_DELETE_FINGERPRINT_ARIA_LABEL},
{"lockScreenNotificationHide",
IDS_ASH_SETTINGS_LOCK_SCREEN_NOTIFICATION_HIDE},
{"lockScreenNotificationHideSensitive",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment