Commit 96254d31 authored by Anastasiia Nikolaienko's avatar Anastasiia Nikolaienko Committed by Commit Bot

Fix accessibility on Account Manager page

Bug: 1043108
Change-Id: I0cbc5c04efb6e11e734c0528f330c10157fee083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083150
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746788}
parent 3e721718
...@@ -137,9 +137,9 @@ ...@@ -137,9 +137,9 @@
</cr-button> </cr-button>
</div> </div>
<div id="outer" class="layout vertical nowrap"> <div id="outer" class="layout vertical nowrap" role="list">
<template is="dom-repeat" id="account-list" items="[[accounts_]]"> <template is="dom-repeat" id="account-list" items="[[accounts_]]">
<div class="settings-box account-list-item"> <div class="settings-box account-list-item" role="listitem">
<div class="profile-icon" <div class="profile-icon"
style="background-image: [[getIconImageSet_(item.pic)]]"> style="background-image: [[getIconImageSet_(item.pic)]]">
...@@ -152,7 +152,8 @@ ...@@ -152,7 +152,8 @@
<div class="flex text-elide"> <div class="flex text-elide">
<!-- If account is signed in, display the full name --> <!-- If account is signed in, display the full name -->
<template is="dom-if" if="[[item.isSignedIn]]"> <template is="dom-if" if="[[item.isSignedIn]]">
<span>[[item.fullName]]</span> <span id="fullName-[[index]]"
aria-hidden="true">[[item.fullName]]</span>
</template> </template>
<!-- Else, display a re-authentication message --> <!-- Else, display a re-authentication message -->
<template is="dom-if" if="[[!item.isSignedIn]]"> <template is="dom-if" if="[[!item.isSignedIn]]">
...@@ -161,26 +162,31 @@ ...@@ -161,26 +162,31 @@
</span> </span>
</template> </template>
<div class="secondary">[[item.email]]</div> <div class="secondary" id="email-[[index]]"
aria-hidden="true">[[item.email]]</div>
</div> </div>
</div> </div>
<template is="dom-if" <template is="dom-if"
if="[[shouldShowReauthenticationButton_(item)]]"> if="[[shouldShowReauthenticationButton_(item)]]">
<cr-button title="[[getAccountManagerSignedOutTitle_(item)]]" <cr-button title="[[getAccountManagerSignedOutTitle_(item)]]"
class="reauth-button" on-click="onReauthenticationTap_"> class="reauth-button" on-click="onReauthenticationTap_"
aria-labelledby$="fullName-[[index]] email-[[index]]">
[[getAccountManagerSignedOutLabel_(item.unmigrated)]] [[getAccountManagerSignedOutLabel_(item.unmigrated)]]
</cr-button> </cr-button>
</template> </template>
<!-- If this is the Device Account, display the management status --> <!-- If this is the Device Account, display the management status -->
<template is="dom-if" if="[[item.isDeviceAccount]]"> <template is="dom-if" if="[[item.isDeviceAccount]]">
<cr-tooltip-icon icon-class="cr:info-outline" <cr-tooltip-icon id="primaryAccountTooltip" aria-hidden="true"
icon-class="cr:info-outline"
class="tooltip-primary-account" class="tooltip-primary-account"
tooltip-text="$i18n{accountManagerPrimaryAccountTooltip}" tooltip-text="$i18n{accountManagerPrimaryAccountTooltip}"
icon-aria-label="$i18n{accountManagerPrimaryAccountTooltip}"> icon-aria-label="$i18n{accountManagerPrimaryAccountTooltip}">
</cr-tooltip-icon> </cr-tooltip-icon>
<span class="management-status"> <span class="management-status"
aria-labelledby$="fullName-[[index]] email-[[index]]"
aria-describedby="primaryAccountTooltip">
[[getManagementLabel_(item)]] [[getManagementLabel_(item)]]
</span> </span>
</template> </template>
...@@ -188,6 +194,8 @@ ...@@ -188,6 +194,8 @@
<template is="dom-if" if="[[!item.isDeviceAccount]]"> <template is="dom-if" if="[[!item.isDeviceAccount]]">
<cr-icon-button class="icon-more-vert" <cr-icon-button class="icon-more-vert"
title="[[getMoreActionsTitle_(item)]]" title="[[getMoreActionsTitle_(item)]]"
aria-label="[[getMoreActionsTitle_(item)]]"
aria-describedby$="fullName-[[index]]"
on-click="onAccountActionsMenuButtonTap_"> on-click="onAccountActionsMenuButtonTap_">
</cr-icon-button> </cr-icon-button>
</template> </template>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment