Commit 964eeb18 authored by Mugdha Lakhani's avatar Mugdha Lakhani Committed by Commit Bot

[BackgroundFetch] Remove BackgroundFetchSettledFetch idl.

BackgroundFetchSettledFetch isn't exposed to JavaScript so we can remove this.

Bug: 875201
Change-Id: Ic306b0f64897a7d7c1fbd61f64b6c635620d7bd3
Reviewed-on: https://chromium-review.googlesource.com/c/1288357Reviewed-by: default avatarRayan Kanso <rayankans@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600763}
parent aa193def
......@@ -6,7 +6,7 @@ test(t => {
self,
['BackgroundFetchEvent', 'BackgroundFetchFetch', 'BackgroundFetchManager',
'BackgroundFetchUpdateUIEvent', 'BackgroundFetchRecord',
'BackgroundFetchRegistration', 'BackgroundFetchSettledFetch']);
'BackgroundFetchRegistration']);
}, 'Background Fetch API interfaces in Origin-Trial disabled worker.');
done();
......@@ -15,7 +15,6 @@ test(t => {
'BackgroundFetchEvent': ['registration'],
'BackgroundFetchUpdateUIEvent': ['updateUI'],
'BackgroundFetchRecord': ['request', 'responseReady'],
'BackgroundFetchSettledFetch': ['response'],
'BackgroundFetchRegistration': ['id', 'uploadTotal', 'uploaded',
'downloadTotal', 'downloaded', 'result',
'failureReason', 'recordsAvailable',
......
......@@ -49,10 +49,6 @@ interface BackgroundFetchRegistration : EventTarget
method match
method matchAll
setter onprogress
interface BackgroundFetchSettledFetch : BackgroundFetchFetch
attribute @@toStringTag
getter response
method constructor
interface BackgroundFetchUpdateUIEvent : BackgroundFetchEvent
attribute @@toStringTag
method constructor
......
......@@ -20,8 +20,6 @@ blink_modules_sources("background_fetch") {
"background_fetch_record.h",
"background_fetch_registration.cc",
"background_fetch_registration.h",
"background_fetch_settled_fetch.cc",
"background_fetch_settled_fetch.h",
"background_fetch_type_converters.cc",
"background_fetch_type_converters.h",
"background_fetch_update_ui_event.cc",
......
......@@ -13,7 +13,6 @@
#include "third_party/blink/renderer/core/fetch/response.h"
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.h"
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_record.h"
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetch.h"
#include "third_party/blink/renderer/modules/cache_storage/cache.h"
#include "third_party/blink/renderer/modules/cache_storage/cache_query_options.h"
#include "third_party/blink/renderer/modules/event_target_modules_names.h"
......
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetch.h"
#include "third_party/blink/renderer/core/fetch/response.h"
namespace blink {
BackgroundFetchSettledFetch::BackgroundFetchSettledFetch(Request* request,
Response* response)
: BackgroundFetchFetch(request), response_(response) {}
Response* BackgroundFetchSettledFetch::response() const {
return response_;
}
void BackgroundFetchSettledFetch::Trace(blink::Visitor* visitor) {
visitor->Trace(response_);
BackgroundFetchFetch::Trace(visitor);
}
} // namespace blink
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef THIRD_PARTY_BLINK_RENDERER_MODULES_BACKGROUND_FETCH_BACKGROUND_FETCH_SETTLED_FETCH_H_
#define THIRD_PARTY_BLINK_RENDERER_MODULES_BACKGROUND_FETCH_BACKGROUND_FETCH_SETTLED_FETCH_H_
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_fetch.h"
#include "third_party/blink/renderer/platform/heap/handle.h"
namespace blink {
class Request;
class Response;
// Interface for providing developers access to the Request/Response pairs when
// a background fetch has settled, either through the `backgroundfetchsuccess`
// event in case of success, or `backgroundfetchfail` in case of failure.
class BackgroundFetchSettledFetch final : public BackgroundFetchFetch {
DEFINE_WRAPPERTYPEINFO();
public:
static BackgroundFetchSettledFetch* Create(Request* request,
Response* response) {
return new BackgroundFetchSettledFetch(request, response);
}
// Web Exposed attribute defined in the IDL file.
Response* response() const;
void Trace(blink::Visitor* visitor) override;
private:
BackgroundFetchSettledFetch(Request* request, Response* response);
Member<Response> response_;
};
} // namespace blink
#endif // THIRD_PARTY_BLINK_RENDERER_MODULES_BACKGROUND_FETCH_BACKGROUND_FETCH_SETTLED_FETCH_H_
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// https://wicg.github.io/background-fetch/#backgroundfetchsettledfetch
[
Constructor(Request request, Response response),
Exposed=ServiceWorker,
OriginTrialEnabled=BackgroundFetch
] interface BackgroundFetchSettledFetch : BackgroundFetchFetch {
readonly attribute Response? response;
};
......@@ -13,7 +13,6 @@
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_event_init.h"
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.h"
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h"
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetch.h"
#include "third_party/blink/renderer/modules/background_fetch/background_fetch_ui_options.h"
#include "third_party/blink/renderer/modules/event_modules_names.h"
#include "third_party/blink/renderer/platform/bindings/script_state.h"
......
......@@ -70,7 +70,6 @@ modules_idl_files =
"background_fetch/background_fetch_manager.idl",
"background_fetch/background_fetch_record.idl",
"background_fetch/background_fetch_registration.idl",
"background_fetch/background_fetch_settled_fetch.idl",
"background_fetch/background_fetch_update_ui_event.idl",
"background_sync/sync_event.idl",
"background_sync/sync_manager.idl",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment