Commit 9656fc6b authored by Kouhei Ueno's avatar Kouhei Ueno Committed by Commit Bot

BackForwardCache: unblocklist geolocation API on Android

The API was previously blocklisted due to:
- test failures, which was resolved in [1]
- omnibox geolocation icon incompat, which is not available on Android

This CL unblocklists geolocation API on Android.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1883428

Bug: 1015377, 989847
Change-Id: I1ee2dd4f9c9496622769431040fd0d99440ad0b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886534
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: default avatarFergal Daly <fergal@chromium.org>
Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712922}
parent a11d775b
...@@ -8,6 +8,8 @@ ...@@ -8,6 +8,8 @@
#include <string> #include <string>
#include "base/metrics/field_trial_params.h" #include "base/metrics/field_trial_params.h"
#include "base/strings/string_split.h"
#include "build/build_config.h"
#include "content/browser/frame_host/frame_tree_node.h" #include "content/browser/frame_host/frame_tree_node.h"
#include "content/browser/frame_host/render_frame_host_delegate.h" #include "content/browser/frame_host/render_frame_host_delegate.h"
#include "content/browser/frame_host/render_frame_host_impl.h" #include "content/browser/frame_host/render_frame_host_impl.h"
...@@ -78,7 +80,15 @@ bool IsServiceWorkerSupported() { ...@@ -78,7 +80,15 @@ bool IsServiceWorkerSupported() {
bool IsGeolocationSupported() { bool IsGeolocationSupported() {
static constexpr base::FeatureParam<bool> geolocation_supported( static constexpr base::FeatureParam<bool> geolocation_supported(
&features::kBackForwardCache, "geolocation_supported", false); &features::kBackForwardCache, "geolocation_supported",
#if defined(OS_ANDROID)
true
#else
// TODO(crbug.com/989847): Omnibox icon should be updated when the page
// enters or is restored from BackForwardCache.
false
#endif
);
return geolocation_supported.Get(); return geolocation_supported.Get();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment