[LayoutNG] Remove IgnoreFloats() break token mechanism.

This didn't serve any purpose anymore, since fragmentation of
inline-level floats is currently broken (no pun intended). See
crbug.com/915929

Change-Id: Ib852e68daae9d0ebe47f844d7395ae897100d047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761274Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688511}

third_party/blink/renderer/core/layout/ng/inline/ng_inline_break_token.h

@@ -69,15 +69,6 @@ class CORE_EXPORT NGInlineBreakToken final : public NGBreakToken {
     return flags_ & kIsForcedBreak;
   }
 
-  // When a previously laid out line box didn't fit in the current
-  // fragmentainer, and we have to lay it out again in the next fragmentainer,
-  // we need to skip floats associated with that line. The parent block layout
-  // algorithm will take care of any floats that broke and need to be resumed in
-  // the next fragmentainer. Dealing with them as part of line layout as well
-  // would result in duplicate fragments for the floats.
-  void SetIgnoreFloats() { ignore_floats_ = true; }
-  bool IgnoreFloats() const { return ignore_floats_; }
-
 #if DCHECK_IS_ON()
   String ToString() const override;
 #endif

third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc

@@ -981,7 +981,6 @@ unsigned NGInlineLayoutAlgorithm::PositionLeadingFloats(
     NGExclusionSpace* exclusion_space,
     NGPositionedFloatVector* positioned_floats) {
   bool is_empty_inline = Node().IsEmptyInline();
-  bool should_ignore_floats = BreakToken() && BreakToken()->IgnoreFloats();
 
   const Vector<NGInlineItem>& items =
       Node().ItemsData(/* is_first_line */ false).items;
@@ -996,7 +995,7 @@ unsigned NGInlineLayoutAlgorithm::PositionLeadingFloats(
       break;
     }
 
-    if (item.Type() != NGInlineItem::kFloating || should_ignore_floats)
+    if (item.Type() != NGInlineItem::kFloating)
       continue;
 
     container_builder_.AddAdjoiningObjectTypes(

third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc

@@ -203,7 +203,6 @@ NGLineBreaker::NGLineBreaker(NGInlineNode node,
     break_iterator_.SetStartOffset(offset_);
     is_after_forced_break_ = break_token->IsForcedBreak();
     items_data_.AssertOffset(item_index_, offset_);
-    ignore_floats_ = break_token->IgnoreFloats();
   }
 
   // There's a special intrinsic size measure quirk for images that are direct
@@ -1305,9 +1304,6 @@ void NGLineBreaker::HandleFloat(const NGInlineItem& item,
     return;
   }
 
-  if (ignore_floats_)
-    return;
-
   // Make sure we populate the positioned_float inside the |item_result|.
   if (item_index_ <= handled_leading_floats_index_ &&
       !leading_floats_.IsEmpty()) {

third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.h

@@ -240,8 +240,6 @@ class CORE_EXPORT NGLineBreaker {
   // the next line.
   bool is_after_forced_break_ = false;
 
-  bool ignore_floats_ = false;
-
   // Set in quirks mode when we're not supposed to break inside table cells
   // between images, and between text and images.
   bool sticky_images_quirk_ = false;

third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.cc

@@ -129,11 +129,6 @@ void NGBoxFragmentBuilder::AddBreakBeforeLine(int line_number) {
       }
     }
   }
-
-  // We need to resume at the right inline location in the next fragment, but
-  // broken floats, which are resumed and positioned by the parent block layout
-  // algorithm, need to be ignored by the inline layout algorithm.
-  To<NGInlineBreakToken>(inline_break_tokens_.back().get())->SetIgnoreFloats();
 }
 
 void NGBoxFragmentBuilder::AddResult(const NGLayoutResult& child_layout_result,

third_party/blink/renderer/core/layout/ng/ng_break_token.h

@@ -71,7 +71,6 @@ class CORE_EXPORT NGBreakToken : public RefCounted<NGBreakToken> {
         type_(type),
         status_(status),
         flags_(0),
-        ignore_floats_(false),
         is_break_before_(false),
         is_forced_break_(false),
         has_last_resort_break_(false),
@@ -92,7 +91,6 @@ class CORE_EXPORT NGBreakToken : public RefCounted<NGBreakToken> {
   // defined here to save memory, since that class has no bitfields).
 
   unsigned flags_ : 2;  // NGInlineBreakTokenFlags
-  unsigned ignore_floats_ : 1;
 
   // The following bitfields are only to be used by NGBlockBreakToken (it's
   // defined here to save memory, since that class has no bitfields).