Experimental flags for crostini apt search

Flags for enabling/disabling crostini apt search (experimental feature)
go/chrome-apt-search

Bug: 921429
Change-Id: Ie15fb190df45e766c3daa31bdef112e58e0ff71a
Reviewed-on: https://chromium-review.googlesource.com/c/1408708Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Josh Pratt <jopra@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Daniel Ng <danielng@google.com>
Cr-Commit-Position: refs/heads/master@{#622968}

chrome/browser/about_flags.cc

@@ -4298,6 +4298,12 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kEnableGpuServiceLoggingName,
      flag_descriptions::kEnableGpuServiceLoggingDescription, kOsAll,
      SINGLE_VALUE_TYPE(switches::kEnableGPUServiceLogging)},
+
+#if defined(OS_CHROMEOS)
+    {"crostini-app-search", flag_descriptions::kCrostiniAppSearchName,
+     flag_descriptions::kCrostiniAppSearchDescription, kOsCrOS,
+     FEATURE_VALUE_TYPE(features::kCrostiniAppSearch)},
+#endif  // OS_CHROMEOS
 };
 
 class FlagsStateSingleton {

chrome/browser/flag-metadata.json

@@ -456,6 +456,11 @@
     // "owners": [ "your-team" ],
     "expiry_milestone": 76
   },
+  {
+    "name": "crostini-app-search",
+    "owners": [ "crostini-ui" ],
+    "expiry_milestone": 76
+  },
   {
     "name": "crostini-backup",
     "owners": [ "joelhockey", "nverne", "benwells" ],

chrome/browser/flag_descriptions.cc

@@ -3136,6 +3136,10 @@ const char kCrosRegionsModeDefault[] = "Default";
 const char kCrosRegionsModeOverride[] = "Override VPD values.";
 const char kCrosRegionsModeHide[] = "Hide VPD values.";
 
+const char kCrostiniAppSearchName[] = "Crostini App Search";
+const char kCrostiniAppSearchDescription[] =
+    "Enable search and installation of Crostini apps in the launcher.";
+
 const char kCrostiniBackupName[] = "Crostini Backup";
 const char kCrostiniBackupDescription[] = "Enable Crostini export and import.";
 

chrome/browser/flag_descriptions.h

@@ -1888,6 +1888,9 @@ extern const char kCrosRegionsModeDefault[];
 extern const char kCrosRegionsModeOverride[];
 extern const char kCrosRegionsModeHide[];
 
+extern const char kCrostiniAppSearchName[];
+extern const char kCrostiniAppSearchDescription[];
+
 extern const char kCrostiniBackupName[];
 extern const char kCrostiniBackupDescription[];
 

chrome/common/chrome_features.cc

@@ -178,6 +178,11 @@ const base::Feature kClipboardContentSetting{"ClipboardContentSetting",
 // Enable project Crostini, Linux VMs on Chrome OS.
 const base::Feature kCrostini{"Crostini", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// Enables not installed apps/packages to be searched for and installed in the
+// App launcher.
+const base::Feature kCrostiniAppSearch{"CrostiniAppSearch",
+                                       base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Enables an uninstall option in the right-click menu of Crostini (Linux)
 // applications.
 // TODO(iby): Remove once remaining bugs fixed.

chrome/common/chrome_features.h

@@ -117,6 +117,8 @@ COMPONENT_EXPORT(CHROME_FEATURES) extern const base::Feature kContentFullscreen;
 #if defined(OS_CHROMEOS)
 COMPONENT_EXPORT(CHROME_FEATURES) extern const base::Feature kCrostini;
 COMPONENT_EXPORT(CHROME_FEATURES)
+extern const base::Feature kCrostiniAppSearch;
+COMPONENT_EXPORT(CHROME_FEATURES)
 extern const base::Feature kCrostiniAppUninstallGui;
 COMPONENT_EXPORT(CHROME_FEATURES) extern const base::Feature kPluginVm;
 COMPONENT_EXPORT(CHROME_FEATURES)

tools/metrics/histograms/enums.xml

@@ -31416,6 +31416,7 @@ from previous Chrome versions.
   <int value="-127231994" label="VrBrowsingNativeAndroidUi:disabled"/>
   <int value="-122492389" label="enable-browser-task-scheduler"/>
   <int value="-120521482" label="DirectManipulationStylus:enabled"/>
+  <int value="-120091289" label="CrostiniAppSearch:enabled"/>
   <int value="-119055644" label="GenericSensor:enabled"/>
   <int value="-115834377" label="EnableUnifiedMultiDeviceSetup:disabled"/>
   <int value="-112459802" label="WebXrRenderPath:enabled"/>
@@ -31650,6 +31651,7 @@ from previous Chrome versions.
   <int value="328722396" label="NTPCondensedLayout:disabled"/>
   <int value="330138076" label="enable-clear-browsing-data-counters"/>
   <int value="330439654" label="SyncPseudoUSSExtensions:enabled"/>
+  <int value="331770879" label="CrostiniAppSearch:disabled"/>
   <int value="332391072" label="cs-contextual-cards-bar-integration"/>
   <int value="334802038" label="OfflinePreviews:disabled"/>
   <int value="336429189" label="DisallowUnsafeHttpDownloads:disabled"/>