Commit 96bb7bcb authored by Xiaocheng Hu's avatar Xiaocheng Hu Committed by Commit Bot

Reassign TODO(style-dev) to actual crbugs

NoTry: True
Change-Id: Ib22428b110b43557bce515880d4007a3c3f83fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749960
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686236}
parent c935c377
...@@ -106,16 +106,16 @@ bool CSSPrimitiveValue::IsFontRelativeLength() const { ...@@ -106,16 +106,16 @@ bool CSSPrimitiveValue::IsFontRelativeLength() const {
} }
bool CSSPrimitiveValue::IsResolution() const { bool CSSPrimitiveValue::IsResolution() const {
// TODO(style-dev): Either support math functions on resolutions; or provide a // TODO(crbug.com/983613): Either support math functions on resolutions; or
// justification for not supporting it, and move this function to // provide a justification for not supporting it, and move this function to
// |CSSNumericLiteralValue|. // |CSSNumericLiteralValue|.
return IsNumericLiteralValue() && return IsNumericLiteralValue() &&
To<CSSNumericLiteralValue>(this)->IsResolution(); To<CSSNumericLiteralValue>(this)->IsResolution();
} }
bool CSSPrimitiveValue::IsFlex() const { bool CSSPrimitiveValue::IsFlex() const {
// TODO(style-dev): Either support math functions on flexible lengths; or // TODO(crbug.com/993136): Either support math functions on flexible lengths;
// provide a justification for not supporting it, and move this function to // or provide a justification for not supporting it, and move this function to
// |CSSNumericLiteralValue|. // |CSSNumericLiteralValue|.
return IsNumericLiteralValue() && To<CSSNumericLiteralValue>(this)->IsFlex(); return IsNumericLiteralValue() && To<CSSNumericLiteralValue>(this)->IsFlex();
} }
...@@ -145,7 +145,7 @@ bool CSSPrimitiveValue::IsNumber() const { ...@@ -145,7 +145,7 @@ bool CSSPrimitiveValue::IsNumber() const {
} }
bool CSSPrimitiveValue::IsInteger() const { bool CSSPrimitiveValue::IsInteger() const {
// TODO(style-dev): Support integer math functions properly. // TODO(crbug.com/931216): Support integer math functions properly.
return IsNumericLiteralValue() && return IsNumericLiteralValue() &&
To<CSSNumericLiteralValue>(this)->IsInteger(); To<CSSNumericLiteralValue>(this)->IsInteger();
} }
...@@ -216,8 +216,8 @@ double CSSPrimitiveValue::ComputeDegrees() const { ...@@ -216,8 +216,8 @@ double CSSPrimitiveValue::ComputeDegrees() const {
} }
double CSSPrimitiveValue::ComputeDotsPerPixel() const { double CSSPrimitiveValue::ComputeDotsPerPixel() const {
// TODO(style-dev): Either support math functions on resolutions; or provide a // TODO(crbug.com/983613): Either support math functions on resolutions; or
// justification for not supporting it. // provide a justification for not supporting it.
DCHECK(IsNumericLiteralValue()); DCHECK(IsNumericLiteralValue());
return To<CSSNumericLiteralValue>(this)->ComputeDotsPerPixel(); return To<CSSNumericLiteralValue>(this)->ComputeDotsPerPixel();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment