Commit 96bf95f6 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

[ios] Convert GN libs lists to frameworks in //ios/third_party.

GN recently added support for Apple frameworks to link, rather than
overloading the libs lists. This pulls .frameworks out of the libs
lists, so that GN can stop supporting .frameworks in libs in the
future.

Bug: 1052560
Change-Id: Ib09490abc81fa0988b8e2428b3946edd6f468c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277727
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarOlivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784372}
parent 12c233c2
...@@ -142,7 +142,7 @@ source_set("common_lib") { ...@@ -142,7 +142,7 @@ source_set("common_lib") {
public_configs = [ ":config" ] public_configs = [ ":config" ]
libs = [ "UIKit.framework" ] frameworks = [ "UIKit.framework" ]
configs -= [ configs -= [
"//build/config/gcc:symbol_visibility_hidden", "//build/config/gcc:symbol_visibility_hidden",
...@@ -211,7 +211,7 @@ source_set("ui_lib") { ...@@ -211,7 +211,7 @@ source_set("ui_lib") {
public_configs = [ ":config" ] public_configs = [ ":config" ]
libs = [ frameworks = [
"QuartzCore.framework", "QuartzCore.framework",
"UIKit.framework", "UIKit.framework",
] ]
...@@ -396,7 +396,7 @@ ios_framework_bundle("app_framework") { ...@@ -396,7 +396,7 @@ ios_framework_bundle("app_framework") {
public_headers = [ "src/AppFramework/EarlGreyApp/EarlGreyApp.h" ] public_headers = [ "src/AppFramework/EarlGreyApp/EarlGreyApp.h" ]
libs = [ frameworks = [
"CoreData.framework", "CoreData.framework",
"CoreGraphics.framework", "CoreGraphics.framework",
"Foundation.framework", "Foundation.framework",
...@@ -486,7 +486,7 @@ source_set("test_lib") { ...@@ -486,7 +486,7 @@ source_set("test_lib") {
":test_lib_shared_headers", ":test_lib_shared_headers",
] ]
libs = [ frameworks = [
"CoreData.framework", "CoreData.framework",
"CoreGraphics.framework", "CoreGraphics.framework",
"Foundation.framework", "Foundation.framework",
......
...@@ -86,7 +86,7 @@ ios_framework_bundle("gtx") { ...@@ -86,7 +86,7 @@ ios_framework_bundle("gtx") {
] ]
deps = [ "//build/config/ios:xctest" ] deps = [ "//build/config/ios:xctest" ]
libs = [ frameworks = [
"CoreGraphics.framework", "CoreGraphics.framework",
"Foundation.framework", "Foundation.framework",
"QuartzCore.framework", "QuartzCore.framework",
......
...@@ -30,7 +30,7 @@ source_set("material_internationalization_ios") { ...@@ -30,7 +30,7 @@ source_set("material_internationalization_ios") {
"src/Sources/UIView+MaterialRTL.h", "src/Sources/UIView+MaterialRTL.h",
] ]
libs = [ frameworks = [
"CoreImage.framework", "CoreImage.framework",
"UIKit.framework", "UIKit.framework",
] ]
......
...@@ -44,7 +44,7 @@ source_set("motion_animator_objc") { ...@@ -44,7 +44,7 @@ source_set("motion_animator_objc") {
"src/src/MotionAnimator.h", "src/src/MotionAnimator.h",
] ]
libs = [ frameworks = [
"CoreGraphics.framework", "CoreGraphics.framework",
"Foundation.framework", "Foundation.framework",
"QuartzCore.framework", "QuartzCore.framework",
......
...@@ -50,7 +50,7 @@ source_set("motion_interchange_objc") { ...@@ -50,7 +50,7 @@ source_set("motion_interchange_objc") {
"src/src/MotionInterchange.h", "src/src/MotionInterchange.h",
] ]
libs = [ frameworks = [
"CoreGraphics.framework", "CoreGraphics.framework",
"Foundation.framework", "Foundation.framework",
"QuartzCore.framework", "QuartzCore.framework",
......
...@@ -41,7 +41,7 @@ source_set("motion_transitioning_objc") { ...@@ -41,7 +41,7 @@ source_set("motion_transitioning_objc") {
"src/src/UIViewController+TransitionController.h", "src/src/UIViewController+TransitionController.h",
] ]
libs = [ frameworks = [
"CoreGraphics.framework", "CoreGraphics.framework",
"Foundation.framework", "Foundation.framework",
] ]
......
...@@ -247,7 +247,7 @@ ios_framework_bundle("ochamcrest") { ...@@ -247,7 +247,7 @@ ios_framework_bundle("ochamcrest") {
"src/Source/OCHamcrest.h", "src/Source/OCHamcrest.h",
] ]
libs = [ frameworks = [
"Foundation.framework", "Foundation.framework",
"UIKit.framework", "UIKit.framework",
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment