Commit 96c28ba2 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Fieldset NG: Enable the feature as "experimental"

Change the runtime flag status to "experimental", and remove
virtual/layout_ng_fieldset/.

Known issues:

* inert-retargetting*.tentative.html:
  They have CHECK failures in |NGPhysicalBoxFragment::
  CheckSameForSimplifiedLayout()|

* contain-intrinsic-size-014.html: Fieldset NG doesn't support size
  containment yet.

* fieldset-mask.html: Fieldset NG needs to adjust mask painting area.

We'll address them soon.

Bug: 375693, 875235
Change-Id: Id051f04c7e0fe862e26305b27c106abdee75ba1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340647Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795951}
parent dd443cd8
......@@ -11,7 +11,6 @@ rootWebArea
++++++++++textField
++++++++++++genericContainer
++++++++++staticText name=' Rendering Engine: '
++++++++++++inlineTextBox name=' '
++++++++++++inlineTextBox name='Rendering Engine: '
++++++++++++inlineTextBox name=' Rendering Engine: '
++++++++++textField
++++++++++++genericContainer
......@@ -953,7 +953,7 @@
// provides a convenient way for testing legacy layout code path in blink
// unit tests.
name: "LayoutNG",
implied_by: ["LayoutNGFieldset", "LayoutNGGrid", "BidiCaretAffinity", "LayoutNGTable"],
implied_by: ["LayoutNGGrid", "BidiCaretAffinity", "LayoutNGTable"],
status: "stable",
},
{
......@@ -961,6 +961,8 @@
},
{
name: "LayoutNGFieldset",
depends_on: ["LayoutNG"],
status: "experimental",
},
{
name: "LayoutNGFlexBox",
......
......@@ -10,7 +10,6 @@ http/tests/devtools/tracing/* [ Skip ]
virtual/composite-after-paint/* [ Skip ]
virtual/layout_ng_block_frag/* [ Skip ]
virtual/layout_ng_fieldset/* [ Skip ]
virtual/layout_ng_fragment_traversal/* [ Skip ]
virtual/prefer_compositing_to_lcd_text/compositing/overflow/* [ Skip ]
virtual/stable/* [ Skip ]
......
......@@ -410,6 +410,7 @@ crbug.com/591099 fast/css/text-overflow-ellipsis-button.html [ Failure ]
crbug.com/591099 fast/writing-mode/flipped-blocks-inline-map-local-to-container.html [ Failure ]
### external/wpt/html/rendering
crbug.com/591099 external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-vertical.html [ Failure ]
crbug.com/875235 external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order.html [ Failure ]
### virtual/text-antialias/
......@@ -439,9 +440,6 @@ virtual/controls-refresh-hc/* [ Skip ]
### virtual/layout_ng_block_frag/
virtual/layout_ng_block_frag/* [ Skip ]
### virtual/layout_ng_fieldset/
virtual/layout_ng_fieldset/* [ Skip ]
### virtual/layout_ng_fragment_traversal/
virtual/layout_ng_fragment_traversal/* [ Skip ]
......
......@@ -914,7 +914,6 @@ crbug.com/591099 [ Mac ] fast/multicol/file-upload-as-multicol.html [ Failure ]
# LayoutNG failures that needs to be triaged
crbug.com/591099 virtual/text-antialias/selection/selection-rect-line-height-too-small.html [ Failure ]
crbug.com/591099 external/wpt/css/css-text/hyphens/hyphens-out-of-flow-002.html [ Failure ]
crbug.com/591099 external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-vertical.html [ Failure ]
crbug.com/591099 fast/css-intrinsic-dimensions/width-avoid-floats.html [ Failure ]
crbug.com/591099 fast/selectors/shadow-host-div-with-span.html [ Failure ]
crbug.com/591099 fast/selectors/shadow-host-div-with-text.html [ Failure ]
......@@ -1296,9 +1295,13 @@ virtual/layout_ng_fragment_traversal/external/wpt/css/CSS2/text/* [ Skip ]
# Fieldset in NG
#
## Fieldseet in NG - Passing reference tests
crbug.com/875235 virtual/layout_ng_block_frag/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-vertical.html [ Pass ]
crbug.com/875235 virtual/layout_ng_fieldset/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-vertical.html [ Pass ]
# A simpified Layout issue
crbug.com/875235 external/wpt/inert/inert-retargeting-iframe.tentative.html [ Crash Pass ]
crbug.com/875235 external/wpt/inert/inert-retargeting.tentative.html [ Crash Pass ]
# Size containment
crbug.com/875235 external/wpt/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-014.html [ Failure ]
# Mask paiting area
crbug.com/875235 paint/masks/fieldset-mask.html [ Failure ]
# ====== LayoutNG-only failures until here ======
......
......@@ -253,14 +253,6 @@
"fast/table"],
"args": ["--enable-blink-features=LayoutNGFragmentTraversal"]
},
{
"prefix": "layout_ng_fieldset",
"bases": ["external/wpt/css/css-contain",
"external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain",
"external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements",
"fast/forms/fieldset"],
"args": ["--enable-blink-features=LayoutNGFieldset"]
},
{
"prefix": "layout-ng-grid",
"bases": ["fast/css-grid-layout",
......
This is a testharness.js-based test.
PASS div[align=left] legend
PASS div[align=center] legend
PASS div[align=right] legend
FAIL div[align=center] legend assert_equals: expected legend[align=left] expected 24 but got 394
FAIL div[align=right] legend assert_equals: expected legend[align=left] expected 24 but got 764
PASS div[align=justify] legend
FAIL div[style="text-align: center"] legend assert_equals: expected legend[align=left] expected 24 but got 394
FAIL div[style="text-align: center"][align=center] legend assert_equals: expected legend[align=left] expected 24 but got 394
......
This is a testharness.js-based test.
PASS div[align=left] legend
FAIL div[align=center] legend assert_equals: expected legend[align=left] expected 24 but got 394
FAIL div[align=right] legend assert_equals: expected legend[align=left] expected 24 but got 764
PASS div[align=center] legend
PASS div[align=right] legend
PASS div[align=justify] legend
FAIL div[style="text-align: center"] legend assert_equals: expected legend[align=left] expected 24 but got 394
FAIL div[style="text-align: center"][align=center] legend assert_equals: expected legend[align=left] expected 24 but got 394
......
This is a testharness.js-based test.
PASS div[align=left] legend
PASS div[align=center] legend
PASS div[align=right] legend
PASS div[align=justify] legend
FAIL div[style="text-align: center"] legend assert_equals: expected legend[align=left] expected 24 but got 394
FAIL div[style="text-align: center"][align=center] legend assert_equals: expected legend[align=left] expected 24 but got 394
PASS legend[style="margin: 0 auto"]
PASS legend[style="margin: 0 0 0 auto"]
PASS fieldset[dir=rtl] legend
FAIL fieldset[dir=rtl] legend[style="text-align: left"] assert_equals: expected legend[align=right] expected 764 but got 24
Harness: the test ran to completion.
This is a testharness.js-based test.
FAIL Flex assert_equals: height expected "18px" but got "162px"
FAIL Inline flex assert_equals: height expected "18px" but got "162px"
FAIL Dynamic change of flex-direction assert_equals: expected 44 but got 26
Harness: the test ran to completion.
This is a testharness.js-based test.
FAIL Grid assert_equals: height expected "86px" but got "162px"
FAIL Inline grid assert_equals: height expected "86px" but got "162px"
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS div[align=left] legend
FAIL div[align=center] legend assert_equals: expected legend[align=left] expected 24 but got 394
FAIL div[align=right] legend assert_equals: expected legend[align=left] expected 24 but got 764
PASS div[align=center] legend
PASS div[align=right] legend
PASS div[align=justify] legend
FAIL div[style="text-align: center"] legend assert_equals: expected legend[align=left] expected 24 but got 394
FAIL div[style="text-align: center"][align=center] legend assert_equals: expected legend[align=left] expected 24 but got 394
......
This is a testharness.js-based test.
FAIL Flex assert_equals: height expected "20px" but got "180px"
FAIL Inline flex assert_equals: height expected "20px" but got "180px"
FAIL Dynamic change of flex-direction assert_equals: expected 48 but got 28
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS div[align=left] legend
FAIL div[align=center] legend assert_equals: expected legend[align=left] expected 24 but got 395
FAIL div[align=right] legend assert_equals: expected legend[align=left] expected 24 but got 765
PASS div[align=center] legend
PASS div[align=right] legend
PASS div[align=justify] legend
FAIL div[style="text-align: center"] legend assert_equals: expected legend[align=left] expected 24 but got 395
FAIL div[style="text-align: center"][align=center] legend assert_equals: expected legend[align=left] expected 24 but got 395
......
This is a testharness.js-based test.
PASS div[align=left] legend
PASS div[align=center] legend
PASS div[align=right] legend
PASS div[align=justify] legend
FAIL div[style="text-align: center"] legend assert_equals: expected legend[align=left] expected 24 but got 395
FAIL div[style="text-align: center"][align=center] legend assert_equals: expected legend[align=left] expected 24 but got 395
PASS legend[style="margin: 0 auto"]
PASS legend[style="margin: 0 0 0 auto"]
PASS fieldset[dir=rtl] legend
FAIL fieldset[dir=rtl] legend[style="text-align: left"] assert_equals: expected legend[align=right] expected 765 but got 24
Harness: the test ran to completion.
These tests are run with --enable-blink-features=LayoutNGFieldset
The LayoutNG project is described here: http://goo.gl/1hwhfX
This is a testharness.js-based test.
PASS Flex
PASS Inline flex
PASS Dynamic change of flex-direction
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS rendered legend (writing-mode: horizontal-tb)
PASS second legend (writing-mode: horizontal-tb)
PASS div (writing-mode: horizontal-tb)
PASS rendered legend (writing-mode: vertical-lr)
PASS second legend (writing-mode: vertical-lr)
PASS div (writing-mode: vertical-lr)
PASS rendered legend (writing-mode: vertical-rl)
PASS second legend (writing-mode: vertical-rl)
PASS div (writing-mode: vertical-rl)
Harness: the test ran to completion.
These tests are run with --enable-blink-features=LayoutNGFieldset
The LayoutNG project is described here: http://goo.gl/1hwhfX
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment