[Profile menu] Remove obsolete user actions

This CL removes UMA user actions that have been replaced by a new
histogram since M79.

Bug: 995757
Change-Id: Iaeae4bd9125f68209a48f8a0c315eefb39b6b2b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247729
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780069}

chrome/browser/ui/views/profiles/profile_menu_view.cc

@@ -187,9 +187,6 @@ base::string16 ProfileMenuView::GetAccessibleWindowTitle() const {
 
 void ProfileMenuView::OnManageGoogleAccountButtonClicked() {
   RecordClick(ActionableItem::kManageGoogleAccountButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(
-      base::UserMetricsAction("ProfileChooser_ManageGoogleAccountClicked"));
 
   Profile* profile = browser()->profile();
   signin::IdentityManager* identity_manager =
@@ -205,32 +202,22 @@ void ProfileMenuView::OnManageGoogleAccountButtonClicked() {
 
 void ProfileMenuView::OnPasswordsButtonClicked() {
   RecordClick(ActionableItem::kPasswordsButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(
-      base::UserMetricsAction("ProfileChooser_PasswordsClicked"));
   NavigateToManagePasswordsPage(
       browser(), password_manager::ManagePasswordsReferrer::kProfileChooser);
 }
 
 void ProfileMenuView::OnCreditCardsButtonClicked() {
   RecordClick(ActionableItem::kCreditCardsButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(base::UserMetricsAction("ProfileChooser_PaymentsClicked"));
   chrome::ShowSettingsSubPage(browser(), chrome::kPaymentsSubPage);
 }
 
 void ProfileMenuView::OnAddressesButtonClicked() {
   RecordClick(ActionableItem::kAddressesButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(
-      base::UserMetricsAction("ProfileChooser_AddressesClicked"));
   chrome::ShowSettingsSubPage(browser(), chrome::kAddressesSubPage);
 }
 
 void ProfileMenuView::OnGuestProfileButtonClicked() {
   RecordClick(ActionableItem::kGuestProfileButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(base::UserMetricsAction("ProfileChooser_GuestClicked"));
   PrefService* service = g_browser_process->local_state();
   DCHECK(service);
   DCHECK(service->GetBoolean(prefs::kBrowserGuestModeEnabled));
@@ -239,8 +226,6 @@ void ProfileMenuView::OnGuestProfileButtonClicked() {
 
 void ProfileMenuView::OnExitProfileButtonClicked() {
   RecordClick(ActionableItem::kExitProfileButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(base::UserMetricsAction("ProfileChooser_CloseAllClicked"));
   profiles::CloseProfileWindows(browser()->profile());
 }
 
@@ -256,9 +241,6 @@ void ProfileMenuView::OnSyncErrorButtonClicked(
   chrome::AttemptUserExit();
 #else
   RecordClick(ActionableItem::kSyncErrorButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(
-      base::UserMetricsAction("ProfileChooser_SignInAgainClicked"));
   switch (error) {
     case sync_ui_util::MANAGED_USER_UNRECOVERABLE_ERROR:
       chrome::ShowSettingsSubPage(browser(), chrome::kSignOutSubPage);
@@ -319,8 +301,6 @@ void ProfileMenuView::OnSigninAccountButtonClicked(AccountInfo account) {
 #if !defined(OS_CHROMEOS)
 void ProfileMenuView::OnSignoutButtonClicked() {
   RecordClick(ActionableItem::kSignoutButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(base::UserMetricsAction("Signin_Signout_FromUserMenu"));
   Hide();
   // Sign out from all accounts.
   browser()->signin_view_controller()->ShowGaiaLogoutTab(
@@ -339,8 +319,6 @@ void ProfileMenuView::OnSigninButtonClicked() {
 void ProfileMenuView::OnOtherProfileSelected(
     const base::FilePath& profile_path) {
   RecordClick(ActionableItem::kOtherProfileButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(base::UserMetricsAction("ProfileChooser_ProfileClicked"));
   Hide();
   profiles::SwitchToProfile(profile_path, /*always_create=*/false,
                             ProfileManager::CreateCallback());
@@ -354,8 +332,6 @@ void ProfileMenuView::OnAddNewProfileButtonClicked() {
 
 void ProfileMenuView::OnManageProfilesButtonClicked() {
   RecordClick(ActionableItem::kManageProfilesButton);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(base::UserMetricsAction("ProfileChooser_ManageClicked"));
   UserManager::Show(base::FilePath(),
                     profiles::USER_MANAGER_SELECT_PROFILE_NO_ACTION);
 }
@@ -368,9 +344,6 @@ void ProfileMenuView::OnEditProfileButtonClicked() {
 
 void ProfileMenuView::OnCookiesClearedOnExitLinkClicked() {
   RecordClick(ActionableItem::kCookiesClearedOnExitLink);
-  // TODO(crbug.com/995757): Remove user action.
-  base::RecordAction(
-      base::UserMetricsAction("ProfileChooser_CookieSettingsClicked"));
   chrome::ShowSettingsSubPage(browser(), chrome::kContentSettingsSubPage +
                                              std::string("/") +
                                              chrome::kCookieSettingsSubPage);

tools/metrics/actions/actions.xml

@@ -18894,6 +18894,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_AddressesClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>vasilii@chromium.org</owner>
   <owner>ewald@chromium.org</owner>
   <description>
@@ -18902,6 +18903,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_CloseAllClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>vasilii@chromium.org</owner>
   <owner>ewald@chromium.org</owner>
   <description>
@@ -18910,6 +18912,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_CookieSettingsClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>msalama@chromium.org</owner>
   <description>
     User clicked on settings from the user menu prompted message to go to cookie
@@ -18919,6 +18922,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_GuestClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>vasilii@chromium.org</owner>
   <owner>ewald@chromium.org</owner>
   <description>
@@ -18927,6 +18931,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_ManageClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>vasilii@chromium.org</owner>
   <owner>ewald@chromium.org</owner>
   <description>
@@ -18935,6 +18940,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_ManageGoogleAccountClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>droger@chromium.org</owner>
   <owner>msarda@chromium.org</owner>
   <owner>tangltom@chromium.org</owner>
@@ -18944,6 +18950,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_PasswordsClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>vasilii@chromium.org</owner>
   <owner>ewald@chromium.org</owner>
   <description>
@@ -18952,6 +18959,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_PaymentsClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>vasilii@chromium.org</owner>
   <owner>ewald@chromium.org</owner>
   <description>
@@ -18960,6 +18968,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_ProfileClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>vasilii@chromium.org</owner>
   <owner>ewald@chromium.org</owner>
   <description>
@@ -18975,6 +18984,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="ProfileChooser_SignInAgainClicked">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>vasilii@chromium.org</owner>
   <owner>ewald@chromium.org</owner>
   <description>
@@ -21991,6 +22001,7 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="Signin_Signout_FromUserMenu">
+  <obsolete>Removed since M85, replaced by a histogram.</obsolete>
   <owner>droger@chromium.org</owner>
   <owner>msarda@chromium.org</owner>
   <owner>tangltom@chromium.org</owner>