Commit 97100c4b authored by Yann Dago's avatar Yann Dago Committed by Commit Bot

Remove policy atomic groups logic

Bug: 989734
Change-Id: I0c9a6c29bf504838595cddf3109870130fa12881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731171Reviewed-by: default avatarOwen Min <zmin@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683305}
parent 55bd467b
...@@ -230,11 +230,9 @@ void PolicyServiceImpl::MergeAndTriggerUpdates() { ...@@ -230,11 +230,9 @@ void PolicyServiceImpl::MergeAndTriggerUpdates() {
PolicyListMerger policy_list_merger(std::move(policy_lists_to_merge)); PolicyListMerger policy_list_merger(std::move(policy_lists_to_merge));
PolicyDictionaryMerger policy_dictionary_merger( PolicyDictionaryMerger policy_dictionary_merger(
std::move(policy_dictionaries_to_merge)); std::move(policy_dictionaries_to_merge));
PolicyGroupMerger policy_group_merger;
for (auto it = bundle.begin(); it != bundle.end(); ++it) { for (auto it = bundle.begin(); it != bundle.end(); ++it) {
it->second->MergeValues( it->second->MergeValues({&policy_list_merger, &policy_dictionary_merger});
{&policy_list_merger, &policy_dictionary_merger, &policy_group_merger});
} }
// Swap first, so that observers that call GetPolicies() see the current // Swap first, so that observers that call GetPolicies() see the current
......
...@@ -904,7 +904,6 @@ TEST_F(PolicyServiceTest, GroupPoliciesMerging) { ...@@ -904,7 +904,6 @@ TEST_F(PolicyServiceTest, GroupPoliciesMerging) {
merged.AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); merged.AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE);
expected_chrome.Set(key::kExtensionInstallForcelist, merged.DeepCopy()); expected_chrome.Set(key::kExtensionInstallForcelist, merged.DeepCopy());
expected_chrome.Set(key::kExtensionInstallBlacklist, std::move(merged)); expected_chrome.Set(key::kExtensionInstallBlacklist, std::move(merged));
entry_list_3.SetIgnoredByPolicyAtomicGroup();
expected_chrome.Set(key::kExtensionInstallWhitelist, std::move(entry_list_3)); expected_chrome.Set(key::kExtensionInstallWhitelist, std::move(entry_list_3));
provider0_.UpdatePolicy(std::move(policy_bundle1)); provider0_.UpdatePolicy(std::move(policy_bundle1));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment