Commit 9713eebc authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

[ios] Shard ios_chrome_bookmarks_egtests.

This test is getting close to 30 minutes.  There are 6 test cases, so sharding
it to 2 tests cases per will use 3 machines, and bring test runs closer to ten minutes.

This also renames the test cases to end in TestCase, which is how sharding does it's
math.

Change-Id: I7c4f58e89534b1d526fbfc026cbecb76c61a745e
Reviewed-on: https://chromium-review.googlesource.com/c/1331130Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Reviewed-by: default avataredchin <edchin@chromium.org>
Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607378}
parent dc307fcb
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
"tests": [ "tests": [
{ {
"app": "ios_chrome_bookmarks_egtests", "app": "ios_chrome_bookmarks_egtests",
"shard size": 2,
"xctest": true "xctest": true
}, },
{ {
......
...@@ -1694,10 +1694,10 @@ id<GREYMatcher> SearchIconButton() { ...@@ -1694,10 +1694,10 @@ id<GREYMatcher> SearchIconButton() {
@end @end
// Bookmark entries integration tests for Chrome. // Bookmark entries integration tests for Chrome.
@interface BookmarksTestCaseEntries : ChromeTestCase @interface BookmarksEntriesTestCase : ChromeTestCase
@end @end
@implementation BookmarksTestCaseEntries @implementation BookmarksEntriesTestCase
- (void)setUp { - (void)setUp {
[super setUp]; [super setUp];
...@@ -1720,7 +1720,7 @@ id<GREYMatcher> SearchIconButton() { ...@@ -1720,7 +1720,7 @@ id<GREYMatcher> SearchIconButton() {
clearBookmarkTopMostRowCacheWithPrefService:browser_state->GetPrefs()]; clearBookmarkTopMostRowCacheWithPrefService:browser_state->GetPrefs()];
} }
#pragma mark - BookmarksTestCaseEntries Tests #pragma mark - BookmarksEntriesTestCase Tests
- (void)testUndoDeleteBookmarkFromSwipe { - (void)testUndoDeleteBookmarkFromSwipe {
// TODO(crbug.com/851227): On Compact Width on iOS11, the // TODO(crbug.com/851227): On Compact Width on iOS11, the
...@@ -2705,10 +2705,10 @@ id<GREYMatcher> SearchIconButton() { ...@@ -2705,10 +2705,10 @@ id<GREYMatcher> SearchIconButton() {
@end @end
// Bookmark promo integration tests for Chrome. // Bookmark promo integration tests for Chrome.
@interface BookmarksTestCasePromo : ChromeTestCase @interface BookmarksPromoTestCase : ChromeTestCase
@end @end
@implementation BookmarksTestCasePromo @implementation BookmarksPromoTestCase
- (void)setUp { - (void)setUp {
[super setUp]; [super setUp];
...@@ -2731,7 +2731,7 @@ id<GREYMatcher> SearchIconButton() { ...@@ -2731,7 +2731,7 @@ id<GREYMatcher> SearchIconButton() {
clearBookmarkTopMostRowCacheWithPrefService:browser_state->GetPrefs()]; clearBookmarkTopMostRowCacheWithPrefService:browser_state->GetPrefs()];
} }
#pragma mark - BookmarksTestCasePromo Tests #pragma mark - BookmarksPromoTestCase Tests
// Tests that the promo view is only seen at root level and not in any of the // Tests that the promo view is only seen at root level and not in any of the
// child nodes. // child nodes.
...@@ -2919,10 +2919,10 @@ id<GREYMatcher> SearchIconButton() { ...@@ -2919,10 +2919,10 @@ id<GREYMatcher> SearchIconButton() {
@end @end
// Bookmark accessibility tests for Chrome. // Bookmark accessibility tests for Chrome.
@interface BookmarksTestCaseAccessibility : ChromeTestCase @interface BookmarksAccessibilityTestCase : ChromeTestCase
@end @end
@implementation BookmarksTestCaseAccessibility @implementation BookmarksAccessibilityTestCase
- (void)setUp { - (void)setUp {
[super setUp]; [super setUp];
...@@ -2945,7 +2945,7 @@ id<GREYMatcher> SearchIconButton() { ...@@ -2945,7 +2945,7 @@ id<GREYMatcher> SearchIconButton() {
clearBookmarkTopMostRowCacheWithPrefService:browser_state->GetPrefs()]; clearBookmarkTopMostRowCacheWithPrefService:browser_state->GetPrefs()];
} }
#pragma mark - BookmarksTestCaseAccessibility Tests #pragma mark - BookmarksAccessibilityTestCase Tests
// Tests that all elements on the bookmarks landing page are accessible. // Tests that all elements on the bookmarks landing page are accessible.
- (void)testAccessibilityOnBookmarksLandingPage { - (void)testAccessibilityOnBookmarksLandingPage {
...@@ -3095,10 +3095,10 @@ id<GREYMatcher> SearchIconButton() { ...@@ -3095,10 +3095,10 @@ id<GREYMatcher> SearchIconButton() {
@end @end
// Bookmark folders integration tests for Chrome. // Bookmark folders integration tests for Chrome.
@interface BookmarksTestCaseFolders : ChromeTestCase @interface BookmarksFoldersTestCase : ChromeTestCase
@end @end
@implementation BookmarksTestCaseFolders @implementation BookmarksFoldersTestCase
- (void)setUp { - (void)setUp {
[super setUp]; [super setUp];
...@@ -4036,10 +4036,10 @@ id<GREYMatcher> SearchIconButton() { ...@@ -4036,10 +4036,10 @@ id<GREYMatcher> SearchIconButton() {
@end @end
// Bookmark search integration tests for Chrome. // Bookmark search integration tests for Chrome.
@interface BookmarksTestCaseSearch : ChromeTestCase @interface BookmarksSearchTestCase : ChromeTestCase
@end @end
@implementation BookmarksTestCaseSearch @implementation BookmarksSearchTestCase
- (void)setUp { - (void)setUp {
[super setUp]; [super setUp];
...@@ -4062,7 +4062,7 @@ id<GREYMatcher> SearchIconButton() { ...@@ -4062,7 +4062,7 @@ id<GREYMatcher> SearchIconButton() {
clearBookmarkTopMostRowCacheWithPrefService:browser_state->GetPrefs()]; clearBookmarkTopMostRowCacheWithPrefService:browser_state->GetPrefs()];
} }
#pragma mark - BookmarksTestCaseSearch Tests #pragma mark - BookmarksSearchTestCase Tests
// Tests that the search bar is shown on root. // Tests that the search bar is shown on root.
- (void)testSearchBarShownOnRoot { - (void)testSearchBarShownOnRoot {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment