Commit 97155b18 authored by Daniel Cheng's avatar Daniel Cheng Committed by Commit Bot

blink::MouseEventManager: remove use of legacy BooleanHistogram helper.

Bug: 1047547
Change-Id: I9632a961521ac6818e67662b13d7e24ea320c977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494510
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820436}
parent 9d0769a3
...@@ -46,7 +46,6 @@ ...@@ -46,7 +46,6 @@
#include "third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h" #include "third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h"
#include "third_party/blink/renderer/core/svg/svg_document_extensions.h" #include "third_party/blink/renderer/core/svg/svg_document_extensions.h"
#include "third_party/blink/renderer/platform/geometry/float_quad.h" #include "third_party/blink/renderer/platform/geometry/float_quad.h"
#include "third_party/blink/renderer/platform/instrumentation/histogram.h"
namespace blink { namespace blink {
...@@ -403,19 +402,15 @@ WebInputEventResult MouseEventManager::DispatchMouseClickIfNeeded( ...@@ -403,19 +402,15 @@ WebInputEventResult MouseEventManager::DispatchMouseClickIfNeeded(
UMA_HISTOGRAM_BOOLEAN("Event.ClickTargetChangedDueToInteractiveElement", UMA_HISTOGRAM_BOOLEAN("Event.ClickTargetChangedDueToInteractiveElement",
click_target_node != old_click_target_node); click_target_node != old_click_target_node);
DEFINE_STATIC_LOCAL(BooleanHistogram, histogram, const bool click_element_still_in_flat_tree =
("Event.ClickNotFiredDueToDomManipulation")); (click_element_ && click_element_->CanParticipateInFlatTree() &&
click_element_->isConnected());
UMA_HISTOGRAM_BOOLEAN("Event.ClickNotFiredDueToDomManipulation",
!click_element_still_in_flat_tree);
DCHECK_EQ(click_element_ == mouse_down_element_,
click_element_still_in_flat_tree);
if (click_element_ && click_element_->CanParticipateInFlatTree() && if (click_element_still_in_flat_tree ||
click_element_->isConnected()) {
DCHECK(click_element_ == mouse_down_element_);
histogram.Count(false);
} else {
histogram.Count(true);
}
if ((click_element_ && click_element_->CanParticipateInFlatTree() &&
click_element_->isConnected()) ||
RuntimeEnabledFeatures::ClickRetargettingEnabled()) { RuntimeEnabledFeatures::ClickRetargettingEnabled()) {
return DispatchMouseEvent( return DispatchMouseEvent(
click_target_node, click_target_node,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment