Skip to content

GitLab

T
tangled
Commit 972d9df7 authored by Wez's avatar Wez Committed by Commit Bot
Browse files
Options

Disable WorkerThreadRegistry tests on all platforms. 

The WorkerThreadRegistry and its tests make invalid assumptions about
PlatformThreadId values, leading these tests to flake, particularly on
64-bit platforms which do not recycle kernel object identifiers.

TBR=falken@chromium.org

Bug: 969562, 970088
Change-Id: I19fa473e08a7cec301944adc577c0df88ffab6a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640809Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665796}
parent fade7366
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 15 deletions
content/renderer/worker/worker_thread_registry_unittest.cc
View file @ 972d9df7
...@@ -34,13 +34,8 @@ class MockObserver : public WorkerThread::Observer { ...@@ -34,13 +34,8 @@ class MockObserver : public WorkerThread::Observer {
WorkerThreadRegistry* runner_; WorkerThreadRegistry* runner_;
}; };
// TODO(https://crbug.com/969562): Fix flaky failure on Fuschia. // TODO(https://crbug.com/969562): Flakes on some systems due to thread ids.
#if defined(OS_FUCHSIA) TEST_F(WorkerThreadRegistryTest, DISABLED_BasicObservingAndWorkerId) {
#define MAYBE_BasicObservingAndWorkerId DISABLED_BasicObservingAndWorkerId
#else
#define MAYBE_BasicObservingAndWorkerId BasicObservingAndWorkerId
#endif
TEST_F(WorkerThreadRegistryTest, MAYBE_BasicObservingAndWorkerId) {
ASSERT_EQ(0, WorkerThread::GetCurrentId()); ASSERT_EQ(0, WorkerThread::GetCurrentId());
MockObserver o; MockObserver o;
EXPECT_CALL(o, WillStopCurrentWorkerThread()).Times(1); EXPECT_CALL(o, WillStopCurrentWorkerThread()).Times(1);
...@@ -50,7 +45,8 @@ TEST_F(WorkerThreadRegistryTest, MAYBE_BasicObservingAndWorkerId) { ...@@ -50,7 +45,8 @@ TEST_F(WorkerThreadRegistryTest, MAYBE_BasicObservingAndWorkerId) {
FakeStop(); FakeStop();
} }
TEST_F(WorkerThreadRegistryTest, CanRemoveSelfDuringNotification) { // TODO(https://crbug.com/969562): Flakes on some systems due to thread ids.
TEST_F(WorkerThreadRegistryTest, DISABLED_CanRemoveSelfDuringNotification) {
MockObserver o; MockObserver o;
o.RemoveSelfOnNotify(); o.RemoveSelfOnNotify();
o.runner_ = &task_runner_; o.runner_ = &task_runner_;
...@@ -60,13 +56,8 @@ TEST_F(WorkerThreadRegistryTest, CanRemoveSelfDuringNotification) { ...@@ -60,13 +56,8 @@ TEST_F(WorkerThreadRegistryTest, CanRemoveSelfDuringNotification) {
FakeStop(); FakeStop();
} }
// TODO(https://crbug.com/969562): Fix flaky failure on Fuschia. // TODO(https://crbug.com/969562): Flakes on some systems due to thread ids.
#if defined(OS_FUCHSIA) TEST_F(WorkerThreadRegistryTest, DISABLED_TaskRunnerRemovedCorrectly) {
#define MAYBE_TaskRunnerRemovedCorrectly DISABLED_TaskRunnerRemovedCorrectly
#else
#define MAYBE_TaskRunnerRemovedCorrectly TaskRunnerRemovedCorrectly
#endif
TEST_F(WorkerThreadRegistryTest, MAYBE_TaskRunnerRemovedCorrectly) {
ASSERT_EQ(0, WorkerThread::GetCurrentId()); ASSERT_EQ(0, WorkerThread::GetCurrentId());
MockObserver o; MockObserver o;
FakeStart(); FakeStart();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment