Commit 973147e5 authored by Thoren Paulson's avatar Thoren Paulson Committed by Commit Bot

[Chromecast] Add <uses-sdk/> tag to Cast Shell manifest.

Without it, the manifest merger assumes we're using a library that
targets SDK version 1 and adds some permissions we don't need.

Bug: None
Test: check manifest from CastShellInternal.apk
Change-Id: I98b4597a21e94e5c2d920943df4fd26bf97a556c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909641Reviewed-by: default avatarLuke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: default avatarSimeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Auto-Submit: Thoren Paulson <thoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714558}
parent 7e92a9b6
...@@ -659,6 +659,9 @@ if (is_android) { ...@@ -659,6 +659,9 @@ if (is_android) {
android_manifest = "$root_gen_dir/cast_shell_manifest/AndroidManifest.xml" android_manifest = "$root_gen_dir/cast_shell_manifest/AndroidManifest.xml"
android_manifest_dep = "//chromecast/browser/android:cast_shell_manifest" android_manifest_dep = "//chromecast/browser/android:cast_shell_manifest"
min_sdk_version = 21
target_sdk_version = 28
shared_libraries = [ "//chromecast/android:libcast_shell_android" ] shared_libraries = [ "//chromecast/android:libcast_shell_android" ]
product_config_java_packages = [ "org.chromium.chromecast.shell" ] product_config_java_packages = [ "org.chromium.chromecast.shell" ]
......
...@@ -8,6 +8,8 @@ ...@@ -8,6 +8,8 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android" <manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="org.chromium.chromecast.shell"> package="org.chromium.chromecast.shell">
<uses-sdk android:minSdkVersion="21" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/> <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-permission android:name="android.permission.INTERNET"/> <uses-permission android:name="android.permission.INTERNET"/>
<uses-permission android:name="android.permission.WAKE_LOCK"/> <uses-permission android:name="android.permission.WAKE_LOCK"/>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment