Commit 97461ea2 authored by Robert Sesek's avatar Robert Sesek Committed by Commit Bot

crash_keys: Remove old "bad_histogram" key.

Bug: 598854
Change-Id: I380ef1cb8bf2de2a72d52091b619b374b4dc3c33
Reviewed-on: https://chromium-review.googlesource.com/804338
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521231}
parent 9359982d
...@@ -19,7 +19,6 @@ ...@@ -19,7 +19,6 @@
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "base/debug/alias.h" #include "base/debug/alias.h"
#include "base/debug/crash_logging.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
...@@ -575,9 +574,6 @@ bool Histogram::ValidateHistogramContents(bool crash_if_invalid, ...@@ -575,9 +574,6 @@ bool Histogram::ValidateHistogramContents(bool crash_if_invalid,
// Abort if a problem is found (except "flags", which could legally be zero). // Abort if a problem is found (except "flags", which could legally be zero).
std::string debug_string = base::StringPrintf( std::string debug_string = base::StringPrintf(
"%s/%" PRIu32 "#%d", histogram_name(), bad_fields, identifier); "%s/%" PRIu32 "#%d", histogram_name(), bad_fields, identifier);
#if !defined(OS_NACL)
base::debug::ScopedCrashKey crash_key("bad_histogram", debug_string);
#endif
CHECK(false) << debug_string; CHECK(false) << debug_string;
debug::Alias(&bad_fields); debug::Alias(&bad_fields);
return false; return false;
......
...@@ -154,9 +154,6 @@ size_t RegisterCrashKeysHelper() { ...@@ -154,9 +154,6 @@ size_t RegisterCrashKeysHelper() {
// TODO(sunnyps): Remove after fixing crbug.com/724999. // TODO(sunnyps): Remove after fixing crbug.com/724999.
{"gl-context-set-current-stack-trace", kMediumSize}, {"gl-context-set-current-stack-trace", kMediumSize},
// TODO(asvitkine): Remove after fixing https://crbug.com/736675
{"bad_histogram", kMediumSize},
// Accessibility keys. Temporary for http://crbug.com/765490. // Accessibility keys. Temporary for http://crbug.com/765490.
{"ax_tree_error", kSmallSize}, {"ax_tree_error", kSmallSize},
{"ax_tree_update", kMediumSize}, {"ax_tree_update", kMediumSize},
......
...@@ -190,9 +190,6 @@ size_t RegisterChromeCrashKeys() { ...@@ -190,9 +190,6 @@ size_t RegisterChromeCrashKeys() {
// TODO(sunnyps): Remove after fixing crbug.com/724999. // TODO(sunnyps): Remove after fixing crbug.com/724999.
{"gl-context-set-current-stack-trace", kMediumSize}, {"gl-context-set-current-stack-trace", kMediumSize},
// TODO(asvitkine): Remove after fixing https://crbug.com/736675
{"bad_histogram", kMediumSize},
// Accessibility keys. Temporary for http://crbug.com/765490. // Accessibility keys. Temporary for http://crbug.com/765490.
{"ax_tree_error", kSmallSize}, {"ax_tree_error", kSmallSize},
{"ax_tree_update", kMediumSize}, {"ax_tree_update", kMediumSize},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment