[iOS] Don't show hostname for main frame JavaScript dialogs.

When dialogs are displayed from the main frame, the requesting page's
URL is already visible in the location bar, so we don't need to add
source information as the title.  The message text is used instead.

Bug: 999966
Change-Id: I6ea4f5286c2626055e0350f5746fe8968dde1dd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785013
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696960}

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/BUILD.gn

@@ -9,6 +9,7 @@ source_set("common") {
     "java_script_dialog_overlay_coordinator+subclassing.h",
     "java_script_dialog_overlay_coordinator.h",
     "java_script_dialog_overlay_coordinator.mm",
+    "java_script_dialog_overlay_mediator+subclassing.h",
     "java_script_dialog_overlay_mediator.h",
     "java_script_dialog_overlay_mediator.mm",
   ]

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_alert_overlay_mediator.mm

@@ -11,6 +11,7 @@
 #import "ios/chrome/browser/ui/alert_view_controller/alert_action.h"
 #import "ios/chrome/browser/ui/alert_view_controller/alert_consumer.h"
 #import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_blocking_action.h"
+#import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator+subclassing.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ -27,10 +28,6 @@
 
 #pragma mark - Accessors
 
-- (const JavaScriptDialogSource*)requestSource {
-  return &self.config->source();
-}
-
 - (JavaScriptAlertOverlayRequestConfig*)config {
   return self.request->GetConfig<JavaScriptAlertOverlayRequestConfig>();
 }
@@ -39,7 +36,6 @@
   if (self.consumer == consumer)
     return;
   [super setConsumer:consumer];
-  [self.consumer setMessage:base::SysUTF8ToNSString(self.config->message())];
   __weak __typeof__(self) weakSelf = self;
   NSMutableArray* actions = [@[ [AlertAction
       actionWithTitle:l10n_util::GetNSString(IDS_OK)
@@ -54,3 +50,15 @@
 }
 
 @end
+
+@implementation JavaScriptAlertOverlayMediator (Subclassing)
+
+- (const JavaScriptDialogSource&)requestSource {
+  return self.config->source();
+}
+
+- (const std::string&)requestMessage {
+  return self.config->message();
+}
+
+@end

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_alert_overlay_mediator_unittest.mm

@@ -25,8 +25,9 @@
 
 using JavaScriptAlertOverlayMediatorTest = JavaScriptDialogOverlayMediatorTest;
 
-// Tests that the consumer values are set correctly for alerts.
-TEST_F(JavaScriptAlertOverlayMediatorTest, AlertSetup) {
+// Tests that the consumer values are set correctly for alerts from the main
+// frame.
+TEST_F(JavaScriptAlertOverlayMediatorTest, AlertSetupMainFrame) {
   web::TestWebState web_state;
   const GURL kUrl("https://chromium.test");
   const std::string kMessage("Message");
@@ -37,6 +38,26 @@ TEST_F(JavaScriptAlertOverlayMediatorTest, AlertSetup) {
   SetMediator(
       [[JavaScriptAlertOverlayMediator alloc] initWithRequest:request.get()]);
 
+  // Verify the consumer values.
+  EXPECT_NSEQ(base::SysUTF8ToNSString(kMessage), consumer().title);
+  EXPECT_EQ(0U, consumer().textFieldConfigurations.count);
+  ASSERT_EQ(1U, consumer().actions.count);
+  EXPECT_EQ(UIAlertActionStyleDefault, consumer().actions[0].style);
+  EXPECT_NSEQ(l10n_util::GetNSString(IDS_OK), consumer().actions[0].title);
+}
+
+// Tests that the consumer values are set correctly for alerts from an iframe.
+TEST_F(JavaScriptAlertOverlayMediatorTest, AlertSetupIFrame) {
+  web::TestWebState web_state;
+  const GURL kUrl("https://chromium.test");
+  const std::string kMessage("Message");
+  std::unique_ptr<OverlayRequest> request =
+      OverlayRequest::CreateWithConfig<JavaScriptAlertOverlayRequestConfig>(
+          JavaScriptDialogSource(&web_state, kUrl, /*is_main_frame=*/false),
+          kMessage);
+  SetMediator(
+      [[JavaScriptAlertOverlayMediator alloc] initWithRequest:request.get()]);
+
   // Verify the consumer values.
   EXPECT_NSEQ(base::SysUTF8ToNSString(kMessage), consumer().message);
   EXPECT_EQ(0U, consumer().textFieldConfigurations.count);
@@ -63,7 +84,7 @@ TEST_F(JavaScriptAlertOverlayMediatorTest, AlertSetupWithBlockingOption) {
       [[JavaScriptAlertOverlayMediator alloc] initWithRequest:request.get()]);
 
   // Verify the consumer values.
-  EXPECT_NSEQ(base::SysUTF8ToNSString(kMessage), consumer().message);
+  EXPECT_NSEQ(base::SysUTF8ToNSString(kMessage), consumer().title);
   EXPECT_EQ(0U, consumer().textFieldConfigurations.count);
   ASSERT_EQ(2U, consumer().actions.count);
   EXPECT_EQ(UIAlertActionStyleDefault, consumer().actions[0].style);

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_confirmation_overlay_mediator.mm

@@ -12,6 +12,7 @@
 #import "ios/chrome/browser/ui/alert_view_controller/alert_action.h"
 #import "ios/chrome/browser/ui/alert_view_controller/alert_consumer.h"
 #import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_blocking_action.h"
+#import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator+subclassing.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ -29,10 +30,6 @@
 
 #pragma mark - Accessors
 
-- (const JavaScriptDialogSource*)requestSource {
-  return &self.config->source();
-}
-
 - (JavaScriptConfirmationOverlayRequestConfig*)config {
   return self.request->GetConfig<JavaScriptConfirmationOverlayRequestConfig>();
 }
@@ -41,7 +38,6 @@
   if (self.consumer == consumer)
     return;
   [super setConsumer:consumer];
-  [self.consumer setMessage:base::SysUTF8ToNSString(self.config->message())];
   __weak __typeof__(self) weakSelf = self;
   NSMutableArray* actions = [@[
     [AlertAction actionWithTitle:l10n_util::GetNSString(IDS_OK)
@@ -77,3 +73,15 @@
 }
 
 @end
+
+@implementation JavaScriptConfirmationOverlayMediator (Subclassing)
+
+- (const JavaScriptDialogSource&)requestSource {
+  return self.config->source();
+}
+
+- (const std::string&)requestMessage {
+  return self.config->message();
+}
+
+@end

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_confirmation_overlay_mediator_unittest.mm

@@ -33,11 +33,10 @@ class JavaScriptConfirmationOverlayMediatorTest
   }
 
   // Creates a mediator and sets it for testing.
-  void CreateMediator() {
+  void CreateMediator(bool is_main_frame = true) {
     request_ = OverlayRequest::CreateWithConfig<
         JavaScriptConfirmationOverlayRequestConfig>(
-        JavaScriptDialogSource(&web_state_, url_, /*is_main_frame=*/true),
-        message_);
+        JavaScriptDialogSource(&web_state_, url_, is_main_frame), message_);
     SetMediator([[JavaScriptConfirmationOverlayMediator alloc]
         initWithRequest:request_.get()]);
   }
@@ -56,10 +55,26 @@ class JavaScriptConfirmationOverlayMediatorTest
   std::unique_ptr<OverlayRequest> request_;
 };
 
-// Tests that the consumer values are set correctly for confirmations.
-TEST_F(JavaScriptConfirmationOverlayMediatorTest, ConfirmationSetup) {
+// Tests that the consumer values are set correctly for confirmations from the
+// main frame.
+TEST_F(JavaScriptConfirmationOverlayMediatorTest, ConfirmationSetupMainFrame) {
   CreateMediator();
 
+  // Verify the consumer values.
+  EXPECT_NSEQ(base::SysUTF8ToNSString(message()), consumer().title);
+  EXPECT_EQ(0U, consumer().textFieldConfigurations.count);
+  ASSERT_EQ(2U, consumer().actions.count);
+  EXPECT_EQ(UIAlertActionStyleDefault, consumer().actions[0].style);
+  EXPECT_NSEQ(l10n_util::GetNSString(IDS_OK), consumer().actions[0].title);
+  EXPECT_EQ(UIAlertActionStyleCancel, consumer().actions[1].style);
+  EXPECT_NSEQ(l10n_util::GetNSString(IDS_CANCEL), consumer().actions[1].title);
+}
+
+// Tests that the consumer values are set correctly for confirmations from
+// iframes.
+TEST_F(JavaScriptConfirmationOverlayMediatorTest, ConfirmationSetupIFrame) {
+  CreateMediator(/*is_main_frame=*/false);
+
   // Verify the consumer values.
   EXPECT_NSEQ(base::SysUTF8ToNSString(message()), consumer().message);
   EXPECT_EQ(0U, consumer().textFieldConfigurations.count);
@@ -78,7 +93,7 @@ TEST_F(JavaScriptConfirmationOverlayMediatorTest,
   CreateMediator();
 
   // Verify the consumer values.
-  EXPECT_NSEQ(base::SysUTF8ToNSString(message()), consumer().message);
+  EXPECT_NSEQ(base::SysUTF8ToNSString(message()), consumer().title);
   EXPECT_EQ(0U, consumer().textFieldConfigurations.count);
   ASSERT_EQ(3U, consumer().actions.count);
   EXPECT_EQ(UIAlertActionStyleDefault, consumer().actions[0].style);

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_blocking_action.mm

@@ -7,6 +7,7 @@
 #include "base/logging.h"
 #include "ios/chrome/browser/overlays/public/web_content_area/java_script_dialog_source.h"
 #import "ios/chrome/browser/ui/dialogs/java_script_dialog_blocking_state.h"
+#import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator+subclassing.h"
 #import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ui/base/l10n/l10n_util.h"
@@ -19,8 +20,8 @@ namespace {
 // Returns the blocking state for |source|'s WebState, or nullptr if the
 // WebState was destroyed.
 JavaScriptDialogBlockingState* GetBlockingState(
-    const JavaScriptDialogSource* source) {
-  web::WebState* web_state = source->web_state();
+    const JavaScriptDialogSource& source) {
+  web::WebState* web_state = source.web_state();
   if (!web_state)
     return nullptr;
   JavaScriptDialogBlockingState::CreateForWebState(web_state);
@@ -29,7 +30,7 @@ JavaScriptDialogBlockingState* GetBlockingState(
 }  // namespace
 
 AlertAction* GetBlockingAlertAction(JavaScriptDialogOverlayMediator* mediator) {
-  const JavaScriptDialogSource* source = mediator.requestSource;
+  const JavaScriptDialogSource& source = mediator.requestSource;
   JavaScriptDialogBlockingState* blocking_state = GetBlockingState(source);
   if (!blocking_state || !blocking_state->show_blocking_option())
     return nil;

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator+subclassing.h

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_OVERLAYS_WEB_CONTENT_AREA_JAVA_SCRIPT_DIALOGS_JAVA_SCRIPT_DIALOG_OVERLAY_MEDIATOR_SUBCLASSING_H_
+#define IOS_CHROME_BROWSER_UI_OVERLAYS_WEB_CONTENT_AREA_JAVA_SCRIPT_DIALOGS_JAVA_SCRIPT_DIALOG_OVERLAY_MEDIATOR_SUBCLASSING_H_
+
+#import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator.h"
+
+class JavaScriptDialogSource;
+
+// Category used by JavaScriptDialogOverlayMediator subclasses to provide
+// information from their OverlayRequests.
+@interface JavaScriptDialogOverlayMediator (Subclassing)
+
+// Returns the source for the OverlayRequest.
+@property(nonatomic, readonly) const JavaScriptDialogSource& requestSource;
+
+// Returns the message for the OverlayRequest.
+@property(nonatomic, readonly) const std::string& requestMessage;
+
+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_OVERLAYS_WEB_CONTENT_AREA_JAVA_SCRIPT_DIALOGS_JAVA_SCRIPT_DIALOG_OVERLAY_MEDIATOR_SUBCLASSING_H_

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator.h

@@ -8,7 +8,6 @@
 #import <Foundation/Foundation.h>
 
 class OverlayRequest;
-class JavaScriptDialogSource;
 @protocol AlertConsumer;
 @protocol JavaScriptDialogOverlayMediatorDelegate;
 
@@ -19,9 +18,6 @@ class JavaScriptDialogSource;
 // The request passed on initialization.
 @property(nonatomic, readonly) OverlayRequest* request;
 
-// Returns the source for the OverlayRequest.
-@property(nonatomic, readonly) const JavaScriptDialogSource* requestSource;
-
 // The consumer to be updated by this mediator.  Setting to a new value uses the
 // configuration data in |request| to update the new consumer.
 @property(nonatomic, weak) id<AlertConsumer> consumer;

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator.mm

@@ -5,10 +5,12 @@
 #import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator.h"
 
 #include "base/logging.h"
+#import "base/strings/sys_string_conversions.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/url_formatter/elide_url.h"
 #include "ios/chrome/browser/overlays/public/web_content_area/java_script_dialog_source.h"
 #import "ios/chrome/browser/ui/alert_view_controller/alert_consumer.h"
+#import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator+subclassing.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ -28,11 +30,6 @@
 
 #pragma mark - Accessors
 
-- (const JavaScriptDialogSource*)requestSource {
-  NOTREACHED() << "Subclasses must implement.";
-  return nullptr;
-}
-
 - (void)setConsumer:(id<AlertConsumer>)consumer {
   if (_consumer == consumer)
     return;
@@ -40,18 +37,18 @@
 
   if (!_consumer)
     return;
-  const JavaScriptDialogSource* source = self.requestSource;
-  NSString* consumerTitle = nil;
-  if (source->is_main_frame()) {
-    base::string16 title = url_formatter::FormatUrlForSecurityDisplay(
-        source->url(), url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS);
-    consumerTitle =
-        l10n_util::GetNSStringF(IDS_JAVASCRIPT_MESSAGEBOX_TITLE, title);
+  NSString* requestMessage = base::SysUTF8ToNSString(self.requestMessage);
+  if (self.requestSource.is_main_frame()) {
+    // If the requesting page's URL is already displayed in the location bar,
+    // there is no need to add information about the request source.  Instead,
+    // show the request's message text as the alert's title.
+    [_consumer setTitle:requestMessage];
   } else {
-    consumerTitle = l10n_util::GetNSString(
-        IDS_JAVASCRIPT_MESSAGEBOX_TITLE_NONSTANDARD_URL_IFRAME);
+    [_consumer
+        setTitle:l10n_util::GetNSString(
+                     IDS_JAVASCRIPT_MESSAGEBOX_TITLE_NONSTANDARD_URL_IFRAME)];
+    [_consumer setMessage:requestMessage];
   }
-  [_consumer setTitle:consumerTitle];
 }
 
 @end

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator_unittest.mm

@@ -11,6 +11,7 @@
 #include "ios/chrome/browser/overlays/public/web_content_area/java_script_dialog_source.h"
 #include "ios/chrome/browser/overlays/test/fake_overlay_user_data.h"
 #import "ios/chrome/browser/ui/alert_view_controller/test/fake_alert_consumer.h"
+#import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator+subclassing.h"
 #import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/test/java_script_dialog_overlay_mediator_test.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/web/public/test/fakes/test_web_state.h"
@@ -26,22 +27,26 @@
     : JavaScriptDialogOverlayMediator {
   web::TestWebState _webState;
   std::unique_ptr<JavaScriptDialogSource> _source;
+  std::string _message;
 }
 // Initializer for a mediator that has a JavaScriptDialogSource with |sourceURL|
-// and |isMainFrame|.
+// and |isMainFrame|.  |message| is the dialog's message text.
 - (instancetype)initWithRequest:(OverlayRequest*)request
                       sourceURL:(const GURL&)sourceURL
-                    isMainFrame:(BOOL)isMainFrame;
+                    isMainFrame:(BOOL)isMainFrame
+                        message:(const std::string&)message;
 @end
 
 @implementation FakeJavaScriptDialogOverlayMediator
 
 - (instancetype)initWithRequest:(OverlayRequest*)request
                       sourceURL:(const GURL&)sourceURL
-                    isMainFrame:(BOOL)isMainFrame {
+                    isMainFrame:(BOOL)isMainFrame
+                        message:(const std::string&)message {
   if (self = [super initWithRequest:request]) {
     _source = std::make_unique<JavaScriptDialogSource>(&_webState, sourceURL,
                                                        isMainFrame);
+    _message = message;
   }
   return self;
 }
@@ -50,8 +55,12 @@
 
 @implementation FakeJavaScriptDialogOverlayMediator (Subclassing)
 
-- (const JavaScriptDialogSource*)requestSource {
-  return _source.get();
+- (const JavaScriptDialogSource&)requestSource {
+  return *_source.get();
+}
+
+- (const std::string&)requestMessage {
+  return _message;
 }
 
 @end
@@ -59,34 +68,38 @@
 // Test fixture for JavaScriptDialogOverlayMediator.
 using JavaScriptDialogOverlayMediatorTest = JavaScriptDialogOverlayMediatorTest;
 
-// Tests the title for a JavaScript dialog from the main frame.
-TEST_F(JavaScriptDialogOverlayMediatorTest, MainFrameTitle) {
+// Tests the JavaScript dialog setup from the main frame.
+TEST_F(JavaScriptDialogOverlayMediatorTest, MainFrame) {
   std::unique_ptr<OverlayRequest> request =
       OverlayRequest::CreateWithConfig<FakeOverlayUserData>(nullptr);
   const GURL kUrl("https://chromium.org");
+  const std::string kMessage("Message");
   SetMediator([[FakeJavaScriptDialogOverlayMediator alloc]
       initWithRequest:request.get()
             sourceURL:kUrl
-          isMainFrame:YES]);
+          isMainFrame:YES
+              message:kMessage]);
 
-  base::string16 title = url_formatter::FormatUrlForSecurityDisplay(
-      kUrl, url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS);
-  NSString* expected_title =
-      l10n_util::GetNSStringF(IDS_JAVASCRIPT_MESSAGEBOX_TITLE, title);
-  EXPECT_NSEQ(expected_title, consumer().title);
+  // For the main frame, the URL is already displayed in the location bar, so
+  // there is no need to add source information.  The message is used as the
+  // consumer's title in this case.
+  EXPECT_NSEQ(base::SysUTF8ToNSString(kMessage), consumer().title);
 }
 
-// Tests the title for a JavaScript dialog from the main frame.
-TEST_F(JavaScriptDialogOverlayMediatorTest, IFrameTitle) {
+// Tests the JavaScript dialog setup from an iframe.
+TEST_F(JavaScriptDialogOverlayMediatorTest, IFrameSetup) {
   std::unique_ptr<OverlayRequest> request =
       OverlayRequest::CreateWithConfig<FakeOverlayUserData>(nullptr);
   const GURL kUrl("https://chromium.org");
+  const std::string kMessage("Message");
   SetMediator([[FakeJavaScriptDialogOverlayMediator alloc]
       initWithRequest:request.get()
             sourceURL:kUrl
-          isMainFrame:NO]);
+          isMainFrame:NO
+              message:kMessage]);
 
   NSString* expected_title = l10n_util::GetNSString(
       IDS_JAVASCRIPT_MESSAGEBOX_TITLE_NONSTANDARD_URL_IFRAME);
   EXPECT_NSEQ(expected_title, consumer().title);
+  EXPECT_NSEQ(base::SysUTF8ToNSString(kMessage), consumer().message);
 }

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_prompt_overlay_mediator.mm

@@ -15,6 +15,7 @@
 #import "ios/chrome/browser/ui/overlays/overlay_request_coordinator_delegate.h"
 #import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_blocking_action.h"
 #import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_coordinator+subclassing.h"
+#import "ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_dialog_overlay_mediator+subclassing.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ -34,10 +35,6 @@ NSString* const kJavaScriptPromptTextFieldAccessibiltyIdentifier =
 
 #pragma mark - Accessors
 
-- (const JavaScriptDialogSource*)requestSource {
-  return &self.config->source();
-}
-
 - (JavaScriptPromptOverlayRequestConfig*)config {
   return self.request->GetConfig<JavaScriptPromptOverlayRequestConfig>();
 }
@@ -91,3 +88,15 @@ NSString* const kJavaScriptPromptTextFieldAccessibiltyIdentifier =
 }
 
 @end
+
+@implementation JavaScriptPromptOverlayMediator (Subclassing)
+
+- (const JavaScriptDialogSource&)requestSource {
+  return self.config->source();
+}
+
+- (const std::string&)requestMessage {
+  return self.config->message();
+}
+
+@end

ios/chrome/browser/ui/overlays/web_content_area/java_script_dialogs/java_script_prompt_overlay_mediator_unittest.mm

@@ -88,8 +88,28 @@ class JavaScriptPromptOverlayMediatorTest
   FakePromptOverlayMediatorDataSource* data_source_ = nil;
 };
 
-// Tests that the consumer values are set correctly for main frame prompts.
-TEST_F(JavaScriptPromptOverlayMediatorTest, PromptSetup) {
+// Tests that the consumer values are set correctly for main frame prompts from
+// the main frame.
+TEST_F(JavaScriptPromptOverlayMediatorTest, PromptSetupMainFrame) {
+  CreateMediator();
+
+  // Verify the consumer values.
+  EXPECT_NSEQ(base::SysUTF8ToNSString(message()), consumer().title);
+  ASSERT_EQ(1U, consumer().textFieldConfigurations.count);
+  EXPECT_NSEQ(base::SysUTF8ToNSString(default_prompt_value()),
+              consumer().textFieldConfigurations[0].text);
+  EXPECT_FALSE(!!consumer().textFieldConfigurations[0].placeholder);
+  EXPECT_NSEQ(kJavaScriptPromptTextFieldAccessibiltyIdentifier,
+              consumer().textFieldConfigurations[0].accessibilityIdentifier);
+  ASSERT_EQ(2U, consumer().actions.count);
+  EXPECT_EQ(UIAlertActionStyleDefault, consumer().actions[0].style);
+  EXPECT_NSEQ(l10n_util::GetNSString(IDS_OK), consumer().actions[0].title);
+  EXPECT_EQ(UIAlertActionStyleCancel, consumer().actions[1].style);
+  EXPECT_NSEQ(l10n_util::GetNSString(IDS_CANCEL), consumer().actions[1].title);
+}
+
+// Tests that the consumer values are set correctly for prompts from iframes.
+TEST_F(JavaScriptPromptOverlayMediatorTest, PromptSetupIframe) {
   CreateMediator();
 
   // Verify the consumer values.