Commit 9757f66b authored by Henrique Nakashima's avatar Henrique Nakashima Committed by Commit Bot

Remove LegacyFeatureUtilities and legacy methods in CachedFeatureFlags

References were migrated downstream, so these are not needed anymore.

Conveniently, this gets rid of the last dependency out of
CachedFeatureFlags so it can be moved to a separate module.

Bug: 1012975
Change-Id: I4716689255c2c3a8ad641c2716bf7c319353c68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071109
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745283}
parent 42feab91
......@@ -735,7 +735,6 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java",
"java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java",
"java/src/org/chromium/chrome/browser/flags/ChromeSessionState.java",
"java/src/org/chromium/chrome/browser/flags/LegacyFeatureUtilities.java",
"java/src/org/chromium/chrome/browser/fullscreen/BrowserStateBrowserControlsVisibilityDelegate.java",
"java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java",
"java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java",
......
......@@ -14,7 +14,6 @@ import org.chromium.base.annotations.NativeMethods;
import org.chromium.base.library_loader.LibraryLoader;
import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
import org.chromium.chrome.browser.toolbar.bottom.BottomToolbarConfiguration;
import java.util.HashMap;
import java.util.List;
......@@ -303,13 +302,6 @@ public class CachedFeatureFlags {
ChromePreferenceKeys.FLAGS_CACHED_NETWORK_SERVICE_WARM_UP_ENABLED, false);
}
/**
* @return Whether immersive ui mode is enabled.
*/
public static boolean isImmersiveUiModeEnabled() {
return isEnabled(ChromeFeatureList.IMMERSIVE_UI_MODE);
}
/**
* Returns whether to use {@link Window#setFormat()} to undo opacity change caused by
* {@link Activity#convertFromTranslucent()}.
......@@ -404,12 +396,6 @@ public class CachedFeatureFlags {
return swapped;
}
@Deprecated
public static boolean isBottomToolbarEnabled() {
// TODO(crbug.com/1012975): Remove this when downstream calls BottomToolbarConfiguration.
return BottomToolbarConfiguration.isBottomToolbarEnabled();
}
@NativeMethods
interface Natives {
boolean isNetworkServiceWarmUpEnabled();
......
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
package org.chromium.chrome.browser.flags;
/**
* Temporary class, identical to {@link CachedFeatureFlags}, for migration.
*
* This class will be referenced temporarily while FeatureUtilities is renamed.
*
* TODO(crbug.com/1012975): Remove this class after downstream references FeatureUtilities by the
* new name.
*/
public class LegacyFeatureUtilities extends CachedFeatureFlags {}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment