Remove -Wno-user-defined-warnings flag

The flag suppressed user defined warning from libc++
https://github.com/llvm-project/llvm-project-20170507/blob/a2e822e3ac432da65d730dca1f2cbeee49f6e235/libcxx/include/__tree#L1848

I think this will be useful to prevent forgotten const.

Bug: 683349
Change-Id: I24199ae9bf065ee6560b6caa397cd5fd8c042e83
Reviewed-on: https://chromium-review.googlesource.com/c/1286103
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601055}

ash/accelerators/accelerator_table_unittest.cc

@@ -23,7 +23,8 @@ constexpr char kNonSearchAcceleratorsHash[] =
     "66028d49a13708e1c1d8c5791d37a8e4";
 
 struct Cmp {
-  bool operator()(const AcceleratorData& lhs, const AcceleratorData& rhs) {
+  bool operator()(const AcceleratorData& lhs,
+                  const AcceleratorData& rhs) const {
     // Do not check |action|.
     return std::tie(lhs.trigger_on_press, lhs.keycode, lhs.modifiers) <
            std::tie(rhs.trigger_on_press, rhs.keycode, rhs.modifiers);

build/config/compiler/BUILD.gn

@@ -1486,9 +1486,6 @@ config("default_warnings") {
           # TODO(thakis): https://crbug.com/617318
           "-Wno-nonportable-include-path",
 
-          # TODO(thakis): https://crbug.com/683349
-          "-Wno-user-defined-warnings",
-
           # TODO(hans): https://crbug.com/681136
           "-Wno-unused-lambda-capture",
         ]

chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc

@@ -191,7 +191,7 @@ TabMemoryMetricsReporter::NextStateOfEmitMemoryDumpAfterPageLoaded(
 
 bool TabMemoryMetricsReporter::WebContentsDataComparator::operator()(
     const WebContentsData& a,
-    const WebContentsData& b) {
+    const WebContentsData& b) const {
   return a.next_emit_time < b.next_emit_time;
 }
 

chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h

@@ -63,7 +63,7 @@ class TabMemoryMetricsReporter : public TabLoadTracker::Observer {
   };
 
   struct WebContentsDataComparator {
-    bool operator()(const WebContentsData& a, const WebContentsData& b);
+    bool operator()(const WebContentsData& a, const WebContentsData& b) const;
   };
 
   void MonitorWebContents(content::WebContents* web_contents);

third_party/sfntly/BUILD.gn

@@ -16,6 +16,12 @@ config("sfntly_public_config") {
 config("sfntly_common_config") {
   defines = [ "SFNTLY_NO_EXCEPTION" ]
   include_dirs = [ "src/cpp/src" ]
+
+  if (is_clang) {
+    # TODO(tikuta): Remove this once the PR is merged.
+    # https://github.com/googlei18n/sfntly/pull/104
+    cflags = [ "-Wno-user-defined-warnings" ]
+  }
 }
 
 source_set("sfntly_chromium") {

ui/gfx/image/image_generic.cc

@@ -76,7 +76,7 @@ class PNGImageSource : public ImageSkiaSource {
 
  private:
   struct Compare {
-    bool operator()(const ImageSkiaRep& rep1, const ImageSkiaRep& rep2) {
+    bool operator()(const ImageSkiaRep& rep1, const ImageSkiaRep& rep2) const {
       return rep1.scale() < rep2.scale();
     }
   };