Commit 977f8ce6 authored by Jan Scheffler's avatar Jan Scheffler Committed by Commit Bot

[Devtools] Reenable test for Cookie refactoring

This cl reenables and fixes a test to refactor
how Cookies are handled in devtools frontend.

Cl with the actual changes: crrev.com/c/1959984
Cl disabling the test: crrev.com/c/1960350



Bug: chromium:1030258
Change-Id: I8f8bf9f4b0a6956dbbd019a5ced88fa2db066648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960279
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: default avatarBenedikt Meurer <bmeurer@chromium.org>
Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727991}
parent 4151e9e4
...@@ -6079,7 +6079,6 @@ crbug.com/993790 virtual/document-policy/external/wpt/document-policy/required-p ...@@ -6079,7 +6079,6 @@ crbug.com/993790 virtual/document-policy/external/wpt/document-policy/required-p
crbug.com/1029489 http/tests/devtools/elements/elements-linkify-attributes.js [ Pass Failure ] crbug.com/1029489 http/tests/devtools/elements/elements-linkify-attributes.js [ Pass Failure ]
crbug.com/1029826 http/tests/devtools/copy-network-request.js [ Pass Failure ] crbug.com/1029826 http/tests/devtools/copy-network-request.js [ Pass Failure ]
crbug.com/1029521 virtual/threaded/external/wpt/web-animations/timing-model/animations/updating-the-finished-state.html [ Pass Failure Timeout ] crbug.com/1029521 virtual/threaded/external/wpt/web-animations/timing-model/animations/updating-the-finished-state.html [ Pass Failure Timeout ]
crbug.com/1030258 http/tests/devtools/components/cookie-parser.js [ Pass Failure ]
crbug.com/1030258 http/tests/devtools/network/network-cookies-pane.js [ Pass Failure ] crbug.com/1030258 http/tests/devtools/network/network-cookies-pane.js [ Pass Failure ]
crbug.com/1019723 http/tests/devtools/network/waterfall-header-height-updates.js [ Pass Failure ] crbug.com/1019723 http/tests/devtools/network/waterfall-header-height-updates.js [ Pass Failure ]
......
...@@ -13,10 +13,9 @@ ...@@ -13,10 +13,9 @@
var output = 'name: ' + cookie.name() + ', value: ' + cookie.value() + ', httpOnly: ' + cookie.httpOnly() + var output = 'name: ' + cookie.name() + ', value: ' + cookie.value() + ', httpOnly: ' + cookie.httpOnly() +
', sameSite: ' + cookie.sameSite() + ', secure: ' + cookie.secure() + ', session: ' + cookie.session() + ', sameSite: ' + cookie.sameSite() + ', secure: ' + cookie.secure() + ', session: ' + cookie.session() +
', path: ' + cookie.path() + ', domain: ' + cookie.domain() + ', port: ' + cookie.port() + ', path: ' + cookie.path() + ', domain: ' + cookie.domain() + ', port: ' + cookie.port() +
', expires: ' + (expires ? expires.getTime() : 'n/a') + ', size: ' + cookie.size(); ', expires: ' + (expires ? expires.getTime() : 'n/a') + ', size: ' + cookie.size() + ', priority: ' + cookie.priority();
TestRunner.addResult(output); TestRunner.addResult(output);
TestRunner.addObject(cookie.attributes());
}; };
TestRunner.dumpCookies = function(cookies) { TestRunner.dumpCookies = function(cookies) {
...@@ -61,5 +60,8 @@ ...@@ -61,5 +60,8 @@
TestRunner.parseAndDumpSetCookie('cooke1 = value; HttpOnly; Secure; SameSite=Secure;'); TestRunner.parseAndDumpSetCookie('cooke1 = value; HttpOnly; Secure; SameSite=Secure;');
TestRunner.parseAndDumpSetCookie('cooke1; Path=/; Domain=.example.com;'); TestRunner.parseAndDumpSetCookie('cooke1; Path=/; Domain=.example.com;');
TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com;'); TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com;');
TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com; Priority=High');
TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com; Priority=Low');
TestRunner.parseAndDumpSetCookie('cooke1=; Path=/; Domain=.example.com; Priority=Medium');
TestRunner.completeTest(); TestRunner.completeTest();
})(); })();
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment