frameElement-siblings.sub.html VS document.domain - test expectations.

wpt/external/wpt/html/browsers/windows/nested-browsing-contexts/frameElement-siblings.sub.html
uses document.domain, which means that it is incompatible with isolating
each individual WPT origin (the default) and should only be run as part
of virtual/not-site-per-process test suite.

Additionally, after a past WPT roll, the test started passing when run
in not-site-per-process mode.

Based on the above, the CL makes two changes:
1) add the test to the not-site-per-process virtual test suite
2) remove
   windows/nested-browsing-contexts/frameElement-siblings.sub-expected.txt

Fixed: 1099689
Change-Id: I4192736ede4ee1fb4a59992ed8edd42d75cd2a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288380
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821444}

third_party/blink/web_tests/NeverFixTests

@@ -1888,9 +1888,9 @@ external/wpt/xhr/send-authentication-prompt-2-manual.htm [ Skip ]
 #
 # When modifying the list of files that behave differently with and without
 # OOPIFs, please consider modifying all the locations below:
-# - LayoutTests/NeverFixTests (the section here)
-# - LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
-# - LayoutTests/virtual/not-site-per-process/README.md
+# - web_tests/NeverFixTests (the section here)
+# - web_tests/VirtualTestSuites (virtual/not-site-per-process suite)
+# - web_tests/virtual/not-site-per-process/README.md
 #
 # --------------------------- document.domain -----------------------
 # To test OOPIF support in various web platform features, we isolate all WPT
@@ -1911,6 +1911,7 @@ external/wpt/html/browsers/history/the-location-interface/allow_prototype_cycle_
 external/wpt/html/browsers/history/the-location-interface/location-prototype-setting-same-origin-domain.sub.html [ Skip ]
 external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-on-new-window.html [ Skip ]
 external/wpt/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-same-origin-domain.sub.html [ Skip ]
+external/wpt/html/browsers/windows/nested-browsing-contexts/frameElement-siblings.sub.html [ Skip ]
 external/wpt/wasm/serialization/module/window-domain-success.sub.html [ Skip ]
 external/wpt/wasm/serialization/module/window-similar-but-cross-origin-success.sub.html [ Skip ]
 virtual/not-site-per-process/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/* [ Pass ]
@@ -1923,6 +1924,7 @@ virtual/not-site-per-process/external/wpt/html/browsers/history/the-location-int
 virtual/not-site-per-process/external/wpt/html/browsers/history/the-location-interface/location-prototype-setting-same-origin-domain.sub.html [ Pass ]
 virtual/not-site-per-process/external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-on-new-window.html [ Pass ]
 virtual/not-site-per-process/external/wpt/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-same-origin-domain.sub.html [ Pass ]
+virtual/not-site-per-process/external/wpt/html/browsers/windows/nested-browsing-contexts/frameElement-siblings.sub.html [ Pass ]
 virtual/not-site-per-process/external/wpt/wasm/serialization/module/window-domain-success.sub.html [ Pass ]
 virtual/not-site-per-process/external/wpt/wasm/serialization/module/window-similar-but-cross-origin-success.sub.html [ Pass ]
 # -------------------- origin-vs-url in console messages -----------------

third_party/blink/web_tests/TestExpectations

@@ -5981,7 +5981,6 @@ crbug.com/867532 [ Linux ] http/tests/workers/worker-usecounter.html [ Pass Time
 # Tests blocking WPT importer
 crbug.com/1098844 external/wpt/wasm/jsapi/functions/entry.html [ Pass Crash Timeout ]
 crbug.com/1098844 external/wpt/wasm/jsapi/functions/entry-different-function-realm.html [ Pass Crash Timeout ]
-crbug.com/1099689 [ Linux ] external/wpt/html/browsers/windows/nested-browsing-contexts/frameElement-siblings.sub.html [ Pass Failure ]
 
 #Sheriff 2020-06-25
 crbug.com/1010170 media/video-played-reset.html [ Pass Failure ]

third_party/blink/web_tests/VirtualTestSuites

@@ -475,6 +475,7 @@
     "prefix": "not-site-per-process",
     "bases": [
       "external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction",
+      "external/wpt/html/browsers/windows/nested-browsing-contexts/frameElement-siblings.sub.html",
       "external/wpt/FileAPI/url/multi-global-origin-serialization.sub.html",
       "external/wpt/dom/events/EventListener-incumbent-global-1.sub.html",
       "external/wpt/dom/events/EventListener-incumbent-global-2.sub.html",

third_party/blink/web_tests/external/wpt/html/browsers/windows/nested-browsing-contexts/frameElement-siblings.sub-expected.txt

-This is a testharness.js-based test.
-PASS it must give a "SecurityError" DOMException if the pages are different-origin domain
-FAIL it must return the iframe element if the pages are same-origin domain assert_equals: expected "HTMLIFrameElement" but got "SecurityError"
-Harness: the test ran to completion.
-

third_party/blink/web_tests/virtual/not-site-per-process/README.md

@@ -26,9 +26,9 @@ cross-origin resources were cached.
 
 When modifying the list of files that behave differently with and without
 OOPIFs, please consider modifying all the locations below:
-- LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
-- LayoutTests/virtual/not-site-per-process/README.md
-- LayoutTests/TestExpectations and/or LayoutTests/NeverFixTests
+- web_tests/VirtualTestSuites (virtual/not-site-per-process suite)
+- web_tests/virtual/not-site-per-process/README.md
+- web_tests/TestExpectations and/or web_tests/NeverFixTests
   ("Site Isolation failures" section)
 
 
@@ -37,9 +37,10 @@ OOPIFs, please consider modifying all the locations below:
 The following tests modify `document.domain` and are therefore incompatible with
 isolation of WPT origins.  The tests need to stay under
 `virtual/not-site-per-process` forever.  These tests are covered by
-`LayoutTests/NeverFixTests` expectations file.
+`web_tests/NeverFixTests` expectations file.
 
 - external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction
+- external/wpt/html/browsers/windows/nested-browsing-contexts/frameElement-siblings.sub.html
 - external/wpt/FileAPI/url/multi-global-origin-serialization.sub.html
 - external/wpt/dom/events/EventListener-incumbent-global-1.sub.html
 - external/wpt/dom/events/EventListener-incumbent-global-2.sub.html
@@ -59,4 +60,4 @@ previously unknown OOPIF-related bugs or 2) expose known OOPIF-related
 differences in product behavior or 3) expose known OOPIF-support issues
 in tests or in the test harness.  Over time, such tests should be
 removed from `virtual/not-site-per-process`.  These tests are covered
-by `LayoutTests/TestExpectations` file.
+by `web_tests/TestExpectations` file.