Commit 97aaf21b authored by Rahul Arakeri's avatar Rahul Arakeri Committed by Commit Bot

Enabled autoscrolling tests.

This CL enables autoscrolling tests on Mac.

Bug: 953847
Change-Id: I90a4fcd918c3558db7caae8c6134eac354bb0306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061197
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742711}
parent 5d06121b
...@@ -2728,12 +2728,6 @@ crbug.com/332189 external/wpt/css/css-transitions/no-transition-from-ua-to-block ...@@ -2728,12 +2728,6 @@ crbug.com/332189 external/wpt/css/css-transitions/no-transition-from-ua-to-block
crbug.com/552085 external/wpt/css/css-cascade/important-prop.html [ Failure ] crbug.com/552085 external/wpt/css/css-cascade/important-prop.html [ Failure ]
# Failures on Mac scrollbars for compositor threaded scrollbar scrolling.
crbug.com/953847 [ Mac ] fast/scrolling/scrollbars/mouse-autoscrolling-on-scrollbar.html [ Failure Timeout ]
crbug.com/953847 [ Mac ] virtual/threaded-prefer-compositing/fast/scrolling/scrollbars/mouse-autoscrolling-on-scrollbar.html [ Failure Timeout ]
crbug.com/953847 [ Mac ] virtual/scroll_customization/fast/scrolling/scrollbars/mouse-autoscrolling-on-scrollbar.html [ Failure Timeout ]
crbug.com/953847 [ Mac ] virtual/compositor_threaded_scrollbar_scrolling/fast/scrolling/scrollbars/mouse-autoscrolling-on-scrollbar.html [ Failure Timeout ]
# Some control characters still not visible # Some control characters still not visible
crbug.com/893490 [ Mac ] external/wpt/css/css-text/white-space/control-chars-001.html [ Failure ] crbug.com/893490 [ Mac ] external/wpt/css/css-text/white-space/control-chars-001.html [ Failure ]
crbug.com/893490 [ Mac ] external/wpt/css/css-text/white-space/control-chars-002.html [ Failure ] crbug.com/893490 [ Mac ] external/wpt/css/css-text/white-space/control-chars-002.html [ Failure ]
......
...@@ -37,15 +37,18 @@ ...@@ -37,15 +37,18 @@
const scroller = document.getElementById("scroller"); const scroller = document.getElementById("scroller");
const scrollerRect = scroller.getBoundingClientRect(); const scrollerRect = scroller.getBoundingClientRect();
const onMacPlatform = navigator.userAgent.search(/\bMac OS X\b/) != -1;
const TRACK_WIDTH = calculateScrollbarThickness(); const TRACK_WIDTH = calculateScrollbarThickness();
const BUTTON_WIDTH = TRACK_WIDTH; const BUTTON_WIDTH = TRACK_WIDTH;
const SCROLL_CORNER = TRACK_WIDTH; const SCROLL_CORNER = TRACK_WIDTH;
const SCROLL_DELTA = 400; const SCROLL_DELTA = 400;
const MAX_SCROLLER_OFFSET = 1915; const MAX_SCROLLER_OFFSET = 1915;
const PRESS_DURATION = 1000;
promise_test (async () => { promise_test (async () => {
if(onMacPlatform)
return;
await waitForCompositorCommit(); await waitForCompositorCommit();
scroller.scrollTop = 0; scroller.scrollTop = 0;
...@@ -79,11 +82,10 @@ ...@@ -79,11 +82,10 @@
`scroller.scrollTop = ${scroller.scrollTop} never went beyond ${SCROLL_DELTA}`); `scroller.scrollTop = ${scroller.scrollTop} never went beyond ${SCROLL_DELTA}`);
await mouseUpAt(trackscroll_x, trackscroll_y); await mouseUpAt(trackscroll_x, trackscroll_y);
// Verify that the track autoscroll actually stops as expected. Since track // Verify that the track autoscroll actually stops as expected. Autoscroll velocity
// autoscroll in this particular case is 1480 px/sec (i.e 74 * 20), holding the // in this particular case is 1480 px/sec (i.e 74 * 20). There is currently a bug in
// pointer pressed for 1000ms (i.e PRESS_DURATION) would've continued scrolling to // the main thread autoscrolling code that causes autoscrolling to happen at a
// around 1100px. The fact it stops short even though the pointer remains pressed // much lower velocity (crbug.com/1053398)
// verifies that the track autoscroll was canceled.
assert_less_than(scroller.scrollTop, 800, "Track autosroll did not end."); assert_less_than(scroller.scrollTop, 800, "Track autosroll did not end.");
const current_offset = scroller.scrollTop; const current_offset = scroller.scrollTop;
...@@ -92,6 +94,13 @@ ...@@ -92,6 +94,13 @@
},"Test track autoscroll down and autoscroll stop."); },"Test track autoscroll down and autoscroll stop.");
promise_test (async () => { promise_test (async () => {
// Scrollbars on Mac don't have arrows. This test is irrelevant. Infinite auto
// scroll can't be tested for track scrolls since autoscrolling aborts the as
// soon as the thumb reaches the pointer. Regular autoscrolling still has coverage
// on all platforms.
if(onMacPlatform)
return;
await waitForCompositorCommit(); await waitForCompositorCommit();
scroller.scrollTop = MAX_SCROLLER_OFFSET; scroller.scrollTop = MAX_SCROLLER_OFFSET;
...@@ -122,6 +131,10 @@ ...@@ -122,6 +131,10 @@
},"Test infinite scrolling when content is extended dynamically."); },"Test infinite scrolling when content is extended dynamically.");
promise_test (async () => { promise_test (async () => {
// Scrollbars on Mac don't have arrows. This test is irrelevant.
if(onMacPlatform)
return;
scroller.scrollTop = 0; scroller.scrollTop = 0;
const SCROLL_TOP = 100; const SCROLL_TOP = 100;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment